GNU bug report logs - #72397
[PATCH] gnu: Add fennel-ls.

Previous Next

To reply to this bug, email your comments to 72397 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sydney goose <lomiskiam <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add fennel-ls.
Date: Wed, 31 Jul 2024 00:27:44 -0600

[Message part 1 (text/plain, inline)]

* gnu/packages/fennel.scm (fennel-ls): New variable.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-fennel-ls.patch (text/x-patch, attachment)]

Message #8 received at 72397 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: sydney goose <lomiskiam <at> gmail.com>, 72397 <at> debbugs.gnu.org
Subject: Re: [bug#72397] [PATCH] gnu: Add fennel-ls.
Date: Thu, 15 Aug 2024 16:32:01 +0200

On 2024-07-31 00:27, sydney goose wrote:

> * gnu/packages/fennel.scm (fennel-ls): New variable.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://git.sr.ht/~xerool/fennel-ls/archive/"
> +                           version ".tar.gz"))
> +       (sha256
> +        (base32 "0nb3yclv9v2mwcnam5djvhg0vgmdsk0gavbvq1ar5v2j0m9pzr7f"))))

Is there a reason why we use archives rather than git fetching here?
Otherwise I would advise against, given the codebase is small.
This would probably also solve the two following lints:

fennel-ls <at> 0.1.3: the source file name should contain the package name
fennel-ls <at> 0.1.3: no updater for fennel-ls

> +    (build-system gnu-build-system)
> +    (arguments
> +     (list
> +      #:test-target "test"
> +      #:phases #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (add-after 'build 'patch-fennel-ls
> +                     (lambda* (#:key inputs #:allow-other-keys)
> +                       (substitute* "fennel-ls"
> +                         (("/usr/bin/env .*lua")
> +                          (search-input-file inputs "/bin/lua"))))))
> +      #:make-flags #~(list (string-append "PREFIX="
> +                                          (assoc-ref %outputs "out")))))
> +    (inputs (list lua-5.4 fennel))
> +    (home-page "https://git.sr.ht/~xerool/fennel-ls")
> +    (license license:expat)
> +    (synopsis "Provides intelligent editing features for Fennel files")

Nitpick/proposition : "A language server for Fennel"

> +    (description "A language server for Fennel.  Provides intelligent editing
> +features for Fennel files.")))

Nitpick/proposition : "This package provides a language server for
Fennel that provides intelligent editing features for Fennel files."

Otherwise LGTM. Please send an updated patch ;)

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.