GNU bug report logs - #72396
[PATCH 0/2] gnu: Add zydis.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72396 in the body.
You can then email your comments to 72396 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 0/2] gnu: Add zydis.
Date: Wed, 31 Jul 2024 19:12:03 +0900

Zydis is a library for x86 and amd64 disassembly and decoding.
My goal is to package E9Patch (amd64 binary patching tool)
which depends on it but upstream needs a bit of clean up.

Nguyễn Gia Phong (2):
  gnu: Add zycore.
  gnu: Add zydis.

 gnu/packages/engineering.scm | 55 ++++++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)


base-commit: f59c4126827af3d2041d49f1d0a8ce12b41470cf
-- 
2.45.2

Message #8 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 72396 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 1/2] gnu: Add zycore.
Date: Wed, 31 Jul 2024 19:14:34 +0900

* gnu/packages/engineering.scm (zycore): New variable.

Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
---
 gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index f411d4ac1ed6..b6ae19101b42 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -40,6 +40,7 @@
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2023 pinoaffe <pinoaffe <at> gmail.com>
 ;;; Copyright © 2024 Juliana Sims <juli <at> incana.org>
+;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1926,6 +1927,29 @@ (define-public radare2
 it suitable for security research and analysis.")
     (license license:lgpl3)))
 
+(define-public zycore
+  (package
+    (name "zycore")
+    (version "1.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zycore-c")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (native-inputs (list googletest))
+    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
+                                     "-DZYCORE_BUILD_TESTS=ON")))
+    (home-page "https://github.com/zyantific/zycore-c")
+    (synopsis "Internal library for Zydis.")
+    (description
+     "This package provides platfrom-independent types, macros
+and a fallback for environments without libc for Zydis.")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

Message #11 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 72396 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH 2/2] gnu: Add zydis.
Date: Wed, 31 Jul 2024 19:14:36 +0900

* gnu/packages/engineering.scm (zydis): New variable.

Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
---
 gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index b6ae19101b42..4eb0e6cb6b9a 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1950,6 +1950,37 @@ (define-public zycore
 and a fallback for environments without libc for Zydis.")
     (license license:expat)))
 
+(define-public zydis
+  (package
+    (name "zydis")
+    (version "4.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zydis")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
+                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
+                                     "-DZYDIS_BUILD_MAN=ON")))
+    (native-inputs (list python ronn-ng))
+    (inputs (list zycore))
+    (home-page "https://zydis.re")
+    (synopsis "Disassembler and code generation library for x86 and AMD64")
+    (description
+     "Zydis is a decoder and disassembler library with the following features:
+@itemize
+@item Support for all x86 and AMD64 instructions and extensions
+@item Optimization for high performance
+@item No dynamic memory allocation
+@item Thread-safe by design
+@item Smaller file-size overhead compared to other common disassembler libraries
+@end itemize")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

Message #14 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 72396 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: Re: [bug#72396] [PATCH 1/2] gnu: Add zycore.
Date: Thu, 15 Aug 2024 16:19:28 +0200

On 2024-07-31 19:14, guix-patches--- via wrote:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> +    (synopsis "Internal library for Zydis.")

Hi Nguyễn Gia Phong,

A minor nitpick:
zycore <at> 1.5.0: no period allowed at the end of the synopsis

Checking `guix lint` would have told you ;)

Otherwise LGTM, built and rebuilt deterministically.

-- 
Best regards,
Nicolas Graves

Message #17 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 72396 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH v2 2/2] gnu: Add zydis.
Date: Sun, 18 Aug 2024 11:23:00 +0900

* gnu/packages/engineering.scm (zydis): New variable.

Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
---
This patch is identical to the one in v1.

 gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 24dc4f0197c7..fba30809e18b 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -1951,6 +1951,37 @@ (define-public zycore
 and a fallback for environments without libc for Zydis.")
     (license license:expat)))
 
+(define-public zydis
+  (package
+    (name "zydis")
+    (version "4.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zydis")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
+                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
+                                     "-DZYDIS_BUILD_MAN=ON")))
+    (native-inputs (list python ronn-ng))
+    (inputs (list zycore))
+    (home-page "https://zydis.re")
+    (synopsis "Disassembler and code generation library for x86 and AMD64")
+    (description
+     "Zydis is a decoder and disassembler library with the following features:
+@itemize
+@item Support for all x86 and AMD64 instructions and extensions
+@item Optimization for high performance
+@item No dynamic memory allocation
+@item Thread-safe by design
+@item Smaller file-size overhead compared to other common disassembler libraries
+@end itemize")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")
-- 
2.45.2

Message #20 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: 72396 <at> debbugs.gnu.org
Cc: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: [PATCH v2 1/2] gnu: Add zycore.
Date: Sun, 18 Aug 2024 11:22:59 +0900

* gnu/packages/engineering.scm (zycore): New variable.

Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
---
On 2024-08-15 at 16:19+02:00, Nicolas Graves wrote:
> On 2024-07-31 19:14, Nguyễn Gia Phong via wrote:
>
> > * gnu/packages/engineering.scm (zycore): New variable.
> >
> > +    (synopsis "Internal library for Zydis.")
> A minor nitpick:
> zycore <at> 1.5.0: no period allowed at the end of the synopsis
>
> Checking `guix lint` would have told you ;)
>
> Otherwise LGTM, built and rebuilt deterministically.

Thanks, this revision fixes that.

I cannot get guix lint to tell that to me however
(I ran `./pre-inst-env guix lint zycore`).

 gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index 7a9c0bc436f7..24dc4f0197c7 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -40,6 +40,7 @@
 ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2023 pinoaffe <pinoaffe <at> gmail.com>
 ;;; Copyright © 2024 Juliana Sims <juli <at> incana.org>
+;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx <at> disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1927,6 +1928,29 @@ (define-public radare2
 it suitable for security research and analysis.")
     (license license:lgpl3)))
 
+(define-public zycore
+  (package
+    (name "zycore")
+    (version "1.5.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zyantific/zycore-c")
+                    (commit (string-append "v" version))))
+              (sha256
+               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
+              (file-name (git-file-name name version))))
+    (build-system cmake-build-system)
+    (native-inputs (list googletest))
+    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
+                                     "-DZYCORE_BUILD_TESTS=ON")))
+    (home-page "https://github.com/zyantific/zycore-c")
+    (synopsis "Internal library for Zydis")
+    (description
+     "This package provides platfrom-independent types, macros
+and a fallback for environments without libc for Zydis.")
+    (license license:expat)))
+
 (define-public asco
   (package
     (name "asco")

base-commit: 41c44ffd5659d13f5c1edb78d92ad27275ead78a
-- 
2.45.2

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: 72396-done <at> debbugs.gnu.org,
 Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: Re: [bug#72396] [PATCH v2 1/2] gnu: Add zycore.
Date: Mon, 19 Aug 2024 14:17:33 +0800

[Message part 1 (text/plain, inline)]

guix-patches--- via <guix-patches <at> gnu.org> writes:

> * gnu/packages/engineering.scm (zycore): New variable.
>
> Change-Id: Ia38413f43bc667a9a12916d3f0e786e06f6d358f
> ---
> On 2024-08-15 at 16:19+02:00, Nicolas Graves wrote:
>> On 2024-07-31 19:14, Nguyễn Gia Phong via wrote:
>>
>> > * gnu/packages/engineering.scm (zycore): New variable.
>> >
>> > +    (synopsis "Internal library for Zydis.")
>> A minor nitpick:
>> zycore <at> 1.5.0: no period allowed at the end of the synopsis
>>
>> Checking `guix lint` would have told you ;)
>>
>> Otherwise LGTM, built and rebuilt deterministically.
>
> Thanks, this revision fixes that.
>
> I cannot get guix lint to tell that to me however
> (I ran `./pre-inst-env guix lint zycore`).
>
>  gnu/packages/engineering.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 7a9c0bc436f7..24dc4f0197c7 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -40,6 +40,7 @@
>  ;;; Copyright © 2023 Sharlatan Hellseher <sharlatanus <at> gmail.com>
>  ;;; Copyright © 2023 pinoaffe <pinoaffe <at> gmail.com>
>  ;;; Copyright © 2024 Juliana Sims <juli <at> incana.org>
> +;;; Copyright © 2024 Nguyễn Gia Phong <mcsinyx <at> disroot.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1927,6 +1928,29 @@ (define-public radare2
>  it suitable for security research and analysis.")
>      (license license:lgpl3)))
>  
> +(define-public zycore
> +  (package
> +    (name "zycore")
> +    (version "1.5.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zyantific/zycore-c")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> +              (file-name (git-file-name name version))))

i move file-name before sha256.

> +    (build-system cmake-build-system)
> +    (native-inputs (list googletest))
> +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
                                        is ZYCORE_BUILD_SHARED_LIB                    
> +                                     "-DZYCORE_BUILD_TESTS=ON")))
 
i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

> +    (home-page "https://github.com/zyantific/zycore-c")
> +    (synopsis "Internal library for Zydis")
> +    (description
> +     "This package provides platfrom-independent types, macros
> +and a fallback for environments without libc for Zydis.")
> +    (license license:expat)))
> +
>  (define-public asco
>    (package
>      (name "asco")
>
> base-commit: 41c44ffd5659d13f5c1edb78d92ad27275ead78a

[signature.asc (application/pgp-signature, inline)]

Message #31 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches--- via <guix-patches <at> gnu.org>
Cc: 72396 <at> debbugs.gnu.org,
 Nguyễn Gia Phong <mcsinyx <at> disroot.org>
Subject: Re: [bug#72396] [PATCH v2 2/2] gnu: Add zydis.
Date: Mon, 19 Aug 2024 14:19:04 +0800

[Message part 1 (text/plain, inline)]

guix-patches--- via <guix-patches <at> gnu.org> writes:

> * gnu/packages/engineering.scm (zydis): New variable.
>
> Change-Id: I6e0b04e1d957f8c172e81177f6669415beeaf20a
> ---
> This patch is identical to the one in v1.
>
>  gnu/packages/engineering.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
> index 24dc4f0197c7..fba30809e18b 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -1951,6 +1951,37 @@ (define-public zycore
>  and a fallback for environments without libc for Zydis.")
>      (license license:expat)))
>  
> +(define-public zydis
> +  (package
> +    (name "zydis")
> +    (version "4.1.0")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/zyantific/zydis")
> +                    (commit (string-append "v" version))))
> +              (sha256
> +               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
> +              (file-name (git-file-name name version))))

move file-name before sha256.

> +    (build-system cmake-build-system)
> +    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
> +                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
> +                                     "-DZYDIS_BUILD_MAN=ON")))

use gexp.

> +    (native-inputs (list python ronn-ng))
> +    (inputs (list zycore))
> +    (home-page "https://zydis.re")
> +    (synopsis "Disassembler and code generation library for x86 and AMD64")
> +    (description
> +     "Zydis is a decoder and disassembler library with the following features:
> +@itemize
> +@item Support for all x86 and AMD64 instructions and extensions
> +@item Optimization for high performance
> +@item No dynamic memory allocation
> +@item Thread-safe by design
> +@item Smaller file-size overhead compared to other common disassembler libraries
> +@end itemize")
> +    (license license:expat)))
> +
>  (define-public asco
>    (package
>      (name "asco")

[signature.asc (application/pgp-signature, inline)]

Message #37 received at 72396 <at> debbugs.gnu.org (full text, mbox):

From: Nguyễn Gia Phong <mcsinyx <at> disroot.org>
To: "Zheng Junjie" <zhengjunjie <at> iscas.ac.cn>
Cc: 72396 <at> debbugs.gnu.org
Subject: Re: [bug#72396] [PATCH v2 2/2] gnu: Add zydis.
Date: Mon, 19 Aug 2024 16:54:50 +0900

[Message part 1 (text/plain, inline)]

On 2024-08-19 at 14:17+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zycore-c")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> > +              (file-name (git-file-name name version))))
>
> i move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (native-inputs (list googletest))
> > +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
>                                         is ZYCORE_BUILD_SHARED_LIB
> > +                                     "-DZYCORE_BUILD_TESTS=ON")))
>
> i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

On 2024-08-19 at 14:19+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zydis")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
> > +              (file-name (git-file-name name version))))
>
> move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
> > +                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
> > +                                     "-DZYDIS_BUILD_MAN=ON")))
>
> use gexp.

Thanks for the nits and application to master!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.