GNU bug report logs - #72380
srfi-64: test-end does not uninstall runner if on-final was modified

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72380 in the body.
You can then email your comments to 72380 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: bug-guile <at> gnu.org
Subject: srfi-64: test-end does not uninstall runner if on-final was modified
Date: Tue, 30 Jul 2024 21:51:58 +0200

Hello,

I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.

The specification for test-end says:

> Additionally, if the matching test-begin installed a new test-runner, then the
> test-end will uninstall it, after reporting the accumulated test results in an
> implementation-defined manner.

However in following example it fails to do so:

    (use-modules (srfi srfi-64))

    (pk (eq? #f (test-runner-current)))
    (test-begin "x")
    (test-runner-on-final! (test-runner-current) (λ (_) #t))
    (test-end)
    (pk (eq? #f (test-runner-current)))

Resulting in:

    ;;; (#t)
    %%%% Starting test x  (Writing full log to "x.log")

    ;;; (#f)

I see no provision in the specification that would justify this.

Have a nice day
Tomas Volf

Message #8 received at 72380 <at> debbugs.gnu.org (full text, mbox):

From: Taylan Kammer <taylan.kammer <at> gmail.com>
To: Tomas Volf <~@wolfsden.cz>, 72380 <at> debbugs.gnu.org
Subject: Re: bug#72380: srfi-64: test-end does not uninstall runner if
 on-final was modified
Date: Wed, 2 Oct 2024 00:34:53 +0200

On 30.07.2024 21:51, Tomas Volf wrote:
> Hello,
>
> I think I found a bug in (srfi srfi-64) module shipped with GNU Guile.
>
> The specification for test-end says:
>
>> Additionally, if the matching test-begin installed a new test-runner, then the
>> test-end will uninstall it, after reporting the accumulated test results in an
>> implementation-defined manner.
> However in following example it fails to do so:
>
>     (use-modules (srfi srfi-64))
>
>     (pk (eq? #f (test-runner-current)))
>     (test-begin "x")
>     (test-runner-on-final! (test-runner-current) (λ (_) #t))
>     (test-end)
>     (pk (eq? #f (test-runner-current)))
>
> Resulting in:
>
>     ;;; (#t)
>     %%%% Starting test x  (Writing full log to "x.log")
>
>     ;;; (#f)
>
> I see no provision in the specification that would justify this.
>
> Have a nice day
> Tomas Volf
>
>
Don't know how to most easily fix this upstream due to the convoluted code, but works fine with my implementation of SRFI-64.

- Taylan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.