GNU bug report logs - #72358
29.4; oauth2.el improvements

Previous Next

Full log

Message #56 received at 72358 <at> debbugs.gnu.org (full text, mbox):

From: Xiyue Deng <manphiz <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 72358 <at> debbugs.gnu.org
Subject: Re: bug#72358: 29.4; oauth2.el improvements
Date: Fri, 02 Aug 2024 01:15:22 -0700

Xiyue Deng <manphiz <at> gmail.com> writes:

> Robert Pluim <rpluim <at> gmail.com> writes:
>
>>>>>>> On Tue, 30 Jul 2024 12:37:05 -0700, Xiyue Deng <manphiz <at> gmail.com> said:
>>     Xiyue> The fifth patch adds debug messages when doing a URL query which records
>>     Xiyue> the request URL, the request data, and the response data, and provide a
>>     Xiyue> custom variable to enable this.  This provides a way to help debugging
>>     Xiyue> the requests, and I find it handy when testing oauth2 against different
>>     Xiyue> providers.
>>     >> 
>>     >> OK (although perhaps make it a defvar rather than a defcustom, to
>>     >> avoid people accidentally enabling it).
>>     >> 
>>
>>     Xiyue> Done also in patch 5.
>>
>> I see you changed `oauth2-token-file' to a `defvar', which I donʼt
>> think you should do. I was talking about making `oauth2-debug' a
>> defvar.
>>
>> Robert
>
> Oops.  Another reminder not to write code after 2am.
>
> The fixed patch 5 is attached.

More reviews welcome!

BTW, is there any dev available to commit the changes once it's in a
good shape?

-- 
Xiyue Deng

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.