GNU bug report logs - #72359
treesit-node-at-point bug on vhdl-ts-mode after update to 0.22.6

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 72359 in the body.
You can then email your comments to 72359 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: treesit-node-at-point bug on vhdl-ts-mode after update to 0.22.6
Date: Tue, 30 Jul 2024 00:17:02 +0200

[Message part 1 (text/plain, inline)]

Hi,

After updating tree-sitter on Arch Linux from 0.22.1 to 0.22.6 there seems
to be an error with the detection of some comment nodes under
`vhdl-ts-mode`.

In the attached VHDL file, if placing the cursor at the comment of line 10,
running:
`(treesit-node-at (point) 'vhdl)` returns `#<treesit-node block_header in
329-358>`. However, the side by side view shows that the parser correctly
detects a comment (see attached screenshot). This worked well with the
previous tree-sitter version.

Thanks a lot!

Gonzalo

[Message part 2 (text/html, inline)]

[treesit-vhdl-bug.vhdl (text/x-vhdl, attachment)]

[treesit-bug.PNG (image/png, attachment)]

Message #8 received at 72359 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
Cc: 72359 <at> debbugs.gnu.org
Subject: Re: bug#72359: treesit-node-at-point bug on vhdl-ts-mode after update
 to 0.22.6
Date: Tue, 27 Aug 2024 01:22:42 -0700

> On Jul 29, 2024, at 3:17 PM, Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com> wrote:
> 
> Hi,
> 
> After updating tree-sitter on Arch Linux from 0.22.1 to 0.22.6 there seems to be an error with the detection of some comment nodes under `vhdl-ts-mode`.
> 
> In the attached VHDL file, if placing the cursor at the comment of line 10, running:
> `(treesit-node-at (point) 'vhdl)` returns `#<treesit-node block_header in 329-358>`. However, the side by side view shows that the parser correctly detects a comment (see attached screenshot). This worked well with the previous tree-sitter version.
> Thanks a lot!
> 
> Gonzalo
> 
> <treesit-vhdl-bug.vhdl><treesit-bug.PNG>

Thank you for your report, Gonzalo! And sorry for the delay. I properly looked into this today, and confirmed that this is a tree-sitter bug. I raised an issue here: https://github.com/tree-sitter/tree-sitter/issues/3555

Sadly, there’s not much we can do right now. There was another similar bug in tree-sitter, which I worked around by using another function. But now that “another function” is also broken, oh well :-(

Yuan

Message #13 received at 72359-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: gonzalomlarumbe <at> gmail.com, 72359-done <at> debbugs.gnu.org
Subject: Re: bug#72359: treesit-node-at-point bug on vhdl-ts-mode after update
 to 0.22.6
Date: Thu, 29 Aug 2024 15:07:11 +0300

> Cc: 72359 <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Tue, 27 Aug 2024 01:22:42 -0700
> 
> Thank you for your report, Gonzalo! And sorry for the delay. I properly looked into this today, and confirmed that this is a tree-sitter bug. I raised an issue here: https://github.com/tree-sitter/tree-sitter/issues/3555
> 
> Sadly, there’s not much we can do right now. There was another similar bug in tree-sitter, which I worked around by using another function. But now that “another function” is also broken, oh well :-(

Since this is not an Emacs bug, I'm closing it.

Message #16 received at 72359 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 72359 <at> debbugs.gnu.org, Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
Subject: Re: bug#72359: treesit-node-at-point bug on vhdl-ts-mode after update
 to 0.22.6
Date: Mon, 2 Sep 2024 10:59:09 -0700

> On Aug 29, 2024, at 5:07 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: 72359 <at> debbugs.gnu.org
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Tue, 27 Aug 2024 01:22:42 -0700
>> 
>> Thank you for your report, Gonzalo! And sorry for the delay. I properly looked into this today, and confirmed that this is a tree-sitter bug. I raised an issue here: https://github.com/tree-sitter/tree-sitter/issues/3555
>> 
>> Sadly, there’s not much we can do right now. There was another similar bug in tree-sitter, which I worked around by using another function. But now that “another function” is also broken, oh well :-(
> 
> Since this is not an Emacs bug, I'm closing it.

FYI tree-sitter devs have fixed the bug: https://github.com/tree-sitter/tree-sitter/issues/3555

Yuan

Message #19 received at 72359 <at> debbugs.gnu.org (full text, mbox):

From: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 72359 <at> debbugs.gnu.org
Subject: Re: bug#72359: treesit-node-at-point bug on vhdl-ts-mode after update
 to 0.22.6
Date: Fri, 13 Sep 2024 13:50:46 +0200

[Message part 1 (text/plain, inline)]

Thanks a lot! :)

El lun, 2 sept 2024 a las 19:59, Yuan Fu (<casouri <at> gmail.com>) escribió:

>
>
> > On Aug 29, 2024, at 5:07 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >> Cc: 72359 <at> debbugs.gnu.org
> >> From: Yuan Fu <casouri <at> gmail.com>
> >> Date: Tue, 27 Aug 2024 01:22:42 -0700
> >>
> >> Thank you for your report, Gonzalo! And sorry for the delay. I properly
> looked into this today, and confirmed that this is a tree-sitter bug. I
> raised an issue here:
> https://github.com/tree-sitter/tree-sitter/issues/3555
> >>
> >> Sadly, there’s not much we can do right now. There was another similar
> bug in tree-sitter, which I worked around by using another function. But
> now that “another function” is also broken, oh well :-(
> >
> > Since this is not an Emacs bug, I'm closing it.
>
> FYI tree-sitter devs have fixed the bug:
> https://github.com/tree-sitter/tree-sitter/issues/3555
>
> Yuan

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.