GNU bug report logs - #72358
29.4; oauth2.el improvements

Previous Next

Package: emacs;

Reported by: Xiyue Deng <manphiz <at> gmail.com>

Date: Tue, 30 Jul 2024 02:20:01 UTC

Severity: normal

Found in version 29.4

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


Message #29 received at 72358 <at> debbugs.gnu.org (full text, mbox):

From: Xiyue Deng <manphiz <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Björn Bidar <bjorn.bidar <at> thaodan.de>,
 72358 <at> debbugs.gnu.org
Subject: Re: bug#72358: 29.4; oauth2.el improvements
Date: Tue, 30 Jul 2024 12:44:40 -0700
Robert Pluim <rpluim <at> gmail.com> writes:

>>>>>> On Tue, 30 Jul 2024 17:08:21 +0300, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> said:
>
>     Björn> Xiyue Deng <manphiz <at> gmail.com> writes:
>     >> The fourth patch may need a bit of background: oauth2.el (optionally)
>     >> uses plstore to save authentication data for future reuse, and the
>     >> plstore id for an account is computed using a combination of `auth-url',
>     >> `token-url', and `scope'.  However, this combination of data doesn't
>     >> guarantee uniqueness for accounts for a same provider, e.g. for Gmail,
>     >> the three parameters are the same for different accounts, and hence
>     >> storing a second account information will override the first one.
>
>     Björn> Would it make sense to plug OAuth2.el into auth-source to store the
>     Björn> authentication token safely inside an existing credential storage?
>
>     Björn> Various applications already do so when using the native credential
>     Björn> storages such as Freedesktop.org or the macOS keyring.
>
> Yes. In fact thereʼs the auth-source-xoauth2 package that does
> that. And oauth2 can already store stuff using plstore, so Iʼm sure it
> can be extended to use auth-source.
>

auth-source-xoauth2 doesn't actually use auth-source
(e.g. ~/.authinfo.gpg) to store the data it needs, but use a custom file
storing an ELisp hash table to store the client-id, client-secret, etc.
It does advice the authentication code to use the calculated token.

>
> Robert

-- 
Xiyue Deng




This bug report was last modified 258 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.