GNU bug report logs - #72358
29.4; oauth2.el improvements

Previous Next

Full log

View this message in rfc822 format

From: Xiyue Deng <manphiz <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: bjorn.bidar <at> thaodan.de, Eli Zaretskii <eliz <at> gnu.org>, fitzsim <at> fitzsim.org, rpluim <at> gmail.com, 72358 <at> debbugs.gnu.org
Subject: bug#72358: 29.4; oauth2.el improvements
Date: Wed, 21 Aug 2024 15:11:36 -0700

[Message part 1 (text/plain, inline)]

Hi Philip,

Philip Kaludercic <philipk <at> posteo.net> writes:

> Xiyue Deng <manphiz <at> gmail.com> writes:
>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>>>> From: Xiyue Deng <manphiz <at> gmail.com>
>>>> Cc: Thomas Fitzsimmons <fitzsim <at> fitzsim.org>,  Björn Bidar
>>>>  <bjorn.bidar <at> thaodan.de>,  rpluim <at> gmail.com,  72358 <at> debbugs.gnu.org
>>>> Date: Wed, 14 Aug 2024 01:23:19 -0700
>>>> 
>>>> >> It's been a few days since the last time I received feedback for
>>>> >> improvements regarding my patches.  Is there any other feedbacks/reviews
>>>> >> I am expecting from the co-maintainers?  Please also let me know when
>>>> >> it's time to ask for merging and requesting a new tagged release.
>>>> >
>>>> > ?? The last message in this discussion was just yesterday evening, and
>>>> > my understanding is that you are still discussing the issues and did
>>>> > not reach the final conclusion.  If I'm mistaken, my apologies;
>>>> 
>>>> The recent communication was not related to my patches but to check
>>>> whether it is possible to support outlook.com OAuth2 login (and the
>>>> conclusion was no because refreshing access token was disabled as
>>>> confirmed by MS representative during an online chat.)
>>>> 
>>>> > please describe your conclusion and post the patch that you-all agree
>>>> > would solve the issues, and let's take it from there.
>>>> 
>>>> I actually only received comments from Robert and I have updated my
>>>> patches according in [1][2] (also attached in EOM).
>>>> 
>>>> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#20
>>>> [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#44
>>>
>>> Thanks.
>>>
>>> Philip, could you please DTRT here?  This seems to be an ELPA package.
>>
>> Friendly ping.  Please also let me know if there are more review
>> comments.
>
> I'm sorry, this was a rather long thread and I didn't have the time yet
> to follow up on it.  Can you confirm that you want me to review the
> patches attached to this message:
>
>   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#20
>
> ?

Almost with a later update for patch 5.  I am now attaching the latest
patches here to avoid any confusions.  Thanks!

-- 
Xiyue Deng

[0001-Show-full-authentication-URL-to-let-user-choose-how-.patch (text/x-diff, attachment)]

[0002-Add-parameters-required-by-Google-OAuth2-to-get-refr.patch (text/x-diff, attachment)]

[0003-Encode-parameters-when-requesting-access.patch (text/x-diff, attachment)]

[0004-Support-storing-data-for-multiple-accounts-of-the-sa.patch (text/x-diff, attachment)]

[0005-Add-debug-messages-and-provide-a-switch-variable-for.patch (text/x-diff, attachment)]

[0006-Add-NEWS-file-to-document-the-changes-to-plstore-id-.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.