GNU bug report logs - #71618
[PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71618: closed ([PATCH] guix: gnu-build-system: Add
 %gnu-build-system-default-modules.)
Date: Wed, 19 Jun 2024 01:06:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 18 Jun 2024 21:04:18 -0400
with message-id <87v825d9pp.fsf <at> gmail.com>
and subject line Re: [bug#71618] [PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.
has caused the debbugs.gnu.org bug report #71618,
regarding [PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71618: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71618
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.
Date: Mon, 17 Jun 2024 21:10:35 +0200

Since there is no exported variable containing the list of default modules,
every place that needs it (in #:modules for example) needs to copy&paste it
and pray it never changes.

This commit provides new variable exposing the default list, allowing
constructs like this:

    #:modules
    `((srfi srfi-34)
      ,@%gnu-build-system-default-modules)

* guix/build-system/gnu.scm (%gnu-build-system-default-modules): New variable.
(define-module)[#:export]: Export it.

Change-Id: I1da392019a95aea5edeac0301db26266efbeee9e
---
 guix/build-system/gnu.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index cdbb547773..53ac2f8cbd 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -28,6 +28,7 @@ (define-module (guix build-system gnu)
   #:use-module (srfi srfi-1)
   #:use-module (ice-9 match)
   #:export (%gnu-build-system-modules
+            %gnu-build-system-default-modules
             %strip-flags
             %strip-directories
             gnu-build
@@ -60,6 +61,8 @@ (define %default-modules
   '((guix build gnu-build-system)
     (guix build utils)))
 
+(define %gnu-build-system-default-modules %default-modules)
+
 (define* (package-with-explicit-inputs/deprecated p inputs
                                                   #:optional
                                                   (loc (current-source-location))
-- 
2.45.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: Tomas Volf <~@wolfsden.cz>, Ludovic Courtès <ludo <at> gnu.org>,
 71618-done <at> debbugs.gnu.org
Subject: Re: [bug#71618] [PATCH] guix: gnu-build-system: Add
 %gnu-build-system-default-modules.
Date: Tue, 18 Jun 2024 21:04:18 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> Hi Tomas,
>
> On 2024-06-17 20:10, Tomas Volf wrote:
>> Since there is no exported variable containing the list of default modules,
>> every place that needs it (in #:modules for example) needs to copy&paste it
>> and pray it never changes.
>
> I believe this has been addressed with [1].
>
> [1]: <https://issues.guix.gnu.org/66426>

Indeed, thanks for the heads-up.  That's on the core-updates branch.

Closing.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.