GNU bug report logs - #71618
[PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71618 in the body.
You can then email your comments to 71618 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH] guix: gnu-build-system: Add %gnu-build-system-default-modules.
Date: Mon, 17 Jun 2024 21:10:35 +0200

Since there is no exported variable containing the list of default modules,
every place that needs it (in #:modules for example) needs to copy&paste it
and pray it never changes.

This commit provides new variable exposing the default list, allowing
constructs like this:

    #:modules
    `((srfi srfi-34)
      ,@%gnu-build-system-default-modules)

* guix/build-system/gnu.scm (%gnu-build-system-default-modules): New variable.
(define-module)[#:export]: Export it.

Change-Id: I1da392019a95aea5edeac0301db26266efbeee9e
---
 guix/build-system/gnu.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm
index cdbb547773..53ac2f8cbd 100644
--- a/guix/build-system/gnu.scm
+++ b/guix/build-system/gnu.scm
@@ -28,6 +28,7 @@ (define-module (guix build-system gnu)
   #:use-module (srfi srfi-1)
   #:use-module (ice-9 match)
   #:export (%gnu-build-system-modules
+            %gnu-build-system-default-modules
             %strip-flags
             %strip-directories
             gnu-build
@@ -60,6 +61,8 @@ (define %default-modules
   '((guix build gnu-build-system)
     (guix build utils)))
 
+(define %gnu-build-system-default-modules %default-modules)
+
 (define* (package-with-explicit-inputs/deprecated p inputs
                                                   #:optional
                                                   (loc (current-source-location))
-- 
2.45.1

Message #8 received at 71618 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Tomas Volf <~@wolfsden.cz>
Cc: 71618 <at> debbugs.gnu.org, Ludovic Courtès <ludo <at> gnu.org>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#71618] [PATCH] guix: gnu-build-system: Add
 %gnu-build-system-default-modules.
Date: Tue, 18 Jun 2024 20:30:47 +0100

Hi Tomas,

On 2024-06-17 20:10, Tomas Volf wrote:
> Since there is no exported variable containing the list of default modules,
> every place that needs it (in #:modules for example) needs to copy&paste it
> and pray it never changes.

I believe this has been addressed with [1].

[1]: <https://issues.guix.gnu.org/66426>

-- 
Cheers,
Bruno.

Message #13 received at 71618-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: Tomas Volf <~@wolfsden.cz>, Ludovic Courtès <ludo <at> gnu.org>,
 71618-done <at> debbugs.gnu.org
Subject: Re: [bug#71618] [PATCH] guix: gnu-build-system: Add
 %gnu-build-system-default-modules.
Date: Tue, 18 Jun 2024 21:04:18 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> Hi Tomas,
>
> On 2024-06-17 20:10, Tomas Volf wrote:
>> Since there is no exported variable containing the list of default modules,
>> every place that needs it (in #:modules for example) needs to copy&paste it
>> and pray it never changes.
>
> I believe this has been addressed with [1].
>
> [1]: <https://issues.guix.gnu.org/66426>

Indeed, thanks for the heads-up.  That's on the core-updates branch.

Closing.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.