GNU bug report logs - #71563
30.0.50; {typescript,tsx}-ts-mode do not indent type parameter lists contents

Previous Next

Package: emacs;

Reported by: Arsen Arsenović <arsen <at> aarsen.me>

Date: Fri, 14 Jun 2024 21:03:02 UTC

Severity: normal

Found in version 30.0.50

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 71563-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Arsen Arsenović <arsen <at> aarsen.me>,
 71563-done <at> debbugs.gnu.org
Subject: Re: bug#71563: 30.0.50; {typescript,tsx}-ts-mode do not indent type
 parameter lists contents
Date: Sat, 15 Jun 2024 02:19:31 +0300
Hi!

On 14/06/2024 23:23, Arsen Arsenović via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> A patch that achieves the desired result (I am not sure of the
> correctness, but it does seem to do the right thing):
> 
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
> index 74ed6aa2f94..3606a139d50 100644
> --- a/lisp/progmodes/typescript-ts-mode.el
> +++ b/lisp/progmodes/typescript-ts-mode.el
> @@ -125,6 +125,7 @@ typescript-ts-mode--indent-rules
>        ((parent-is "switch_case") parent-bol typescript-ts-mode-indent-offset)
>        ((parent-is "switch_default") parent-bol typescript-ts-mode-indent-offset)
>        ((parent-is "type_arguments") parent-bol typescript-ts-mode-indent-offset)
> +     ((parent-is "type_parameters") parent-bol typescript-ts-mode-indent-offset)
>        ((parent-is ,(rx (or "variable" "lexical") "_" (or "declaration" "declarator")))
>         typescript-ts-mode--anchor-decl 1)
>        ((parent-is "arguments") parent-bol typescript-ts-mode-indent-offset)
> 
> --8<---------------cut here---------------end--------------->8---
> 
> Thank you for your continued maintenance of Emacs, and have a most
> lovely day!  🙂

Thanks for the patch, pushed to master.




This bug report was last modified 1 year and 28 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.