GNU bug report logs - #71564
[PATCH] gnu: gnuradio: Update to 3.10.10.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71564 in the body.
You can then email your comments to 71564 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: gnuradio: Update to 3.10.10.0.
Date: Fri, 14 Jun 2024 23:56:47 -0700

* gnu/packages/radio.scm (gnuradio): Update to 3.10.10.0.

Change-Id: I0249f6345455054790a1b0050a4eea51d2780630
---
 gnu/packages/radio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 56e674a8ed..daab0f4be0 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -793,7 +793,7 @@ (define-public redsea
 (define-public gnuradio
   (package
     (name "gnuradio")
-    (version "3.10.8.0")
+    (version "3.10.10.0")
     (source
      (origin
        (method git-fetch)
@@ -802,7 +802,7 @@ (define-public gnuradio
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "11p08qrbfh5dz6l5n4c2g8c2gv1qq8aiydq91ryzfzgp49r0j6p0"))))
+        (base32 "1jq94nycccpgw2cc39hgixjq7cqdw836bnz0fvmynfg3f22mcid4"))))
     (build-system cmake-build-system)
     (native-inputs
      (list doxygen

base-commit: 7770e4140cddd5dc9c9879cb2bfcbd6cd4de59a0
-- 
2.34.1

Message #8 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 71564 <at> debbugs.gnu.org
Subject: Build failures
Date: Sun, 16 Jun 2024 10:28:35 +0200

Hello Andy,

as one can see on QA:
   https://qa.guix.gnu.org/issue/71564
the upgrade of gnuradio makes the dependent gnss-sdr package fail.

There is a new update of the latter, so I think it would be worthwhile
to try the following:
- Update gnss-sdr and see whether it still builds with the current
  gnuradio; if yes, this would be an obvious first patch to apply.
- Then try to update gnuradio again, hoping the latest gnss-sdr
  will still be happy with it.
Or if the first test fails, maybe the second one with both new packages
will work.

Since there are not so many packages depending on gnuradio
("guix refresh -l gnuradio" shows 7), the effect of the updates could
already be checked locally.

Would you like to investigate this? 

Thanks,

Andreas

Message #11 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 71564 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2 0/3] *** Update of gnuradio and fixing dependency build
 failutes ***
Date: Sun, 16 Jun 2024 21:53:57 -0700

*** Update of gnuradio and dependency gnss-sdr for build failures ***

Andy Tai (3):
  gnu: gnuradio: Update to 3.10.10.0.
  gnu: Add volk-gnsssdr.
  gnu: gnss-sdr: Update to 0.0.19.

 gnu/packages/radio.scm | 49 +++++++++++++++++++++++++++++++++++++-----
 1 file changed, 44 insertions(+), 5 deletions(-)


base-commit: 612e4dd98f7d1d015e405af9d029bede3fe3c280
prerequisite-patch-id: 546c67add1eb96a99db59239f3b7cb1db463626e
-- 
2.34.1

Message #14 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 71564 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2 1/3] gnu: gnuradio: Update to 3.10.10.0.
Date: Sun, 16 Jun 2024 21:53:58 -0700

* gnu/packages/radio.scm (gnuradio): Update to 3.10.10.0.

Change-Id: I0249f6345455054790a1b0050a4eea51d2780630
---
 gnu/packages/radio.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 56e674a8ed..daab0f4be0 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -793,7 +793,7 @@ (define-public redsea
 (define-public gnuradio
   (package
     (name "gnuradio")
-    (version "3.10.8.0")
+    (version "3.10.10.0")
     (source
      (origin
        (method git-fetch)
@@ -802,7 +802,7 @@ (define-public gnuradio
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "11p08qrbfh5dz6l5n4c2g8c2gv1qq8aiydq91ryzfzgp49r0j6p0"))))
+        (base32 "1jq94nycccpgw2cc39hgixjq7cqdw836bnz0fvmynfg3f22mcid4"))))
     (build-system cmake-build-system)
     (native-inputs
      (list doxygen
-- 
2.34.1

Message #17 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 71564 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2 2/3] gnu: Add volk-gnsssdr.
Date: Sun, 16 Jun 2024 21:53:59 -0700

* gnu/packages/radio.scm (volk-gnsssdr): New variable.

Change-Id: I76b92e43d21d88c319ec5bbf0e4cb8aa16fd5e2b
---
 gnu/packages/radio.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index daab0f4be0..89e411d6d4 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -40,6 +40,7 @@ (define-module (gnu packages radio)
   #:use-module (gnu packages)
   #:use-module (gnu packages admin)
   #:use-module (gnu packages algebra)
+  #:use-module (gnu packages assembly)
   #:use-module (gnu packages astronomy)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages avahi)
@@ -3043,6 +3044,38 @@ (define-public urh
 Radios.")
     (license license:gpl3+)))
 
+(define-public volk-gnsssdr
+  (package
+    (name "volk-gnsssdr")
+    (version "0.0.19")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/gnss-sdr/gnss-sdr")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "0l1hqfqh8ffgy6nxqdk390vmnmhv66x7m8323mz2izczqc5acy1p"))))
+    (build-system cmake-build-system)
+    (native-inputs (list python python-mako))
+    (inputs
+        (list cpu-features))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'chdir
+            (lambda _ (chdir "src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr"))))))
+    (home-page "https://github.com/gnss-sdr/gnss-sdr/blob/main/src/algorithms/libs/volk_gnsssdr_module/volk_gnsssdr/")
+    (synopsis "Sub-project of GNSS-SDR, provideing a set of extra kernels used stand-alone or in combination with VOLK's")
+    (description
+     "This library contains kernels of hand-written SIMD code for different
+mathematical operations, mainly with 8-bit and 16-bit real and complex data
+types, offering a platform/architecture agnostic version that will run in all
+machines, plus other versions for different SIMD instruction sets.")
+    (license license:gpl3+)))
+
 (define-public gnss-sdr
   (package
     (name "gnss-sdr")
-- 
2.34.1

Message #20 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 71564 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2 3/3] gnu: gnss-sdr: Update to 0.0.19.
Date: Sun, 16 Jun 2024 21:54:00 -0700

* gnu/packages/radio.scm (gnss-sdr): Update to 0.0.19.
  [inputs]: Add cpu-features, gnuplot, gnutls and volk-gnsssdr.
  [arguments](configure-flags): Disable test building because many tests
  depend on downloaded sample data set.

Change-Id: I1b231896a5e481099c96667ef667c6d9e73683da
---
 gnu/packages/radio.scm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 89e411d6d4..5a7222cf14 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -3079,7 +3079,7 @@ (define-public volk-gnsssdr
 (define-public gnss-sdr
   (package
     (name "gnss-sdr")
-    (version "0.0.17")
+    (version "0.0.19")
     (source
      (origin
        (method git-fetch)
@@ -3088,7 +3088,7 @@ (define-public gnss-sdr
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0kxn98vmrsd2a157cf3hsmivi6p4k4a3907j5w8hmcs0nn92786i"))))
+        (base32 "0l1hqfqh8ffgy6nxqdk390vmnmhv66x7m8323mz2izczqc5acy1p"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("googletest-source" ,(package-source googletest))
@@ -3099,11 +3099,14 @@ (define-public gnss-sdr
     (inputs
      (list armadillo
            boost
+           cpu-features
            fmt
            gflags
            glog
            gmp
            gnuradio
+           gnuplot
+           gnutls
            gr-osmosdr
            libpcap
            log4cpp
@@ -3113,11 +3116,14 @@ (define-public gnss-sdr
            protobuf
            pugixml
            spdlog
-           volk))
+           volk
+           volk-gnsssdr))
     (arguments
      `(#:configure-flags
        (list "-DENABLE_GENERIC_ARCH=ON"
              "-DENABLE_OSMOSDR=ON"
+
+             "-DENABLE_UNIT_TESTING=FALSE" ; many tests needing data download
              "-DBLA_VENDOR=OpenBLAS"
              (string-append "-DGFLAGS_ROOT="
                             (assoc-ref %build-inputs "gflags"))
-- 
2.34.1

Message #23 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Andy Tai <atai <at> atai.org>
Cc: 71564 <at> debbugs.gnu.org
Subject: Re: [bug#71564] [PATCH v2 2/3] gnu: Add volk-gnsssdr.
Date: Wed, 26 Jun 2024 09:44:38 +0000

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> skribis:

> * gnu/packages/radio.scm (volk-gnsssdr): New variable.
>
> [...]
>  
> +(define-public volk-gnsssdr
> [...]
> +    (inputs
> +        (list cpu-features))
> [...]

Hi.
It looks like the "cpu-features" package referenced as input here is
not in Guix. Did you forget to send it in this patch series? Or is it
somewhere else in another issue?

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 71564 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Guillaume Le Vaillant <glv <at> posteo.net>
Cc: 71564 <at> debbugs.gnu.org
Subject: Re: [bug#71564] [PATCH v2 2/3] gnu: Add volk-gnsssdr.
Date: Wed, 26 Jun 2024 06:31:10 -0700

cpu-features at https://issues.guix.gnu.org/71597

On Wed, Jun 26, 2024 at 2:44 AM Guillaume Le Vaillant <glv <at> posteo.net> wrote:
>
> Andy Tai <atai <at> atai.org> skribis:
>
> > * gnu/packages/radio.scm (volk-gnsssdr): New variable.
> >
> > [...]
> >
> > +(define-public volk-gnsssdr
> > [...]
> > +    (inputs
> > +        (list cpu-features))
> > [...]
>
> Hi.
> It looks like the "cpu-features" package referenced as input here is
> not in Guix. Did you forget to send it in this patch series? Or is it
> somewhere else in another issue?

Message #31 received at 71564-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Andy Tai <atai <at> atai.org>
Cc: 71564-done <at> debbugs.gnu.org
Subject: Re: [bug#71564] [PATCH v2 0/3] *** Update of gnuradio and fixing
 dependency build failutes ***
Date: Wed, 26 Jun 2024 14:35:40 +0000

[Message part 1 (text/plain, inline)]

Patches applied as cd9b667ba04a2acb24c5fdbe9b533d879288382d and
following.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.