GNU bug report logs - #71486
no-dereference test fails on FreeBSD, NetBSD

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#71486: closed (no-dereference test fails on FreeBSD, NetBSD)
Date: Wed, 12 Jun 2024 00:52:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 11 Jun 2024 17:51:41 -0700
with message-id <7d83afed-6d57-4a08-b853-5248a2d5573d <at> cs.ucla.edu>
and subject line Re: [bug-diffutils] bug#71486: no-dereference test fails on FreeBSD,  NetBSD
has caused the debbugs.gnu.org bug report #71486,
regarding no-dereference test fails on FreeBSD, NetBSD
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
71486: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71486
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Bruno Haible <bruno <at> clisp.org>
To: bug-diffutils <at> gnu.org
Subject: no-dereference test fails on FreeBSD, NetBSD
Date: Tue, 11 Jun 2024 22:20:42 +0200

On FreeBSD 14.0 and NetBSD 10.0, the unit test 'no-dereference' fails.

How to reproduce:

Use current diffutils git master.

$ ln -s loop loop
$ mkdir subdir
$ ln -s loop subdir/loop

# This part succeeds on all platforms:
$ src/diff --no-dereference loop subdir/loop
$ echo $?
0

# This commands succeeds on all platforms except FreeBSD and NetBSD
# but fails on FreeBSD and NetBSD.
$ src/diff --no-dereference loop subdir
diff: subdir/loop: Too many links

The manual [1] says:
  "If one file is a directory and the other is not, diff compares the file
   in the directory whose name is that of the non-directory."
But single-stepping through the code, I don't get through code that
references 'subdir/loop'. It merely references 'subdir'.

The stack trace is:
  diff.c:880
    -> diff.c:1608
         -> error

Bruno

[1] https://www.gnu.org/software/diffutils/manual/html_node/Invoking-diff.html

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Bruno Haible <bruno <at> clisp.org>
Cc: 71486-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#71486: no-dereference test fails on FreeBSD, 
 NetBSD
Date: Tue, 11 Jun 2024 17:51:41 -0700

[Message part 4 (text/plain, inline)]

Thanks for reporting that. I installed the attached patch which I hopes 
fixes it, and am boldly closing the bug report.

[0001-diff-port-to-FreeBSD-NetBSD.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.