GNU bug report logs - #71486
no-dereference test fails on FreeBSD, NetBSD

Previous Next

Package: diffutils;

Reported by: Bruno Haible <bruno <at> clisp.org>

Date: Tue, 11 Jun 2024 20:33:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71486 in the body.
You can then email your comments to 71486 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-diffutils <at> gnu.org:
bug#71486; Package diffutils. (Tue, 11 Jun 2024 20:33:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Bruno Haible <bruno <at> clisp.org>:
New bug report received and forwarded. Copy sent to bug-diffutils <at> gnu.org. (Tue, 11 Jun 2024 20:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: bug-diffutils <at> gnu.org
Subject: no-dereference test fails on FreeBSD, NetBSD
Date: Tue, 11 Jun 2024 22:20:42 +0200

On FreeBSD 14.0 and NetBSD 10.0, the unit test 'no-dereference' fails.

How to reproduce:

Use current diffutils git master.

$ ln -s loop loop
$ mkdir subdir
$ ln -s loop subdir/loop

# This part succeeds on all platforms:
$ src/diff --no-dereference loop subdir/loop
$ echo $?
0

# This commands succeeds on all platforms except FreeBSD and NetBSD
# but fails on FreeBSD and NetBSD.
$ src/diff --no-dereference loop subdir
diff: subdir/loop: Too many links

The manual [1] says:
  "If one file is a directory and the other is not, diff compares the file
   in the directory whose name is that of the non-directory."
But single-stepping through the code, I don't get through code that
references 'subdir/loop'. It merely references 'subdir'.

The stack trace is:
  diff.c:880
    -> diff.c:1608
         -> error

Bruno

[1] https://www.gnu.org/software/diffutils/manual/html_node/Invoking-diff.html
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Wed, 12 Jun 2024 00:52:03 GMT) Full text and rfc822 format available.
Notification sent to Bruno Haible <bruno <at> clisp.org>:
bug acknowledged by developer. (Wed, 12 Jun 2024 00:52:03 GMT) Full text and rfc822 format available.

Message #10 received at 71486-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Bruno Haible <bruno <at> clisp.org>
Cc: 71486-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#71486: no-dereference test fails on FreeBSD, 
 NetBSD
Date: Tue, 11 Jun 2024 17:51:41 -0700

[Message part 1 (text/plain, inline)]
Thanks for reporting that. I installed the attached patch which I hopes 
fixes it, and am boldly closing the bug report.
[0001-diff-port-to-FreeBSD-NetBSD.patch (text/x-patch, attachment)]
Information forwarded to bug-diffutils <at> gnu.org:
bug#71486; Package diffutils. (Wed, 12 Jun 2024 01:49:01 GMT) Full text and rfc822 format available.

Message #13 received at 71486-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 71486-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#71486: no-dereference test fails on FreeBSD,
 NetBSD
Date: Wed, 12 Jun 2024 03:48:01 +0200

Paul Eggert wrote:
> patch which I hopes fixes it, and am boldly closing the bug report.

Yes, I confirm that all tests pass now on FreeBSD and NetBSD.

Bruno
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Jul 2024 11:24:23 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 71 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.