GNU bug report logs - #7142
coreutils on Solaris 10(x86) 09/10

Previous Next

Full log

View this message in rfc822 format

From: Eric Blake <eblake <at> redhat.com>
To: bug-gnulib <at> gnu.org
Cc: c.brogi <at> mid.de, 7142 <at> debbugs.gnu.org
Subject: bug#7142: [PATCH] faccessat: remove unused wrappers
Date: Tue,  5 Oct 2010 08:08:31 -0600

* lib/openat.h (accessat, euidaccesat): Delete, since the mere
presence of these wrappers dragged in -lgen on Solaris.
Reported by Clemens Brogi; fix suggested by Paul Eggert.

Signed-off-by: Eric Blake <eblake <at> redhat.com>
---

I'm pushing this.

 ChangeLog    |    7 +++++++
 lib/openat.h |   18 +++---------------
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index edc7c8b..87559f4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2010-10-05  Eric Blake  <eblake <at> redhat.com>
+
+	faccessat: remove unused wrappers
+	* lib/openat.h (accessat, euidaccesat): Delete, since the mere
+	presence of these wrappers dragged in -lgen on Solaris.
+	Reported by Clemens Brogi; fix suggested by Paul Eggert.
+
 2010-10-05  Jim Meyering  <meyering <at> redhat.com>

 	tests: require @PRAGMA_COLUMNS@ with each @PRAGMA_SYSTEM_HEADER@
diff --git a/lib/openat.h b/lib/openat.h
index 11a0314..1d4432e 100644
--- a/lib/openat.h
+++ b/lib/openat.h
@@ -93,22 +93,10 @@ lstatat (int fd, char const *name, struct stat *st)
   return fstatat (fd, name, st, AT_SYMLINK_NOFOLLOW);
 }

-#if GNULIB_FACCESSAT
 /* For now, there are no wrappers named laccessat or leuidaccessat,
    since gnulib doesn't support faccessat(,AT_SYMLINK_NOFOLLOW) and
-   since access rights on symlinks are of limited utility.  */
-
-static inline int
-accessat (int fd, char const *file, int mode)
-{
-  return faccessat (fd, file, mode, 0);
-}
-
-static inline int
-euidaccessat (int fd, char const *file, int mode)
-{
-  return faccessat (fd, file, mode, AT_EACCESS);
-}
-#endif
+   since access rights on symlinks are of limited utility.  Likewise,
+   wrappers are not provided for accessat or euidaccessat, so as to
+   avoid dragging in -lgen on some platforms.  */

 #endif /* _GL_HEADER_OPENAT */
-- 
1.7.2.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.