GNU bug report logs - #71313
[PATCH] Allow insert other elisp keywords in auto-insert

Previous Next

Full log

View this message in rfc822 format

From: Eshel Yaron <me <at> eshelyaron.com>
To: "Elijah G." <eg642616 <at> gmail.com>
Cc: 71313 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#71313: [PATCH] Allow insert other elisp keywords in auto-insert
Date: Wed, 05 Jun 2024 07:24:04 +0200

Hi Elijah,

"Elijah G." <eg642616 <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: "Elijah G." <eg642616 <at> gmail.com>
>>> Cc: 71313 <at> debbugs.gnu.org
>>> Date: Sun, 02 Jun 2024 21:14:34 -0600
>>>
>>> >> From: "Elijah G." <eg642616 <at> gmail.com>
>>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600
>>> >>
>>> >> this little patch allow insert any package keywords when using
>>> >> auto-insert for insert elisp header lines.
>>> >>
>>> >> This is more a bugfix, since there is a bug when using Vertico that get
>>> >> stuck in the keywords part, that bug can also apply to other completion
>>> >> UIs or frameworks.
>>> >>
>>> >> Also there are some packages that uses non-standard keywords, i think it
>>> >> would be better allowing insert other keywords.
>>> >
>>> > I'm not sure why it makes sense to allow keywords that are not in
>>> > finder-known-keywords.  Such a keyword will never be used by any
>>> > finder commands.
>>>
>>> You are right, I think I've found a better way for this bugfix.
>>> Please see the new patch attached below, thanks.
>>
>> Thanks, but how will an empty string "fix bugs from 3rd-party
>> completion UI"?  What am I missing here?
>
> When using Completions UI such as Vertico or Helm, there is no way to
> exit from Keyword Section to go to next auto-insert Sections unless the
> user press a key sequense, for auto-insert input a empty string allow
> close Keyword section without cancelling the next auto-insert actions.

FWIW, I'm not sure I understand the problem: I just tried using Vertico
to fill in a new .el file with auto-insert, and ISTM that in the
Keywords step both C-M-m and C-M-c already work as expected and let you
continue to the next step.


Best,

Eshel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.