GNU bug report logs - #71313
[PATCH] Allow insert other elisp keywords in auto-insert

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71313 in the body.
You can then email your comments to 71313 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Elijah G." <eg642616 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow insert other elisp keywords in auto-insert
Date: Sat, 01 Jun 2024 18:17:42 -0600

[Message part 1 (text/plain, inline)]

Tags: patch

Hello,

this little patch allow insert any package keywords when using
auto-insert for insert elisp header lines.

This is more a bugfix, since there is a bug when using Vertico that get
stuck in the keywords part, that bug can also apply to other completion
UIs or frameworks.

Also there are some packages that uses non-standard keywords, i think it
would be better allowing insert other keywords.



In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2024-05-23 built
 on AVALON
Repository revision: 64cced2c37a9926fe6ff1c6ad9b9540abd47e21c
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.19045
System Description: Microsoft Windows 10 Pro (v10.0.2009.19045.4046)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation --without-compress-install --with-tree-sitter CFLAGS=-O2'

[0001-Allow-insert-other-elisp-keywords-in-auto-insert.patch (text/patch, attachment)]

Message #8 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Elijah G." <eg642616 <at> gmail.com>
Cc: 71313 <at> debbugs.gnu.org
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Sun, 02 Jun 2024 08:44:05 +0300

> From: "Elijah G." <eg642616 <at> gmail.com>
> Date: Sat, 01 Jun 2024 18:17:42 -0600
> 
> this little patch allow insert any package keywords when using
> auto-insert for insert elisp header lines.
> 
> This is more a bugfix, since there is a bug when using Vertico that get
> stuck in the keywords part, that bug can also apply to other completion
> UIs or frameworks.
> 
> Also there are some packages that uses non-standard keywords, i think it
> would be better allowing insert other keywords.

I'm not sure why it makes sense to allow keywords that are not in
finder-known-keywords.  Such a keyword will never be used by any
finder commands.

Message #11 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: "Elijah G." <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71313 <at> debbugs.gnu.org
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Sun, 02 Jun 2024 21:14:34 -0600

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Elijah G." <eg642616 <at> gmail.com>
>> Date: Sat, 01 Jun 2024 18:17:42 -0600
>> 
>> this little patch allow insert any package keywords when using
>> auto-insert for insert elisp header lines.
>> 
>> This is more a bugfix, since there is a bug when using Vertico that get
>> stuck in the keywords part, that bug can also apply to other completion
>> UIs or frameworks.
>> 
>> Also there are some packages that uses non-standard keywords, i think it
>> would be better allowing insert other keywords.
>
> I'm not sure why it makes sense to allow keywords that are not in
> finder-known-keywords.  Such a keyword will never be used by any
> finder commands.

You are right, I think I've found a better way for this bugfix.
Please see the new patch attached below, thanks.

[0001-lisp-autoinsert.el-auto-insert-alist-Allow-empty-inp.patch (text/x-patch, attachment)]

Message #14 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Elijah G." <eg642616 <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 71313 <at> debbugs.gnu.org
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Mon, 03 Jun 2024 14:40:23 +0300

> From: "Elijah G." <eg642616 <at> gmail.com>
> Cc: 71313 <at> debbugs.gnu.org
> Date: Sun, 02 Jun 2024 21:14:34 -0600
> 
> >> From: "Elijah G." <eg642616 <at> gmail.com>
> >> Date: Sat, 01 Jun 2024 18:17:42 -0600
> >> 
> >> this little patch allow insert any package keywords when using
> >> auto-insert for insert elisp header lines.
> >> 
> >> This is more a bugfix, since there is a bug when using Vertico that get
> >> stuck in the keywords part, that bug can also apply to other completion
> >> UIs or frameworks.
> >> 
> >> Also there are some packages that uses non-standard keywords, i think it
> >> would be better allowing insert other keywords.
> >
> > I'm not sure why it makes sense to allow keywords that are not in
> > finder-known-keywords.  Such a keyword will never be used by any
> > finder commands.
> 
> You are right, I think I've found a better way for this bugfix.
> Please see the new patch attached below, thanks.

Thanks, but how will an empty string "fix bugs from 3rd-party
completion UI"?  What am I missing here?

Message #17 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: "Elijah G." <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71313 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Tue, 04 Jun 2024 18:54:19 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: "Elijah G." <eg642616 <at> gmail.com>
>> Cc: 71313 <at> debbugs.gnu.org
>> Date: Sun, 02 Jun 2024 21:14:34 -0600
>>
>> >> From: "Elijah G." <eg642616 <at> gmail.com>
>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600
>> >>
>> >> this little patch allow insert any package keywords when using
>> >> auto-insert for insert elisp header lines.
>> >>
>> >> This is more a bugfix, since there is a bug when using Vertico that get
>> >> stuck in the keywords part, that bug can also apply to other completion
>> >> UIs or frameworks.
>> >>
>> >> Also there are some packages that uses non-standard keywords, i think it
>> >> would be better allowing insert other keywords.
>> >
>> > I'm not sure why it makes sense to allow keywords that are not in
>> > finder-known-keywords.  Such a keyword will never be used by any
>> > finder commands.
>>
>> You are right, I think I've found a better way for this bugfix.
>> Please see the new patch attached below, thanks.
>
> Thanks, but how will an empty string "fix bugs from 3rd-party
> completion UI"?  What am I missing here?

When using Completions UI such as Vertico or Helm, there is no way to
exit from Keyword Section to go to next auto-insert Sections unless the
user press a key sequense, for auto-insert input a empty string allow
close Keyword section without cancelling the next auto-insert actions.

This can be more a problem with `completing-read' than Completions UI,
that is why setting an empty string as default value fix this and can
fix this similar issue to other completions packages.

Message #20 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: "Elijah G." <eg642616 <at> gmail.com>
Cc: 71313 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Wed, 05 Jun 2024 07:24:04 +0200

Hi Elijah,

"Elijah G." <eg642616 <at> gmail.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: "Elijah G." <eg642616 <at> gmail.com>
>>> Cc: 71313 <at> debbugs.gnu.org
>>> Date: Sun, 02 Jun 2024 21:14:34 -0600
>>>
>>> >> From: "Elijah G." <eg642616 <at> gmail.com>
>>> >> Date: Sat, 01 Jun 2024 18:17:42 -0600
>>> >>
>>> >> this little patch allow insert any package keywords when using
>>> >> auto-insert for insert elisp header lines.
>>> >>
>>> >> This is more a bugfix, since there is a bug when using Vertico that get
>>> >> stuck in the keywords part, that bug can also apply to other completion
>>> >> UIs or frameworks.
>>> >>
>>> >> Also there are some packages that uses non-standard keywords, i think it
>>> >> would be better allowing insert other keywords.
>>> >
>>> > I'm not sure why it makes sense to allow keywords that are not in
>>> > finder-known-keywords.  Such a keyword will never be used by any
>>> > finder commands.
>>>
>>> You are right, I think I've found a better way for this bugfix.
>>> Please see the new patch attached below, thanks.
>>
>> Thanks, but how will an empty string "fix bugs from 3rd-party
>> completion UI"?  What am I missing here?
>
> When using Completions UI such as Vertico or Helm, there is no way to
> exit from Keyword Section to go to next auto-insert Sections unless the
> user press a key sequense, for auto-insert input a empty string allow
> close Keyword section without cancelling the next auto-insert actions.

FWIW, I'm not sure I understand the problem: I just tried using Vertico
to fill in a new .el file with auto-insert, and ISTM that in the
Keywords step both C-M-m and C-M-c already work as expected and let you
continue to the next step.


Best,

Eshel

Message #23 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Elijah G." <eg642616 <at> gmail.com>
Cc: 71313 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Wed, 05 Jun 2024 14:32:54 +0300

> From: "Elijah G." <eg642616 <at> gmail.com>
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,  71313 <at> debbugs.gnu.org
> Date: Tue, 04 Jun 2024 18:54:19 -0600
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but how will an empty string "fix bugs from 3rd-party
> > completion UI"?  What am I missing here?
> 
> When using Completions UI such as Vertico or Helm, there is no way to
> exit from Keyword Section to go to next auto-insert Sections unless the
> user press a key sequense, for auto-insert input a empty string allow
> close Keyword section without cancelling the next auto-insert actions.

But why would the user want to exit the Keyword Section without
inputting keywords?  And why are Vertico and Helm special in this
regard?

Message #26 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Elijah G <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71313 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Thu, 6 Jun 2024 23:10:54 -0600

[Message part 1 (text/plain, inline)]

El mié., 5 de junio de 2024 5:32 a. m., Eli Zaretskii <eliz <at> gnu.org>
escribió:

> > From: "Elijah G." <eg642616 <at> gmail.com>
> > Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,  71313 <at> debbugs.gnu.org
> > Date: Tue, 04 Jun 2024 18:54:19 -0600
> >
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> > > Thanks, but how will an empty string "fix bugs from 3rd-party
> > > completion UI"?  What am I missing here?
> >
> > When using Completions UI such as Vertico or Helm, there is no way to
> > exit from Keyword Section to go to next auto-insert Sections unless the
> > user press a key sequense, for auto-insert input a empty string allow
> > close Keyword section without cancelling the next auto-insert actions.
>
> But why would the user want to exit the Keyword Section without
> inputting keywords?  And why are Vertico and Helm special in this
> regard?
>

I didn't mean to exit without input any keyword, after inserting the
keyword it will ask again for add more keywords, the problem is that It's
an infinite loop that it's not possible exit without pressing any
keybinding for insert an empty string (e.g. M-RET in Vertico), AFAIK
Vertico (and helm according to some commentaries) have this problem because
they use strictly the completing-read completion table for their candidates
when require-match is non-nil, the patch can be applied since it is just a
little change without any side-effect.

I think i will need to change the commit message for the patch, because it
can misunderstand.

>

[Message part 2 (text/html, inline)]

Message #29 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thievol <at> posteo.net>
To: Elijah G <eg642616 <at> gmail.com>
Cc: 71313 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Fri, 07 Jun 2024 05:48:20 +0000

Elijah G <eg642616 <at> gmail.com> writes:

> El mié., 5 de junio de 2024 5:32 a. m., Eli Zaretskii <eliz <at> gnu.org>
> escribió:
>
>     > From: "Elijah G." <eg642616 <at> gmail.com>
>     > Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 
> 71313 <at> debbugs.gnu.org
>     > Date: Tue, 04 Jun 2024 18:54:19 -0600
>     >
>     > Eli Zaretskii <eliz <at> gnu.org> writes:
>     >
>     > > Thanks, but how will an empty string "fix bugs from 3rd-party
>     > > completion UI"?  What am I missing here?
>     >
>     > When using Completions UI such as Vertico or Helm, there is no
> way to
>     > exit from Keyword Section to go to next auto-insert Sections
> unless the
>     > user press a key sequense, for auto-insert input a empty string
> allow
>     > close Keyword section without cancelling the next auto-insert
> actions.
>    
>     But why would the user want to exit the Keyword Section without
>     inputting keywords?  And why are Vertico and Helm special in this
>     regard?
>
> I didn't mean to exit without input any keyword, after inserting the
> keyword it will ask again for add more keywords, the problem is that
> It's an infinite loop that it's not possible exit
> without pressing any keybinding for insert an empty string (e.g. M-RET
> in Vertico), AFAIK Vertico (and helm according to some commentaries)
> have this problem because they use strictly the
> completing-read completion table for their candidates when
> require-match is non-nil, the patch can be applied since it is just a
> little change without any side-effect.

You can exit the minibuffer with empty string in Helm with C-RET.

-- 
Thierry

Message #32 received at 71313 <at> debbugs.gnu.org (full text, mbox):

From: Elijah G <eg642616 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71313 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Fri, 7 Jun 2024 22:32:47 -0600

[Message part 1 (text/plain, inline)]

I think this can be closed since this is more a problem with Vertico (and
probably Helm) as far as i could see.

[Message part 2 (text/html, inline)]

Message #37 received at 71313-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Elijah G <eg642616 <at> gmail.com>
Cc: 71313-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#71313: [PATCH] Allow insert other elisp keywords in
 auto-insert
Date: Sat, 08 Jun 2024 16:26:44 +0300

> From: Elijah G <eg642616 <at> gmail.com>
> Date: Fri, 7 Jun 2024 22:32:47 -0600
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 71313 <at> debbugs.gnu.org
> 
> I think this can be closed since this is more a problem with Vertico (and probably Helm) as far as i could see.

Thanks, done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.