GNU bug report logs - #71209
[PATCH] Add font-locking for variables in go-ts-mode range clauses

Previous Next

Full log

Message #29 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Randy Taylor <dev <at> rjt.dev>, Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 04:56:35 +0300

On 01/06/2024 04:09, Randy Taylor wrote:
> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart <at> gmail.com> wrote:
>>> it seems we already highlight this when at treesit-font-lock-level 4?
>> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
>> they be getting `font-lock-variable-name-face` in the 'definition feature?
>>
> 
> Indeed, thanks. Could someone please install the patch? Thanks in advance.

Now pushed to master. Thanks Noah!

> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.

I would probably rather call those "missing features" rather than 
issues. I've added such highlightings to some of the constructs for 
several treesit modes last year, but more can be missing, so 
contributions welcome.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.