GNU bug report logs - #71209
[PATCH] Add font-locking for variables in go-ts-mode range clauses

Previous Next

To reply to this bug, email your comments to 71209 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add font-locking for variables in go-ts-mode range clauses
Date: Sun, 26 May 2024 05:41:37 -0700

[Message part 1 (text/plain, inline)]

Tags: patch

Adds font-locking rule in go-ts-mode to give variables in range clauses
font-lock-variable-name-face (in feature 'definition).

For example, the following font-locking is added:

for idx, val := range arr {}
//     ^ font-lock-variable-name-face
//           ^ font-lock-variable-name-face

The patch also adds a test case.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[0001-Add-font-locking-for-variables-in-go-ts-mode-range-c.patch (text/x-patch, attachment)]

Message #8 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Tue, 28 May 2024 02:46:00 +0000

On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart <at> gmail.com> wrote:

> Tags: patch
> 
> Adds font-locking rule in go-ts-mode to give variables in range clauses
> font-lock-variable-name-face (in feature 'definition).
> 
> For example, the following font-locking is added:
> 
> for idx, val := range arr {}
> // ^ font-lock-variable-name-face
> // ^ font-lock-variable-name-face
> 
> The patch also adds a test case.
> 
> 
> In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
> System Description: Ubuntu 22.04.4 LTS
> 
> Configured using:
> 'configure --prefix=/usr/local --with-modules --with-tree-sitter
> --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
> --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
> CXX=gcc-12'

Thanks, but it seems we already highlight this when at treesit-font-lock-level 4?

Message #11 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Thu, 30 May 2024 06:25:56 -0700

[Message part 1 (text/plain, inline)]

> it seems we already highlight this when at treesit-font-lock-level 4?

They get highlighted with `font-lock-variable-use-face` at level 4, but
shouldn't
they be getting `font-lock-variable-name-face` in the 'definition feature?

On Mon, May 27, 2024 at 7:46 PM Randy Taylor <dev <at> rjt.dev> wrote:

> On Sunday, May 26th, 2024 at 08:41, Noah Peart <noah.v.peart <at> gmail.com>
> wrote:
>
> > Tags: patch
> >
> > Adds font-locking rule in go-ts-mode to give variables in range clauses
> > font-lock-variable-name-face (in feature 'definition).
> >
> > For example, the following font-locking is added:
> >
> > for idx, val := range arr {}
> > // ^ font-lock-variable-name-face
> > // ^ font-lock-variable-name-face
> >
> > The patch also adds a test case.
> >
> >
> > In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
> > 3.24.33, cairo version 1.16.0) of 2024-05-21 built on noah-X580VD
> > Repository revision: 63d914e377f7cc37056de2503bfbeea831875037
> > Repository branch: master
> > Windowing system distributor 'The X.Org Foundation', version
> 11.0.12101004
> > System Description: Ubuntu 22.04.4 LTS
> >
> > Configured using:
> > 'configure --prefix=/usr/local --with-modules --with-tree-sitter
> > --with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
> > --with-json --with-mailutils --with-jpeg --with-png --with-rsvg
> > --with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
> > CXX=gcc-12'
>
> Thanks, but it seems we already highlight this when at
> treesit-font-lock-level 4?
>

[Message part 2 (text/html, inline)]

Message #14 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Fri, 31 May 2024 02:23:24 +0300

On 30/05/2024 16:25, Noah Peart wrote:
>  > it seems we already highlight this when at treesit-font-lock-level 4?
> 
> They get highlighted with `font-lock-variable-use-face` at level 4, but 
> shouldn't
> they be getting `font-lock-variable-name-face` in the 'definition feature?

I think that's a good idea: the local variables idx and val are 
introduced on that line, so we could indeed call those occurrences 
"definitions".

Message #17 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 01 Jun 2024 01:09:34 +0000

On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart <at> gmail.com> wrote:
> > it seems we already highlight this when at treesit-font-lock-level 4?
> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
> they be getting `font-lock-variable-name-face` in the 'definition feature?
> 

Indeed, thanks. Could someone please install the patch? Thanks in advance.

Seems like c++-ts-mode will need to get updated too, as with:
for (const auto& i : things) {}
i gets font-lock-variable-use-face. I wonder if any other ts modes
have similar issues.

Message #20 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Fri, 31 May 2024 18:42:07 -0700

[Message part 1 (text/plain, inline)]

> c++-ts-mode will need to get updated too

I've been using these for c++, I think they are still missing

    ;; for (auto x: ...)
    (for_range_loop
     declarator: (identifier) @font-lock-variable-name-face)
    ;; auto& x
    (reference_declarator
     (identifier) @font-lock-variable-name-face)
    ;; auto[&] [x, y]
    (structured_binding_declarator
     _ [(identifier)] @font-lock-variable-name-face)

I suppose most people keep the default font-locking for variable-name
and variable-use, so these missing rules go unnoticed.

On Fri, May 31, 2024 at 6:09 PM Randy Taylor <dev <at> rjt.dev> wrote:

> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart <at> gmail.com>
> wrote:
> > > it seems we already highlight this when at treesit-font-lock-level 4?
> > They get highlighted with `font-lock-variable-use-face` at level 4, but
> shouldn't
> > they be getting `font-lock-variable-name-face` in the 'definition
> feature?
> >
>
> Indeed, thanks. Could someone please install the patch? Thanks in advance.
>
> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.
>

[Message part 2 (text/html, inline)]

Message #23 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 04:51:08 +0300

On 01/06/2024 04:42, Noah Peart wrote:
> I suppose most people keep the default font-locking for variable-name
> and variable-use, so these missing rules go unnoticed.

Only if you set treesit-font-lock-level to 4, right?

Message #26 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org, Dmitry Gutov <dmitry <at> gutov.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Fri, 31 May 2024 18:50:52 -0700

[Message part 1 (text/plain, inline)]

There is a similar issue with font-lock-property-name-face
and font-lock-property-use-face.  I've noticed different modes
treat things differently.  I think object fields in literals should get
property-name-face, but json-ts-mode, for example,
doesn't use font-lock-property-name-face at all.

On Fri, May 31, 2024 at 6:42 PM Noah Peart <noah.v.peart <at> gmail.com> wrote:

> > c++-ts-mode will need to get updated too
>
> I've been using these for c++, I think they are still missing
>
>     ;; for (auto x: ...)
>     (for_range_loop
>      declarator: (identifier) @font-lock-variable-name-face)
>     ;; auto& x
>     (reference_declarator
>      (identifier) @font-lock-variable-name-face)
>     ;; auto[&] [x, y]
>     (structured_binding_declarator
>      _ [(identifier)] @font-lock-variable-name-face)
>
> I suppose most people keep the default font-locking for variable-name
> and variable-use, so these missing rules go unnoticed.
>
> On Fri, May 31, 2024 at 6:09 PM Randy Taylor <dev <at> rjt.dev> wrote:
>
>> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart <at> gmail.com>
>> wrote:
>> > > it seems we already highlight this when at treesit-font-lock-level 4?
>> > They get highlighted with `font-lock-variable-use-face` at level 4, but
>> shouldn't
>> > they be getting `font-lock-variable-name-face` in the 'definition
>> feature?
>> >
>>
>> Indeed, thanks. Could someone please install the patch? Thanks in advance.
>>
>> Seems like c++-ts-mode will need to get updated too, as with:
>> for (const auto& i : things) {}
>> i gets font-lock-variable-use-face. I wonder if any other ts modes
>> have similar issues.
>>
>

[Message part 2 (text/html, inline)]

Message #29 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Randy Taylor <dev <at> rjt.dev>, Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 04:56:35 +0300

On 01/06/2024 04:09, Randy Taylor wrote:
> On Thursday, May 30th, 2024 at 09:25, Noah Peart <noah.v.peart <at> gmail.com> wrote:
>>> it seems we already highlight this when at treesit-font-lock-level 4?
>> They get highlighted with `font-lock-variable-use-face` at level 4, but shouldn't
>> they be getting `font-lock-variable-name-face` in the 'definition feature?
>>
> 
> Indeed, thanks. Could someone please install the patch? Thanks in advance.

Now pushed to master. Thanks Noah!

> Seems like c++-ts-mode will need to get updated too, as with:
> for (const auto& i : things) {}
> i gets font-lock-variable-use-face. I wonder if any other ts modes
> have similar issues.

I would probably rather call those "missing features" rather than 
issues. I've added such highlightings to some of the constructs for 
several treesit modes last year, but more can be missing, so 
contributions welcome.

Message #32 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev <at> rjt.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Fri, 31 May 2024 18:56:00 -0700

[Message part 1 (text/plain, inline)]

> Only if you set treesit-font-lock-level to 4, right?

Yea, that's true - I assumed most people(?) do, but I just realized
I hadn't been doing that for years until tree-sitter - and now I've
become obsessive compulsive about my fonts.

On Fri, May 31, 2024 at 6:51 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:

> On 01/06/2024 04:42, Noah Peart wrote:
> > I suppose most people keep the default font-locking for variable-name
> > and variable-use, so these missing rules go unnoticed.
>
> Only if you set treesit-font-lock-level to 4, right?
>

[Message part 2 (text/html, inline)]

Message #35 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev <at> rjt.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 04:59:53 +0300

On 01/06/2024 04:56, Noah Peart wrote:
>  > Only if you set treesit-font-lock-level to 4, right?
> 
> Yea, that's true - I assumed most people(?) do, but I just realized
> I hadn't been doing that for years until tree-sitter - and now I've
> become obsessive compulsive about my fonts.

I imagine most actual users just keep in on the default value. But a lot 
customize it, of course, to get closer to "VS Code look".

Personally, I stay with the default, among other things because most of 
the level 4 'variable' highlights just take the easy route and highlight 
all the tokens that haven't been matched by any other existing rule. 
That doesn't feel useful to me.

Message #38 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71209 <at> debbugs.gnu.org, Randy Taylor <dev <at> rjt.dev>
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Fri, 31 May 2024 19:04:58 -0700

[Message part 1 (text/plain, inline)]

> Personally, I stay with the default, among other things because most of
> the level 4 'variable' highlights just take the easy route and highlight
> all the tokens that haven't been matched by any other existing rule.
> That doesn't feel useful to me.

I agree, I used level 4 with the use-face and name-faces being the same
for while, but have since changed use-faces to be only a shade different
from the default face.  It's way more informative to have the decls solidly
stand out.

On Fri, May 31, 2024 at 6:59 PM Dmitry Gutov <dmitry <at> gutov.dev> wrote:

> On 01/06/2024 04:56, Noah Peart wrote:
> >  > Only if you set treesit-font-lock-level to 4, right?
> >
> > Yea, that's true - I assumed most people(?) do, but I just realized
> > I hadn't been doing that for years until tree-sitter - and now I've
> > become obsessive compulsive about my fonts.
>
> I imagine most actual users just keep in on the default value. But a lot
> customize it, of course, to get closer to "VS Code look".
>
> Personally, I stay with the default, among other things because most of
> the level 4 'variable' highlights just take the easy route and highlight
> all the tokens that haven't been matched by any other existing rule.
> That doesn't feel useful to me.
>

[Message part 2 (text/html, inline)]

Message #41 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 17:13:13 +0300

On 01/06/2024 04:50, Noah Peart wrote:
> There is a similar issue with font-lock-property-name-face
> and font-lock-property-use-face.  I've noticed different modes
> treat things differently.  I think object fields in literals should get
> property-name-face, but json-ts-mode, for example,
> doesn't use font-lock-property-name-face at all.

Yeah, that sounds about right. Probably needs some formalization, 
because for cases like json and html I wasn't 100% sure which semantics 
to choose, and unlike in programming code this didn't seem urgent at the 
time.

Message #44 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Noah Peart <noah.v.peart <at> gmail.com>, Randy Taylor <dev <at> rjt.dev>
Cc: 71209 <at> debbugs.gnu.org
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 1 Jun 2024 17:13:57 +0300

On 01/06/2024 04:42, Noah Peart wrote:
> 
> I've been using these for c++, I think they are still missing
> 
>      ;; for (auto x: ...)
>      (for_range_loop
>       declarator: (identifier) @font-lock-variable-name-face)
>      ;; auto& x
>      (reference_declarator
>       (identifier) @font-lock-variable-name-face)
>      ;; auto[&] [x, y]
>      (structured_binding_declarator
>       _ [(identifier)] @font-lock-variable-name-face)
> 
> I suppose most people keep the default font-locking for variable-name
> and variable-use, so these missing rules go unnoticed.

Do you want to submit a full patch with these as well?

Message #47 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: noah.v.peart <at> gmail.com, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 15 Jun 2024 10:56:36 +0300

Ping!  Noah, would you please answer Dmitry?

> Cc: 71209 <at> debbugs.gnu.org
> Date: Sat, 1 Jun 2024 17:13:57 +0300
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 01/06/2024 04:42, Noah Peart wrote:
> > 
> > I've been using these for c++, I think they are still missing
> > 
> >      ;; for (auto x: ...)
> >      (for_range_loop
> >       declarator: (identifier) @font-lock-variable-name-face)
> >      ;; auto& x
> >      (reference_declarator
> >       (identifier) @font-lock-variable-name-face)
> >      ;; auto[&] [x, y]
> >      (structured_binding_declarator
> >       _ [(identifier)] @font-lock-variable-name-face)
> > 
> > I suppose most people keep the default font-locking for variable-name
> > and variable-use, so these missing rules go unnoticed.
> 
> Do you want to submit a full patch with these as well?
> 
> 
> 
> 

Message #50 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: noah.v.peart <at> gmail.com
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Thu, 27 Jun 2024 10:38:31 +0300

Ping! Ping!  Noah, are you still interested in working on this?

> Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> Date: Sat, 15 Jun 2024 10:56:36 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping!  Noah, would you please answer Dmitry?
> 
> > Cc: 71209 <at> debbugs.gnu.org
> > Date: Sat, 1 Jun 2024 17:13:57 +0300
> > From: Dmitry Gutov <dmitry <at> gutov.dev>
> > 
> > On 01/06/2024 04:42, Noah Peart wrote:
> > > 
> > > I've been using these for c++, I think they are still missing
> > > 
> > >      ;; for (auto x: ...)
> > >      (for_range_loop
> > >       declarator: (identifier) @font-lock-variable-name-face)
> > >      ;; auto& x
> > >      (reference_declarator
> > >       (identifier) @font-lock-variable-name-face)
> > >      ;; auto[&] [x, y]
> > >      (structured_binding_declarator
> > >       _ [(identifier)] @font-lock-variable-name-face)
> > > 
> > > I suppose most people keep the default font-locking for variable-name
> > > and variable-use, so these missing rules go unnoticed.
> > 
> > Do you want to submit a full patch with these as well?
> > 
> > 
> > 
> > 
> 
> 
> 
> 

Message #53 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Noah Peart <noah.v.peart <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Thu, 27 Jun 2024 05:29:21 -0400

[Message part 1 (text/plain, inline)]

Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll
take a look today!

On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> Ping! Ping!  Noah, are you still interested in working on this?
>
> > Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> > Date: Sat, 15 Jun 2024 10:56:36 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > Ping!  Noah, would you please answer Dmitry?
> >
> > > Cc: 71209 <at> debbugs.gnu.org
> > > Date: Sat, 1 Jun 2024 17:13:57 +0300
> > > From: Dmitry Gutov <dmitry <at> gutov.dev>
> > >
> > > On 01/06/2024 04:42, Noah Peart wrote:
> > > >
> > > > I've been using these for c++, I think they are still missing
> > > >
> > > >      ;; for (auto x: ...)
> > > >      (for_range_loop
> > > >       declarator: (identifier) @font-lock-variable-name-face)
> > > >      ;; auto& x
> > > >      (reference_declarator
> > > >       (identifier) @font-lock-variable-name-face)
> > > >      ;; auto[&] [x, y]
> > > >      (structured_binding_declarator
> > > >       _ [(identifier)] @font-lock-variable-name-face)
> > > >
> > > > I suppose most people keep the default font-locking for variable-name
> > > > and variable-use, so these missing rules go unnoticed.
> > >
> > > Do you want to submit a full patch with these as well?
> > >
> > >
> > >
> > >
> >
> >
> >
> >
>

[Message part 2 (text/html, inline)]

Message #56 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 06 Jul 2024 10:46:44 +0300

Ping! Any progress with this?

> From: Noah Peart <noah.v.peart <at> gmail.com>
> Date: Thu, 27 Jun 2024 05:29:21 -0400
> Cc: dmitry <at> gutov.dev, 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> 
> Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll take a look today!
> 
> On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  Ping! Ping!  Noah, are you still interested in working on this?
> 
>  > Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
>  > Date: Sat, 15 Jun 2024 10:56:36 +0300
>  > From: Eli Zaretskii <eliz <at> gnu.org>
>  > 
>  > Ping!  Noah, would you please answer Dmitry?
>  > 
>  > > Cc: 71209 <at> debbugs.gnu.org
>  > > Date: Sat, 1 Jun 2024 17:13:57 +0300
>  > > From: Dmitry Gutov <dmitry <at> gutov.dev>
>  > > 
>  > > On 01/06/2024 04:42, Noah Peart wrote:
>  > > > 
>  > > > I've been using these for c++, I think they are still missing
>  > > > 
>  > > >      ;; for (auto x: ...)
>  > > >      (for_range_loop
>  > > >       declarator: (identifier) @font-lock-variable-name-face)
>  > > >      ;; auto& x
>  > > >      (reference_declarator
>  > > >       (identifier) @font-lock-variable-name-face)
>  > > >      ;; auto[&] [x, y]
>  > > >      (structured_binding_declarator
>  > > >       _ [(identifier)] @font-lock-variable-name-face)
>  > > > 
>  > > > I suppose most people keep the default font-locking for variable-name
>  > > > and variable-use, so these missing rules go unnoticed.
>  > > 
>  > > Do you want to submit a full patch with these as well?
>  > > 
>  > > 
>  > > 
>  > > 
>  > 
>  > 
>  > 
>  > 

Message #59 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: noah.v.peart <at> gmail.com
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sat, 20 Jul 2024 12:42:00 +0300

Ping! Ping!  Can we please make some progress here?

> Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
> Date: Sat, 06 Jul 2024 10:46:44 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping! Any progress with this?
> 
> > From: Noah Peart <noah.v.peart <at> gmail.com>
> > Date: Thu, 27 Jun 2024 05:29:21 -0400
> > Cc: dmitry <at> gutov.dev, 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> > 
> > Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll take a look today!
> > 
> > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >  Ping! Ping!  Noah, are you still interested in working on this?
> > 
> >  > Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> >  > Date: Sat, 15 Jun 2024 10:56:36 +0300
> >  > From: Eli Zaretskii <eliz <at> gnu.org>
> >  > 
> >  > Ping!  Noah, would you please answer Dmitry?
> >  > 
> >  > > Cc: 71209 <at> debbugs.gnu.org
> >  > > Date: Sat, 1 Jun 2024 17:13:57 +0300
> >  > > From: Dmitry Gutov <dmitry <at> gutov.dev>
> >  > > 
> >  > > On 01/06/2024 04:42, Noah Peart wrote:
> >  > > > 
> >  > > > I've been using these for c++, I think they are still missing
> >  > > > 
> >  > > >      ;; for (auto x: ...)
> >  > > >      (for_range_loop
> >  > > >       declarator: (identifier) @font-lock-variable-name-face)
> >  > > >      ;; auto& x
> >  > > >      (reference_declarator
> >  > > >       (identifier) @font-lock-variable-name-face)
> >  > > >      ;; auto[&] [x, y]
> >  > > >      (structured_binding_declarator
> >  > > >       _ [(identifier)] @font-lock-variable-name-face)
> >  > > > 
> >  > > > I suppose most people keep the default font-locking for variable-name
> >  > > > and variable-use, so these missing rules go unnoticed.
> >  > > 
> >  > > Do you want to submit a full patch with these as well?
> >  > > 
> >  > > 
> >  > > 
> >  > > 
> >  > 
> >  > 
> >  > 
> >  > 
> 
> 
> 
> 

Message #62 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: noah.v.peart <at> gmail.com
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sun, 04 Aug 2024 10:52:36 +0300

Ping! Ping! Ping!  Noah, are you there?

> Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
> Date: Sat, 20 Jul 2024 12:42:00 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping! Ping!  Can we please make some progress here?
> 
> > Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dev <at> rjt.dev
> > Date: Sat, 06 Jul 2024 10:46:44 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > Ping! Any progress with this?
> > 
> > > From: Noah Peart <noah.v.peart <at> gmail.com>
> > > Date: Thu, 27 Jun 2024 05:29:21 -0400
> > > Cc: dmitry <at> gutov.dev, 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> > > 
> > > Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll take a look today!
> > > 
> > > On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> > > 
> > >  Ping! Ping!  Noah, are you still interested in working on this?
> > > 
> > >  > Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
> > >  > Date: Sat, 15 Jun 2024 10:56:36 +0300
> > >  > From: Eli Zaretskii <eliz <at> gnu.org>
> > >  > 
> > >  > Ping!  Noah, would you please answer Dmitry?
> > >  > 
> > >  > > Cc: 71209 <at> debbugs.gnu.org
> > >  > > Date: Sat, 1 Jun 2024 17:13:57 +0300
> > >  > > From: Dmitry Gutov <dmitry <at> gutov.dev>
> > >  > > 
> > >  > > On 01/06/2024 04:42, Noah Peart wrote:
> > >  > > > 
> > >  > > > I've been using these for c++, I think they are still missing
> > >  > > > 
> > >  > > >      ;; for (auto x: ...)
> > >  > > >      (for_range_loop
> > >  > > >       declarator: (identifier) @font-lock-variable-name-face)
> > >  > > >      ;; auto& x
> > >  > > >      (reference_declarator
> > >  > > >       (identifier) @font-lock-variable-name-face)
> > >  > > >      ;; auto[&] [x, y]
> > >  > > >      (structured_binding_declarator
> > >  > > >       _ [(identifier)] @font-lock-variable-name-face)
> > >  > > > 
> > >  > > > I suppose most people keep the default font-locking for variable-name
> > >  > > > and variable-use, so these missing rules go unnoticed.
> > >  > > 
> > >  > > Do you want to submit a full patch with these as well?
> > >  > > 
> > >  > > 
> > >  > > 
> > >  > > 
> > >  > 
> > >  > 
> > >  > 
> > >  > 
> > 
> > 
> > 
> > 
> 
> 
> 
> 

Message #65 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, Eli Zaretskii <eliz <at> gnu.org>,
 dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Tue, 24 Dec 2024 03:01:56 +0000

Noah Peart <noah.v.peart <at> gmail.com> writes:

> Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll take a look today!

Any updates here?  Thanks!

>
> On Thu, Jun 27, 2024 at 3:38 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>  Ping! Ping!  Noah, are you still interested in working on this?
>
>  > Cc: 71209 <at> debbugs.gnu.org, dev <at> rjt.dev
>  > Date: Sat, 15 Jun 2024 10:56:36 +0300
>  > From: Eli Zaretskii <eliz <at> gnu.org>
>  >
>  > Ping!  Noah, would you please answer Dmitry?
>  >
>  > > Cc: 71209 <at> debbugs.gnu.org
>  > > Date: Sat, 1 Jun 2024 17:13:57 +0300
>  > > From: Dmitry Gutov <dmitry <at> gutov.dev>
>  > >
>  > > On 01/06/2024 04:42, Noah Peart wrote:
>  > > >
>  > > > I've been using these for c++, I think they are still missing
>  > > >
>  > > >      ;; for (auto x: ...)
>  > > >      (for_range_loop
>  > > >       declarator: (identifier) @font-lock-variable-name-face)
>  > > >      ;; auto& x
>  > > >      (reference_declarator
>  > > >       (identifier) @font-lock-variable-name-face)
>  > > >      ;; auto[&] [x, y]
>  > > >      (structured_binding_declarator
>  > > >       _ [(identifier)] @font-lock-variable-name-face)
>  > > >
>  > > > I suppose most people keep the default font-locking for variable-name
>  > > > and variable-use, so these missing rules go unnoticed.
>  > >
>  > > Do you want to submit a full patch with these as well?
>  > >
>  > >
>  > >
>  > >
>  >
>  >
>  >
>  >

Message #70 received at 71209 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 71209 <at> debbugs.gnu.org, dmitry <at> gutov.dev, Eli Zaretskii <eliz <at> gnu.org>,
 dev <at> rjt.dev
Subject: Re: bug#71209: [PATCH] Add font-locking for variables in go-ts-mode
 range clauses
Date: Sun, 23 Feb 2025 00:54:54 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Noah Peart <noah.v.peart <at> gmail.com> writes:
>
>> Ah yes, sorry to be slow, I can submit a patch for those settings.  I'll take a look today!
>
> Any updates here?  Thanks!

Friendly ping.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.