GNU bug report logs - #71184
[PATCH] gnu: Add ruby-appraisal.

Previous Next

Package: guix-patches;

Reported by: Adam Quandour <adam.quandour <at> gmail.com>

Date: Sat, 25 May 2024 04:12:02 UTC

Severity: normal

Tags: patch

Full log


Message #8 received at 71184 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Adam Quandour <adam.quandour <at> gmail.com>, 71184 <at> debbugs.gnu.org
Cc: Adam Quandour <adam.quandour <at> gmail.com>
Subject: Re: [bug#71184] [PATCH] gnu: Add ruby-appraisal.
Date: Sun, 30 Jun 2024 23:02:18 +0200
Hi,

I notice two different packages, can you split the commit please?

Also notice the lint warning on https://qa.guix.gnu.org/issue/71184 :

gnu/packages/ruby.scm:1530:0: ruby-appraisal <at> 2.5.0: line 1530 is way too long (99 characters)
gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: no article allowed at the beginning of the synopsis
gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: synopsis should be
less than 80 characters long

Otherwise: built reproducibly, package definitions themselves LGTM.

-- 
Best regards,
Nicolas Graves




This bug report was last modified 354 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.