GNU bug report logs - #71184
[PATCH] gnu: Add ruby-appraisal.

Previous Next

To reply to this bug, email your comments to 71184 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Quandour <adam.quandour <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Adam Quandour <adam.quandour <at> gmail.com>
Subject: [PATCH] gnu: Add ruby-appraisal.
Date: Sat, 25 May 2024 00:38:07 +0300

* gnu/packages/ruby.scm (ruby-appraisal): New variable.
---
 gnu/packages/ruby.scm | 50 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 5c1e666..53b411b 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1495,6 +1495,33 @@ (define-public ruby-atoulme-saikuro
     ;; of the Expat license.
     (license license:bsd-3)))
 
+(define-public ruby-appraisal
+  (package
+    (name "ruby-appraisal")
+    (version "2.5.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "appraisal" version))
+       (sha256
+        (base32
+         "1knkxrjagaqf418lkgd7xvfb5rh143d19ld8vfq16y8jpqhr561n"))))
+    (build-system ruby-build-system)
+    ;; tests need Internet access.
+    (arguments '(#:tests? #f))
+    (native-inputs
+     (list ruby-activesupport
+           ruby-rspec
+           ruby-thor-0.14.6))
+    (synopsis "A Ruby library for testing your library against different versions of dependencies")
+    (description "Appraisal integrates with bundler and rake to test
+your library against different versions of dependencies in repeatable
+scenarios called \"appraisals\".  Appraisal is designed to make it
+easy to check for regressions in your library without interfering
+ with day-to-day development using Bundler.")
+    (home-page "https://github.com/thoughtbot/appraisal")
+    (license license:expat)))
+
 (define-public ruby-awesome-print
   (package
     (name "ruby-awesome-print")
@@ -3383,6 +3410,29 @@ (define-public ruby-thor
     (home-page "http://whatisthor.com/")
     (license license:expat)))
 
+(define-public ruby-thor-0.14.6
+  ;; needed for ruby-appraisal
+  (package
+    (name "ruby-thor")
+    (version "0.14.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "thor" version))
+       (sha256
+        (base32
+         "18qmgv38gfw9clhq6szyw5kcxkkk8xr7c0klp3pk3cyznzbapif7"))))
+    (build-system ruby-build-system)
+    ;; couldn't run tests
+    ;; "No Rakefile found"
+    (arguments `(#:tests? #f))
+    (native-inputs (list ruby-rspec ruby-simplecov ruby-webmock))
+    (synopsis "Ruby toolkit for building command-line interfaces")
+    (description "Thor is a toolkit for building powerful command-line
+interfaces.")
+    (home-page "http://whatisthor.com/")
+    (license license:expat)))
+
 (define-public ruby-lumberjack
   (package
     (name "ruby-lumberjack")
-- 
2.41.0

Message #8 received at 71184 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: Adam Quandour <adam.quandour <at> gmail.com>, 71184 <at> debbugs.gnu.org
Cc: Adam Quandour <adam.quandour <at> gmail.com>
Subject: Re: [bug#71184] [PATCH] gnu: Add ruby-appraisal.
Date: Sun, 30 Jun 2024 23:02:18 +0200

Hi,

I notice two different packages, can you split the commit please?

Also notice the lint warning on https://qa.guix.gnu.org/issue/71184 :

gnu/packages/ruby.scm:1530:0: ruby-appraisal <at> 2.5.0: line 1530 is way too long (99 characters)
gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: no article allowed at the beginning of the synopsis
gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: synopsis should be
less than 80 characters long

Otherwise: built reproducibly, package definitions themselves LGTM.

-- 
Best regards,
Nicolas Graves

Message #11 received at 71184 <at> debbugs.gnu.org (full text, mbox):

From: Adam <adam.quandour <at> gmail.com>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 71184 <at> debbugs.gnu.org
Subject: Re: [bug#71184] [PATCH] gnu: Add ruby-appraisal.
Date: Tue, 2 Jul 2024 15:58:43 +0300

Hi,
Yeah, I will prepare new patches.


On Mon, Jul 1, 2024 at 12:02 AM Nicolas Graves <ngraves <at> ngraves.fr> wrote:
>
>
> Hi,
>
> I notice two different packages, can you split the commit please?
>
> Also notice the lint warning on https://qa.guix.gnu.org/issue/71184 :
>
> gnu/packages/ruby.scm:1530:0: ruby-appraisal <at> 2.5.0: line 1530 is way too long (99 characters)
> gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: no article allowed at the beginning of the synopsis
> gnu/packages/ruby.scm:1530:14: ruby-appraisal <at> 2.5.0: synopsis should be
> less than 80 characters long
>
> Otherwise: built reproducibly, package definitions themselves LGTM.
>
> --
> Best regards,
> Nicolas Graves

Message #14 received at 71184 <at> debbugs.gnu.org (full text, mbox):

From: Adam Quandour <adam.quandour <at> gmail.com>
To: ngraves <at> ngraves.fr,
	71184 <at> debbugs.gnu.org
Cc: Adam Quandour <adam.quandour <at> gmail.com>
Subject: [PATCH 2/2] gnu: Add ruby-appraisal.
Date: Tue,  2 Jul 2024 16:35:59 +0300

* gnu/packages/ruby.scm (ruby-appraisal): New variable.
---
 gnu/packages/ruby.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 59d5446..e7f25ac 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -14627,6 +14627,33 @@ (define-public ruby-m
     (home-page "https://github.com/qrush/m")
     (license license:expat)))
 
+(define-public ruby-appraisal
+  (package
+    (name "ruby-appraisal")
+    (version "2.5.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "appraisal" version))
+       (sha256
+        (base32
+         "1knkxrjagaqf418lkgd7xvfb5rh143d19ld8vfq16y8jpqhr561n"))))
+    (build-system ruby-build-system)
+    ;; tests need Internet access.
+    (arguments '(#:tests? #f))
+    (native-inputs
+     (list ruby-activesupport
+           ruby-rspec
+           ruby-thor-0.14.6))
+    (synopsis "Library for testing your library against dependencies")
+    (description "Appraisal integrates with bundler and rake to test
+your library against different versions of dependencies in repeatable
+scenarios called \"appraisals\".  Appraisal is designed to make it
+easy to check for regressions in your library without interfering
+ with day-to-day development using Bundler.")
+    (home-page "https://github.com/thoughtbot/appraisal")
+    (license license:expat)))
+
 (define-public ruby-mercenary
   (package
     (name "ruby-mercenary")
-- 
2.45.2

Message #17 received at 71184 <at> debbugs.gnu.org (full text, mbox):

From: Adam Quandour <adam.quandour <at> gmail.com>
To: ngraves <at> ngraves.fr,
	71184 <at> debbugs.gnu.org
Cc: Adam Quandour <adam.quandour <at> gmail.com>
Subject: [PATCH 1/2] gnu: Add ruby-thor-0.14.6.
Date: Tue,  2 Jul 2024 16:35:58 +0300

* gnu/packages/ruby.scm (ruby-thor-0.14.6): New variable.
---
 gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 9547481..59d5446 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -3397,6 +3397,31 @@ (define-public ruby-thor
     (home-page "http://whatisthor.com/")
     (license license:expat)))
 
+(define-public ruby-thor-0.14.6
+  ;; this package is needed for packaging ruby-appraisal
+  ;; for some reason ruby-appraisal depends on this exact
+  ;; version of this package
+  (package
+    (name "ruby-thor")
+    (version "0.14.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "thor" version))
+       (sha256
+        (base32
+         "18qmgv38gfw9clhq6szyw5kcxkkk8xr7c0klp3pk3cyznzbapif7"))))
+    (build-system ruby-build-system)
+    ;; couldn't run tests
+    ;; "No Rakefile found"
+    (arguments `(#:tests? #f))
+    (native-inputs (list ruby-rspec ruby-simplecov ruby-webmock))
+    (synopsis "Ruby toolkit for building command-line interfaces")
+    (description "Thor is a toolkit for building powerful command-line
+interfaces.")
+    (home-page "http://whatisthor.com/")
+    (license license:expat)))
+
 (define-public ruby-lumberjack
   (package
     (name "ruby-lumberjack")
-- 
2.45.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.