GNU bug report logs - #71123
[PATCH] Rename `subr-native-elisp` to `native-comp-function`

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#71123: closed (Re: bug#71123: [PATCH] Rename `subr-native-elisp`
 to `native-comp-function`)
Date: Wed, 29 May 2024 00:55:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function`

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 71123 <at> debbugs.gnu.org.

-- 
71123: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71123
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 71123-done <at> debbugs.gnu.org
Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to
 `native-comp-function`
Date: Tue, 28 May 2024 20:53:56 -0400

Pushed to `master`, closing, thanks,


        Stefan

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Rename `subr-native-elisp` to `native-comp-function`
Date: Wed, 22 May 2024 13:50:17 -0400

[Message part 4 (text/plain, inline)]

Tags: patch

I can't remember where someone requested a nicer name than
`subr-native-elisp`, but here's a patch which aims to do that.

AFAICT we do not need to preserve the *type* `subr-native-elisp` because
it was never exposed to ELisp before Emacs-30 anyway.  So the only
backward compatibility needed is the `subr-native-elisp-p` function.

I chose `native-comp-function` as the new name based on a few
`grep`s through our C code which suggested that `native-comp-` is the
most "popular" prefix in there from code related to native compilation.

I don't have a strong preference, so if there's a consensus around
another name, I'll happily change the patch accordingly.


        Stefan


 In GNU Emacs 30.0.50 (build 2, i686-pc-linux-gnu, GTK+ Version 3.24.41,
 cairo version 1.18.0) of 2024-03-06 built on lechazo
Repository revision: b0d12d2b65c94af306c8f116a3dfb0040e2feef3
Repository branch: work
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Debian GNU/Linux trixie/sid

Configured using:
 'configure -C --enable-checking --enable-check-lisp-object-type --with-modules --with-cairo --with-tiff=ifavailable
 'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign' --without-native-compilation
 PKG_CONFIG_PATH=/home/monnier/lib/pkgconfig'

[0001-Rename-subr-native-elisp-to-native-comp-function.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.