Package: emacs;
Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date: Wed, 22 May 2024 17:51:02 UTC
Severity: normal
Tags: patch
Done: Stefan Monnier <monnier <at> iro.umontreal.ca>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 71123 in the body.
You can then email your comments to 71123 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
View this report as an mbox folder, status mbox, maintainer mbox
monnier <at> iro.umontreal.ca, bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Wed, 22 May 2024 17:51:02 GMT) Full text and rfc822 format available.Stefan Monnier <monnier <at> iro.umontreal.ca>:monnier <at> iro.umontreal.ca, bug-gnu-emacs <at> gnu.org.
(Wed, 22 May 2024 17:51:02 GMT) Full text and rfc822 format available.Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
From: Stefan Monnier <monnier <at> iro.umontreal.ca> To: bug-gnu-emacs <at> gnu.org Subject: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Wed, 22 May 2024 13:50:17 -0400
[Message part 1 (text/plain, inline)]
Tags: patch
I can't remember where someone requested a nicer name than
`subr-native-elisp`, but here's a patch which aims to do that.
AFAICT we do not need to preserve the *type* `subr-native-elisp` because
it was never exposed to ELisp before Emacs-30 anyway. So the only
backward compatibility needed is the `subr-native-elisp-p` function.
I chose `native-comp-function` as the new name based on a few
`grep`s through our C code which suggested that `native-comp-` is the
most "popular" prefix in there from code related to native compilation.
I don't have a strong preference, so if there's a consensus around
another name, I'll happily change the patch accordingly.
Stefan
In GNU Emacs 30.0.50 (build 2, i686-pc-linux-gnu, GTK+ Version 3.24.41,
cairo version 1.18.0) of 2024-03-06 built on lechazo
Repository revision: b0d12d2b65c94af306c8f116a3dfb0040e2feef3
Repository branch: work
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Debian GNU/Linux trixie/sid
Configured using:
'configure -C --enable-checking --enable-check-lisp-object-type --with-modules --with-cairo --with-tiff=ifavailable
'CFLAGS=-Wall -g3 -Og -Wno-pointer-sign' --without-native-compilation
PKG_CONFIG_PATH=/home/monnier/lib/pkgconfig'
[0001-Rename-subr-native-elisp-to-native-comp-function.patch (text/patch, attachment)]
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Wed, 22 May 2024 18:48:02 GMT) Full text and rfc822 format available.Message #8 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Stefan Monnier <monnier <at> iro.umontreal.ca> To: 71123 <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Wed, 22 May 2024 14:47:13 -0400
[Message part 1 (text/plain, inline)]
And of course, I forgot to include `etc/NEWS`.
Here's an updated patch, together with the natural subsequent patch to
fix the compiler warnings due to old calls to the new obsolete function.
Stefan
[0001-Rename-subr-native-elisp-to-native-comp-function.patch (text/x-diff, inline)]
From 512c9392cac0e9682e5f3306aa4355a996541d7b Mon Sep 17 00:00:00 2001
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date: Wed, 22 May 2024 13:45:39 -0400
Subject: [PATCH 1/2] Rename `subr-native-elisp` to `native-comp-function`
Now that this type name is displayed in *Help*, it is more
important to use a name that is less weird for the unsuspecting user.
* lisp/emacs-lisp/cl-preloaded.el (cl-functionp): Adjust to new name of
native function's type.
(subr-native-elisp-p): Redefine as an obsolete alias.
(native-comp-function): Rename from `subr-native-elisp`
* src/data.c (Fcl_type_of): Return `Qnative_comp_function` i.s.o
`Qsubr_native_elisp`.
(Fnative_comp_function_p): Rename from `Fsubr_native_elisp_p`.
(syms_of_data): Adjust accordingly.
* src/doc.c (Fsubr_documentation): Use new `Fnative_comp_function_p` name.
---
etc/NEWS | 4 ++++
lisp/emacs-lisp/cl-preloaded.el | 5 +++--
src/data.c | 12 ++++++------
src/doc.c | 2 +-
4 files changed, 14 insertions(+), 9 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index d72ef5b5bef..c3e2b70bbc1 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1880,6 +1880,10 @@ documentation and examples.
* Incompatible Lisp Changes in Emacs 30.1
+---
+** 'subr-native-elisp-p' is renamed to 'native-comp-function-p'.
+The previous name still exists but is marked as obsolete.
+
+++
** Evaluating a 'lambda' returns an object of type 'interpreted-function'.
Instead of representing interpreted functions as lists that start with
diff --git a/lisp/emacs-lisp/cl-preloaded.el b/lisp/emacs-lisp/cl-preloaded.el
index fa745396b02..4b1bd2a9aff 100644
--- a/lisp/emacs-lisp/cl-preloaded.el
+++ b/lisp/emacs-lisp/cl-preloaded.el
@@ -355,7 +355,7 @@ cl-functionp
This is like `functionp' except that it returns nil for all lists and symbols,
regardless if `funcall' would accept to call them."
(memq (cl-type-of object)
- '(primitive-function subr-native-elisp module-function
+ '(primitive-function native-comp-function module-function
interpreted-function byte-code-function)))
(cl--define-built-in-type t nil "Abstract supertype of everything.")
@@ -465,7 +465,8 @@ interpreted-function
"Type of functions that have not been compiled.")
(cl--define-built-in-type special-form (subr)
"Type of the core syntactic elements of the Emacs Lisp language.")
-(cl--define-built-in-type subr-native-elisp (subr compiled-function)
+(define-obsolete-function-alias 'subr-native-elisp-p #'native-comp-function-p "30.1")
+(cl--define-built-in-type native-comp-function (subr compiled-function)
"Type of functions that have been compiled by the native compiler.")
(cl--define-built-in-type primitive-function (subr compiled-function)
"Type of functions hand written in C.")
diff --git a/src/data.c b/src/data.c
index 30d8eab7359..2ff5050580d 100644
--- a/src/data.c
+++ b/src/data.c
@@ -244,7 +244,7 @@ DEFUN ("cl-type-of", Fcl_type_of, Scl_type_of, 1, 1, 0,
case PVEC_WINDOW: return Qwindow;
case PVEC_SUBR:
return XSUBR (object)->max_args == UNEVALLED ? Qspecial_form
- : SUBR_NATIVE_COMPILEDP (object) ? Qsubr_native_elisp
+ : SUBR_NATIVE_COMPILEDP (object) ? Qnative_comp_function
: Qprimitive_function;
case PVEC_CLOSURE:
return CONSP (AREF (object, CLOSURE_CODE))
@@ -1060,9 +1060,8 @@ DEFUN ("subr-name", Fsubr_name, Ssubr_name, 1, 1, 0,
return build_string (name);
}
-DEFUN ("subr-native-elisp-p", Fsubr_native_elisp_p, Ssubr_native_elisp_p, 1, 1,
- 0, doc: /* Return t if the object is native compiled lisp
-function, nil otherwise. */)
+DEFUN ("native-comp-function-p", Fnative_comp_function_p, Snative_comp_function_p, 1, 1,
+ 0, doc: /* Return t if the object is native compiled Lisp function, nil otherwise. */)
(Lisp_Object object)
{
return SUBR_NATIVE_COMPILEDP (object) ? Qt : Qnil;
@@ -4151,7 +4150,8 @@ #define PUT_ERROR(sym, tail, msg) \
DEFSYM (Qsubr, "subr");
DEFSYM (Qspecial_form, "special-form");
DEFSYM (Qprimitive_function, "primitive-function");
- DEFSYM (Qsubr_native_elisp, "subr-native-elisp");
+ DEFSYM (Qsubr_native_elisp, "subr-native-elisp"); /* Deprecated name. */
+ DEFSYM (Qnative_comp_function, "native-comp-function");
DEFSYM (Qbyte_code_function, "byte-code-function");
DEFSYM (Qinterpreted_function, "interpreted-function");
DEFSYM (Qbuffer, "buffer");
@@ -4286,7 +4286,7 @@ #define PUT_ERROR(sym, tail, msg) \
defsubr (&Sbyteorder);
defsubr (&Ssubr_arity);
defsubr (&Ssubr_name);
- defsubr (&Ssubr_native_elisp_p);
+ defsubr (&Snative_comp_function_p);
defsubr (&Ssubr_native_lambda_list);
defsubr (&Ssubr_type);
#ifdef HAVE_NATIVE_COMP
diff --git a/src/doc.c b/src/doc.c
index 36633a920c6..9cd8b60f118 100644
--- a/src/doc.c
+++ b/src/doc.c
@@ -431,7 +431,7 @@ DEFUN ("internal-subr-documentation", Fsubr_documentation, Ssubr_documentation,
(Lisp_Object function)
{
#ifdef HAVE_NATIVE_COMP
- if (!NILP (Fsubr_native_elisp_p (function)))
+ if (!NILP (Fnative_comp_function_p (function)))
return native_function_doc (function);
else
#endif
--
2.43.0
[0002-Redirect-calls-to-subr-native-elisp-p-to-native-comp.patch (text/x-diff, inline)]
From 2965f85459dfbafcd02c47177d6b1ee1a5aeb2d8 Mon Sep 17 00:00:00 2001
From: Stefan Monnier <monnier <at> iro.umontreal.ca>
Date: Wed, 22 May 2024 14:45:35 -0400
Subject: [PATCH 2/2] Redirect calls to `subr-native-elisp-p` to
`native-comp-function-p`
* test/src/comp-tests.el (comp-tests-bootstrap, lambda-return)
(lambda-return2, free-fun, free-fun2, free-fun-silly-name, speed--1)
(compile-forms, comp-test-defsubst, primitive-redefine-compile-44221)
(48029-1, 61917-1, tco, fw-prop-1, pure):
* test/lisp/help-fns-tests.el (help-fns-test-lisp-defun):
* lisp/subr.el (subr-primitive-p, primitive-function-p, symbol-file):
* lisp/help-fns.el (find-lisp-object-file-name):
* lisp/emacs-lisp/disass.el (disassemble-internal):
* lisp/emacs-lisp/comp.el (comp--call-optim-form-call):
* lisp/emacs-lisp/comp-run.el (comp-warn-primitives):
* lisp/emacs-lisp/comp-common.el (comp-function-type-spec):
* lisp/emacs-lisp/byte-opt.el (side-effect-free-fns):
* lisp/emacs-lisp/bytecomp.el (<trailer>): Rename `subr-native-elisp-p`
to `native-comp-function-p`.
---
lisp/emacs-lisp/byte-opt.el | 5 +++--
lisp/emacs-lisp/bytecomp.el | 2 +-
lisp/emacs-lisp/comp-common.el | 2 +-
lisp/emacs-lisp/comp-run.el | 2 +-
lisp/emacs-lisp/comp.el | 2 +-
lisp/emacs-lisp/disass.el | 4 ++--
lisp/help-fns.el | 2 +-
lisp/subr.el | 8 +++----
test/lisp/help-fns-tests.el | 2 +-
test/src/comp-tests.el | 40 +++++++++++++++++-----------------
10 files changed, 35 insertions(+), 34 deletions(-)
diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
index 4095726d276..c060c8d676b 100644
--- a/lisp/emacs-lisp/byte-opt.el
+++ b/lisp/emacs-lisp/byte-opt.el
@@ -1876,9 +1876,10 @@ byte-optimize-set
byteorder car-safe cdr-safe char-or-string-p char-table-p
condition-variable-p consp eq floatp indirect-function
integer-or-marker-p integerp keywordp listp markerp
- module-function-p multibyte-string-p mutexp natnump nlistp null
+ module-function-p multibyte-string-p mutexp native-comp-function-p
+ natnump nlistp null
number-or-marker-p numberp recordp remove-pos-from-symbol
- sequencep stringp subr-native-elisp-p subrp symbol-with-pos-p symbolp
+ sequencep stringp subrp symbol-with-pos-p symbolp
threadp type-of user-ptrp vector-or-char-table-p vectorp wholenump
;; editfns.c
bobp bolp buffer-size buffer-string current-message emacs-pid
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 12b45f9f5b8..03cfbe6f4c9 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -6028,7 +6028,7 @@ byte-compile-report-ops
(let ((byte-optimize nil) ; do it fast
(byte-compile-warnings nil))
(mapc (lambda (x)
- (unless (subr-native-elisp-p x)
+ (unless (native-comp-function-p x)
(or noninteractive (message "compiling %s..." x))
(byte-compile x)
(or noninteractive (message "compiling %s...done" x))))
diff --git a/lisp/emacs-lisp/comp-common.el b/lisp/emacs-lisp/comp-common.el
index 355988838c7..ce6296953bf 100644
--- a/lisp/emacs-lisp/comp-common.el
+++ b/lisp/emacs-lisp/comp-common.el
@@ -518,7 +518,7 @@ comp-function-type-spec
(if-let ((delc-type (function-get function 'function-type)))
;; Declared Lisp function
(setf type-spec delc-type)
- (when (subr-native-elisp-p f)
+ (when (native-comp-function-p f)
;; Native compiled inferred
(setf kind 'inferred
type-spec (subr-type f))))))
diff --git a/lisp/emacs-lisp/comp-run.el b/lisp/emacs-lisp/comp-run.el
index 5cc61579030..f159c5b1911 100644
--- a/lisp/emacs-lisp/comp-run.el
+++ b/lisp/emacs-lisp/comp-run.el
@@ -341,7 +341,7 @@ comp-run-async-workers
(clrhash comp-deferred-pending-h)))
(defconst comp-warn-primitives
- '(null memq gethash and subrp not subr-native-elisp-p
+ '(null memq gethash and subrp not native-comp-function-p
comp--install-trampoline concat if symbolp symbol-name make-string
length aset aref length> mapcar expand-file-name
file-name-as-directory file-exists-p native-elisp-load)
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 4c76f95a0e9..32d4442ca1b 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -2847,7 +2847,7 @@ comp--call-optim-form-call
(subrp (subrp f))
(comp-func-callee (comp--func-in-unit callee)))
(cond
- ((and subrp (not (subr-native-elisp-p f)))
+ ((and subrp (not (native-comp-function-p f)))
;; Trampoline removal.
(let* ((callee (intern (subr-name f))) ; Fix aliased names.
(maxarg (cdr (subr-arity f)))
diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el
index 91427166137..07072f2a2be 100644
--- a/lisp/emacs-lisp/disass.el
+++ b/lisp/emacs-lisp/disass.el
@@ -91,8 +91,8 @@ disassemble-internal
args)
(setq obj (autoload-do-load obj name))
(if (subrp obj)
- (if (and (fboundp 'subr-native-elisp-p)
- (subr-native-elisp-p obj))
+ (if (and (fboundp 'native-comp-function-p)
+ (native-comp-function-p obj))
(progn
(require 'comp)
(let ((eln (native-comp-unit-file (subr-native-comp-unit obj))))
diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 182b22549b5..af27d101ac8 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -475,7 +475,7 @@ find-lisp-object-file-name
(cond
((and (not file-name)
(subrp type)
- (not (subr-native-elisp-p type)))
+ (not (native-comp-function-p type)))
;; A built-in function. The form is from `describe-function-1'.
(if (or (get-buffer " *DOC*")
(and also-c-source
diff --git a/lisp/subr.el b/lisp/subr.el
index d6481fdf73e..d171ac7adac 100644
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -316,14 +316,14 @@ subr-primitive-p
Such objects can be functions or special forms."
(declare (side-effect-free error-free))
(and (subrp object)
- (not (subr-native-elisp-p object))))
+ (not (native-comp-function-p object))))
(defsubst primitive-function-p (object)
"Return t if OBJECT is a built-in primitive function.
This excludes special forms, since they are not functions."
(declare (side-effect-free error-free))
(and (subrp object)
- (not (or (subr-native-elisp-p object)
+ (not (or (native-comp-function-p object)
(eq (cdr (subr-arity object)) 'unevalled)))))
(defsubst xor (cond1 cond2)
@@ -3022,7 +3022,7 @@ define-symbol-prop
(defvar comp-native-version-dir)
(defvar native-comp-eln-load-path)
-(declare-function subr-native-elisp-p "data.c")
+(declare-function native-comp-function-p "data.c")
(declare-function native-comp-unit-file "data.c")
(declare-function subr-native-comp-unit "data.c")
(declare-function comp-el-to-eln-rel-filename "comp.c")
@@ -3071,7 +3071,7 @@ symbol-file
(symbolp symbol)
(native-comp-available-p)
;; If it's a defun, we have a shortcut.
- (subr-native-elisp-p (symbol-function symbol)))
+ (native-comp-function-p (symbol-function symbol)))
;; native-comp-unit-file returns unnormalized file names.
(expand-file-name (native-comp-unit-file (subr-native-comp-unit
(symbol-function symbol))))
diff --git a/test/lisp/help-fns-tests.el b/test/lisp/help-fns-tests.el
index 82350a4bc71..7393a2624fe 100644
--- a/test/lisp/help-fns-tests.el
+++ b/test/lisp/help-fns-tests.el
@@ -67,7 +67,7 @@ help-fns-test-lisp-defun
(result (help-fns-tests--describe-function 'last)))
(should (string-match regexp result))
(should (member (match-string 1 result)
- '("subr-native-elisp" "byte-code-function")))))
+ '("native-comp-function" "byte-code-function")))))
(ert-deftest help-fns-test-lisp-defsubst ()
(let ((regexp "a byte-code-function in .+subr\\.el")
diff --git a/test/src/comp-tests.el b/test/src/comp-tests.el
index 5deff03fd84..dffb7097a3e 100644
--- a/test/src/comp-tests.el
+++ b/test/src/comp-tests.el
@@ -85,13 +85,13 @@ comp-tests-bootstrap
(copy-file comp-src comp2-src t)
(let ((load-no-native t))
(load (concat comp-src "c") nil nil t t))
- (should-not (subr-native-elisp-p (symbol-function 'native-compile)))
+ (should-not (native-comp-function-p (symbol-function 'native-compile)))
(message "Compiling stage1...")
(let* ((t0 (current-time))
(comp1-eln (native-compile comp1-src)))
(message "Done in %d secs" (float-time (time-since t0)))
(load comp1-eln nil nil t t)
- (should (subr-native-elisp-p (symbol-function 'native-compile)))
+ (should (native-comp-function-p (symbol-function 'native-compile)))
(message "Compiling stage2...")
(let ((t0 (current-time))
(comp2-eln (native-compile comp2-src)))
@@ -325,15 +325,15 @@ buffer
(comp-deftest lambda-return ()
(let ((f (comp-tests-lambda-return-f)))
- (should (subr-native-elisp-p f))
+ (should (native-comp-function-p f))
(should (= (funcall f 3) 4))))
(comp-deftest lambda-return2 ()
"Check a nested lambda function gets native compiled."
(let ((f (comp-tests-lambda-return-f2)))
- (should (subr-native-elisp-p f))
+ (should (native-comp-function-p f))
(let ((f2 (funcall f)))
- (should (subr-native-elisp-p f2))
+ (should (native-comp-function-p f2))
(should (= (funcall f2 3) 4)))))
(comp-deftest recursive ()
@@ -391,7 +391,7 @@ free-fun
t)
(native-compile #'comp-tests-free-fun-f)
- (should (subr-native-elisp-p (symbol-function 'comp-tests-free-fun-f)))
+ (should (native-comp-function-p (symbol-function 'comp-tests-free-fun-f)))
(should (= (comp-tests-free-fun-f) 3))
(should (string= (documentation #'comp-tests-free-fun-f)
"Some doc."))
@@ -412,8 +412,8 @@ free-fun2
(let* ((f (symbol-function 'comp-tests-free-fun-f2))
(f2 (funcall f)))
- (should (subr-native-elisp-p f))
- (should (subr-native-elisp-p f2))
+ (should (native-comp-function-p f))
+ (should (native-comp-function-p f2))
(should (string= (documentation f2) "Some doc."))
(should (commandp f2))
(should (equal (interactive-form f2) '(interactive nil)))
@@ -425,7 +425,7 @@ free-fun-silly-name
"Check we are able to compile a single function."
(eval '(defun comp-tests/free\fun-f ()) t)
(native-compile #'comp-tests/free\fun-f)
- (should (subr-native-elisp-p (symbol-function 'comp-tests/free\fun-f))))
+ (should (native-comp-function-p (symbol-function 'comp-tests/free\fun-f))))
(comp-deftest bug-40187 ()
"Check function name shadowing.
@@ -436,7 +436,7 @@ bug-40187
(comp-deftest speed--1 ()
"Check that at speed -1 we do not native compile."
(should (= (comp-test-speed--1-f) 3))
- (should-not (subr-native-elisp-p (symbol-function 'comp-test-speed--1-f))))
+ (should-not (native-comp-function-p (symbol-function 'comp-test-speed--1-f))))
(comp-deftest bug-42360 ()
"<https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-07/msg00418.html>."
@@ -497,22 +497,22 @@ compile-forms
(should-error (native-compile '(+ 1 foo)))
(let ((lexical-binding t)
(f (native-compile '(lambda (x) (1+ x)))))
- (should (subr-native-elisp-p f))
+ (should (native-comp-function-p f))
(should (= (funcall f 2) 3)))
(let* ((lexical-binding nil)
(f (native-compile '(lambda (x) (1+ x)))))
- (should (subr-native-elisp-p f))
+ (should (native-comp-function-p f))
(should (= (funcall f 2) 3))))
(comp-deftest comp-test-defsubst ()
;; Bug#42664, Bug#43280, Bug#44209.
- (should-not (subr-native-elisp-p (symbol-function 'comp-test-defsubst-f))))
+ (should-not (native-comp-function-p (symbol-function 'comp-test-defsubst-f))))
(comp-deftest primitive-redefine-compile-44221 ()
"Test the compiler still works while primitives are redefined (bug#44221)."
(cl-letf (((symbol-function 'delete-region)
(lambda (_ _))))
- (should (subr-native-elisp-p
+ (should (native-comp-function-p
(native-compile
'(lambda ()
(delete-region (point-min) (point-max))))))))
@@ -564,7 +564,7 @@ comp-test-47868-1
(comp-deftest 48029-1 ()
"<https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-07/msg00666.html>"
- (should (subr-native-elisp-p
+ (should (native-comp-function-p
(symbol-function 'comp-test-48029-nonascii-žžž-f))))
(comp-deftest 61917-1 ()
@@ -578,7 +578,7 @@ 61917-1
(setf x (native-compile
'(lambda ()
(delete-region 1 2))))
- (should (subr-native-elisp-p x))
+ (should (native-comp-function-p x))
(funcall x)
(advice-remove #'delete-region f)
(should (equal comp-test-primitive-redefine-args '(1 2))))))
@@ -874,7 +874,7 @@ tco
(comp-tests-tco-f (+ a b) a (- count 1))))
t)
(native-compile #'comp-tests-tco-f)
- (should (subr-native-elisp-p (symbol-function 'comp-tests-tco-f)))
+ (should (native-comp-function-p (symbol-function 'comp-tests-tco-f)))
(should (= (comp-tests-tco-f 1 0 10) 55))))
(defun comp-tests-fw-prop-checker-1 (_)
@@ -901,7 +901,7 @@ fw-prop-1
(length c))) ; <= has to optimize
t)
(native-compile #'comp-tests-fw-prop-1-f)
- (should (subr-native-elisp-p (symbol-function 'comp-tests-fw-prop-1-f)))
+ (should (native-comp-function-p (symbol-function 'comp-tests-fw-prop-1-f)))
(should (= (comp-tests-fw-prop-1-f) 6))))
(defun comp-tests--type-lists-equal (l1 l2)
@@ -1556,10 +1556,10 @@ pure
(declare-function comp-tests-pure-caller-f nil)
(declare-function comp-tests-pure-fibn-entry-f nil)
- (should (subr-native-elisp-p (symbol-function 'comp-tests-pure-caller-f)))
+ (should (native-comp-function-p (symbol-function 'comp-tests-pure-caller-f)))
(should (= (comp-tests-pure-caller-f) 4))
- (should (subr-native-elisp-p (symbol-function 'comp-tests-pure-fibn-entry-f)))
+ (should (native-comp-function-p (symbol-function 'comp-tests-pure-fibn-entry-f)))
(should (= (comp-tests-pure-fibn-entry-f) 6765))))
(defvar comp-tests-cond-rw-checked-function nil
--
2.43.0
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Fri, 24 May 2024 07:18:02 GMT) Full text and rfc822 format available.Message #11 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Andrea Corallo <acorallo <at> gnu.org> To: 71123 <at> debbugs.gnu.org Cc: Stefan Monnier <monnier <at> iro.umontreal.ca> Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Fri, 24 May 2024 03:17:30 -0400
Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> writes: > Tags: patch > > I can't remember where someone requested a nicer name than > `subr-native-elisp`, but here's a patch which aims to do that. > > AFAICT we do not need to preserve the *type* `subr-native-elisp` because > it was never exposed to ELisp before Emacs-30 anyway. So the only > backward compatibility needed is the `subr-native-elisp-p` function. > > I chose `native-comp-function` as the new name based on a few > `grep`s through our C code which suggested that `native-comp-` is the > most "popular" prefix in there from code related to native compilation. > > I don't have a strong preference, so if there's a consensus around > another name, I'll happily change the patch accordingly. Hi Stefan, I don't have a strong opinion about renaming this, at the time I called it subr- something as in my mind it was really a subr from an ABI stand point of view. So yeah my implementor view was probably biased technically. For this reason I'm not opposed to this change but I'd like to hear Eli's opinion. On the patch itself I've three comments: - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? - The patch introduces a number of warnings in: help-fns.el, subr.el, bytecomp.el, comp.el, comp-common.el. - It's also introducing a fail in lisp/help-fns-tests.log Thanks Andrea
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Fri, 24 May 2024 07:38:01 GMT) Full text and rfc822 format available.Message #14 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Eli Zaretskii <eliz <at> gnu.org> To: Andrea Corallo <acorallo <at> gnu.org> Cc: 71123 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Fri, 24 May 2024 10:37:24 +0300
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca> > From: Andrea Corallo <acorallo <at> gnu.org> > Date: Fri, 24 May 2024 03:17:30 -0400 > > Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" <bug-gnu-emacs <at> gnu.org> writes: > > > Tags: patch > > > > I can't remember where someone requested a nicer name than > > `subr-native-elisp`, but here's a patch which aims to do that. > > > > AFAICT we do not need to preserve the *type* `subr-native-elisp` because > > it was never exposed to ELisp before Emacs-30 anyway. So the only > > backward compatibility needed is the `subr-native-elisp-p` function. > > > > I chose `native-comp-function` as the new name based on a few > > `grep`s through our C code which suggested that `native-comp-` is the > > most "popular" prefix in there from code related to native compilation. > > > > I don't have a strong preference, so if there's a consensus around > > another name, I'll happily change the patch accordingly. > > Hi Stefan, > > I don't have a strong opinion about renaming this, at the time I called > it subr- something as in my mind it was really a subr from an ABI stand > point of view. So yeah my implementor view was probably biased > technically. > > For this reason I'm not opposed to this change but I'd like to hear > Eli's opinion. I don't like renaming in general (it increases the mess we have, and makes it harder to remember things). But in this case I don't object, since this particular term is used only very rarely (provided that all the adverse consequences you mention are fixed, of course).
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Fri, 24 May 2024 13:08:02 GMT) Full text and rfc822 format available.Message #17 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Stefan Monnier <monnier <at> iro.umontreal.ca> To: Andrea Corallo <acorallo <at> gnu.org> Cc: 71123 <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Fri, 24 May 2024 09:07:23 -0400
> On the patch itself I've three comments:
>
> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and
> SUBR_NATIVE_COMPILED_DYNP macros as well for consistency?
No opinion on this. Eli?
> - The patch introduces a number of warnings in: help-fns.el, subr.el,
> bytecomp.el, comp.el, comp-common.el.
> - It's also introducing a fail in lisp/help-fns-tests.log
AFAIK these were fixed by the second patch.
Do you still see them after installing the two patches?
Stefan
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Fri, 24 May 2024 14:48:01 GMT) Full text and rfc822 format available.Message #20 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Eli Zaretskii <eliz <at> gnu.org> To: Stefan Monnier <monnier <at> iro.umontreal.ca> Cc: 71123 <at> debbugs.gnu.org, acorallo <at> gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Fri, 24 May 2024 17:46:53 +0300
> Cc: 71123 <at> debbugs.gnu.org > Date: Fri, 24 May 2024 09:07:23 -0400 > From: Stefan Monnier via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org> > > > On the patch itself I've three comments: > > > > - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and > > SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? > > No opinion on this. Eli? I think it will help if the names are similar, yes.
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Sat, 25 May 2024 07:17:02 GMT) Full text and rfc822 format available.Message #23 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Andrea Corallo <acorallo <at> gnu.org> To: Stefan Monnier <monnier <at> iro.umontreal.ca> Cc: 71123 <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Sat, 25 May 2024 03:16:38 -0400
Stefan Monnier <monnier <at> iro.umontreal.ca> writes: >> On the patch itself I've three comments: >> >> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and >> SUBR_NATIVE_COMPILED_DYNP macros as well for consistency? > > No opinion on this. Eli? Sorry I realize I formulated the phrase a bit unclear, my opinion FWIW is that we should rename those. >> - The patch introduces a number of warnings in: help-fns.el, subr.el, >> bytecomp.el, comp.el, comp-common.el. >> - It's also introducing a fail in lisp/help-fns-tests.log > > AFAIK these were fixed by the second patch. > Do you still see them after installing the two patches? I've installed the second version of your patch, isn't this a replacement for the first? Andrea
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Tue, 28 May 2024 19:37:01 GMT) Full text and rfc822 format available.Message #26 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Stefan Monnier <monnier <at> iro.umontreal.ca> To: Andrea Corallo <acorallo <at> gnu.org> Cc: 71123 <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Tue, 28 May 2024 15:35:53 -0400
> I've installed the second version of your patch, isn't this a
> replacement for the first?
The second email had 2 patches: a newer version of the original patch
plus a second patch (which is the one that should presumably fix the
warnings and test failures).
Stefan
bug-gnu-emacs <at> gnu.org:bug#71123; Package emacs.
(Tue, 28 May 2024 20:00:01 GMT) Full text and rfc822 format available.Message #29 received at 71123 <at> debbugs.gnu.org (full text, mbox):
From: Andrea Corallo <acorallo <at> gnu.org> To: Stefan Monnier <monnier <at> iro.umontreal.ca> Cc: 71123 <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Tue, 28 May 2024 15:58:48 -0400
Stefan Monnier <monnier <at> iro.umontreal.ca> writes: >> I've installed the second version of your patch, isn't this a >> replacement for the first? > > The second email had 2 patches: a newer version of the original patch > plus a second patch (which is the one that should presumably fix the > warnings and test failures). Ouch I missed that sorry! Yes I confirm I see no warnings nor failures. Okay by me with 'SUBR_NATIVE_COMPILEDP' and 'SUBR_NATIVE_COMPILED_DYNP' renamed. Thanks Andrea
Stefan Monnier <monnier <at> iro.umontreal.ca>:Stefan Monnier <monnier <at> iro.umontreal.ca>:Message #34 received at 71123-done <at> debbugs.gnu.org (full text, mbox):
From: Stefan Monnier <monnier <at> iro.umontreal.ca> To: Andrea Corallo <acorallo <at> gnu.org> Cc: 71123-done <at> debbugs.gnu.org Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to `native-comp-function` Date: Tue, 28 May 2024 20:53:56 -0400
Pushed to `master`, closing, thanks,
Stefan
Debbugs Internal Request <help-debbugs <at> gnu.org>
to internal_control <at> debbugs.gnu.org.
(Wed, 26 Jun 2024 11:24:06 GMT) Full text and rfc822 format available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.