GNU bug report logs - #71123
[PATCH] Rename `subr-native-elisp` to `native-comp-function`

Previous Next

Full log

Message #23 received at 71123 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 71123 <at> debbugs.gnu.org
Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to
 `native-comp-function`
Date: Sat, 25 May 2024 03:16:38 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> On the patch itself I've three comments:
>>
>> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and
>>   SUBR_NATIVE_COMPILED_DYNP macros as well for consistency?
>
> No opinion on this.  Eli?

Sorry I realize I formulated the phrase a bit unclear, my opinion FWIW
is that we should rename those.

>> - The patch introduces a number of warnings in: help-fns.el, subr.el,
>>   bytecomp.el, comp.el, comp-common.el.
>> - It's also introducing a fail in lisp/help-fns-tests.log
>
> AFAIK these were fixed by the second patch.
> Do you still see them after installing the two patches?

I've installed the second version of your patch, isn't this a
replacement for the first?

  Andrea

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.