GNU bug report logs - #71123
[PATCH] Rename `subr-native-elisp` to `native-comp-function`

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Wed, 22 May 2024 17:51:02 UTC

Severity: normal

Tags: patch

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 71123 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 71123 <at> debbugs.gnu.org
Subject: Re: bug#71123: [PATCH] Rename `subr-native-elisp` to
 `native-comp-function`
Date: Fri, 24 May 2024 09:07:23 -0400

> On the patch itself I've three comments:
>
> - If we go for it, shouldn't we rename SUBR_NATIVE_COMPILEDP and
>   SUBR_NATIVE_COMPILED_DYNP macros as well for consistency?

No opinion on this.  Eli?

> - The patch introduces a number of warnings in: help-fns.el, subr.el,
>   bytecomp.el, comp.el, comp-common.el.
> - It's also introducing a fail in lisp/help-fns-tests.log

AFAIK these were fixed by the second patch.
Do you still see them after installing the two patches?


        Stefan
This bug report was last modified 1 year and 50 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.