GNU bug report logs - #70797
[PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors

Previous Next

Package: emacs;

Reported by: Rudolf Adamkovič <rudolf <at> adamkovic.org>

Date: Mon, 6 May 2024 07:11:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #25 received at 70797-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
Cc: 70797-done <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors
Date: Sat, 22 Jun 2024 11:34:02 +0300
> From: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
> Cc: 70797 <at> debbugs.gnu.org
> Date: Thu, 13 Jun 2024 16:44:04 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >   . applying this fails compile-tests in the test suite, so I guess
> >     some adjustment there is also needed;
> 
> Oops!  In the new patch, attached below, I
> 
> - adjust the existing legacy Gradle/Kotlin tests and
> - add new tests for the non-legacy Gradle/Kotlin warnings/errors.
> 
> I also improved the commit message a bit.
> 
> >   . you removed the comment with the pointer to kotlin sources, which
> >     might be still useful for the legacy format (unless the URL is no
> >     longer valid), so please restore that if the pointer can still be
> >     useful
> 
> Smart!  All right, I did a bit of research, and documented
> 
> - the first and last Kotlin version that emits the current format,
> - the last Kotlin version that used the legacy format,
> - the official Git commit that removed the legacy format,
> - the public release date of the current format, and
> - the Kotlin class where the current format is defined.
> 
> All of it is packed into two short comments.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future mention the bug number in the commit log
messages, when you know the number.  In the initial submission of a
patch, the number is usually not known, but if you resubmit, it
usually is known already.  (I added the bug number when installing the
changes.)




This bug report was last modified 333 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.