GNU bug report logs - #70797
[PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70797 in the body.
You can then email your comments to 70797 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
 errors
Date: Mon, 06 May 2024 00:14:04 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

[0001-Make-the-Compilation-mode-recognize-non-legacy-Kotli.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
"All you have to do is write one true sentence.  Write the truest
sentence that you know."  --- Ernest Miller Hemingway (1899-1961)

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
Studenohorská 25, 84103 Bratislava, Slovakia, European Union

Message #8 received at 70797 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rudolf Adamkovič <rudolf <at> adamkovic.org>
Cc: 70797 <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy
 Kotlin/Gradle errors
Date: Sat, 11 May 2024 11:56:02 +0300

> From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
> Date: Mon, 06 May 2024 00:14:04 +0200
> 
> >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf <at> adamkovic.org>
> Date: Thu, 2 May 2024 19:06:11 +0200
> Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
>  errors
> 
> The Compilation mode recognizes Kotlin/Gradle errors but only in the old
> format.  The new format, which has been in wide use for about a year, is
> not supported.  This patch adds support for the new format.
> 
> * etc/compilation.txt:
> (symbols): Add a non-legacy Kotlin/Gradle warning and error.
> * lisp/progmodes/compile.el:
> (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to
> 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and
> warnings outputted by non-legacy Kotlin/Gradle.
> ---
>  etc/compilation.txt       | 13 +++++++++++--
>  lisp/progmodes/compile.el | 20 +++++++++++++++++---
>  2 files changed, 28 insertions(+), 5 deletions(-)

Thanks, but:

  . applying this fails compile-tests in the test suite, so I guess
    some adjustment there is also needed;
  . you removed the comment with the pointer to kotlin sources, which
    might be still useful for the legacy format (unless the URL is no
    longer valid), so please restore that if the pointer can still be
    useful

Thanks.

Message #11 received at 70797 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: rudolf <at> adamkovic.org
Cc: 70797 <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy
 Kotlin/Gradle errors
Date: Sat, 25 May 2024 10:46:53 +0300

Ping!  Can we please make progress with resolving this issue?

> Cc: 70797 <at> debbugs.gnu.org
> Date: Sat, 11 May 2024 11:56:02 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
> > Date: Mon, 06 May 2024 00:14:04 +0200
> > 
> > >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001
> > From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf <at> adamkovic.org>
> > Date: Thu, 2 May 2024 19:06:11 +0200
> > Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
> >  errors
> > 
> > The Compilation mode recognizes Kotlin/Gradle errors but only in the old
> > format.  The new format, which has been in wide use for about a year, is
> > not supported.  This patch adds support for the new format.
> > 
> > * etc/compilation.txt:
> > (symbols): Add a non-legacy Kotlin/Gradle warning and error.
> > * lisp/progmodes/compile.el:
> > (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to
> > 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and
> > warnings outputted by non-legacy Kotlin/Gradle.
> > ---
> >  etc/compilation.txt       | 13 +++++++++++--
> >  lisp/progmodes/compile.el | 20 +++++++++++++++++---
> >  2 files changed, 28 insertions(+), 5 deletions(-)
> 
> Thanks, but:
> 
>   . applying this fails compile-tests in the test suite, so I guess
>     some adjustment there is also needed;
>   . you removed the comment with the pointer to kotlin sources, which
>     might be still useful for the legacy format (unless the URL is no
>     longer valid), so please restore that if the pointer can still be
>     useful
> 
> Thanks.
> 
> 
> 
> 

Message #14 received at 70797 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: rudolf <at> adamkovic.org
Cc: 70797 <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy
 Kotlin/Gradle errors
Date: Sat, 08 Jun 2024 14:44:31 +0300

Ping! Ping! Can we please resolve this issue?

> Cc: 70797 <at> debbugs.gnu.org
> Date: Sat, 25 May 2024 10:46:53 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Ping!  Can we please make progress with resolving this issue?
> 
> > Cc: 70797 <at> debbugs.gnu.org
> > Date: Sat, 11 May 2024 11:56:02 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> > 
> > > From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
> > > Date: Mon, 06 May 2024 00:14:04 +0200
> > > 
> > > >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001
> > > From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf <at> adamkovic.org>
> > > Date: Thu, 2 May 2024 19:06:11 +0200
> > > Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
> > >  errors
> > > 
> > > The Compilation mode recognizes Kotlin/Gradle errors but only in the old
> > > format.  The new format, which has been in wide use for about a year, is
> > > not supported.  This patch adds support for the new format.
> > > 
> > > * etc/compilation.txt:
> > > (symbols): Add a non-legacy Kotlin/Gradle warning and error.
> > > * lisp/progmodes/compile.el:
> > > (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to
> > > 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and
> > > warnings outputted by non-legacy Kotlin/Gradle.
> > > ---
> > >  etc/compilation.txt       | 13 +++++++++++--
> > >  lisp/progmodes/compile.el | 20 +++++++++++++++++---
> > >  2 files changed, 28 insertions(+), 5 deletions(-)
> > 
> > Thanks, but:
> > 
> >   . applying this fails compile-tests in the test suite, so I guess
> >     some adjustment there is also needed;
> >   . you removed the comment with the pointer to kotlin sources, which
> >     might be still useful for the legacy format (unless the URL is no
> >     longer valid), so please restore that if the pointer can still be
> >     useful
> > 
> > Thanks.
> > 
> > 
> > 
> > 
> 
> 
> 
> 

Message #17 received at 70797 <at> debbugs.gnu.org (full text, mbox):

From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70797 <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors
Date: Sun, 09 Jun 2024 23:40:41 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Ping! Ping! Can we please resolve this issue?

My apologies, I got swamped with life.

I plan to get back to working on FLOSS soon.

Rudy
-- 
"I love deadlines.  I love the whooshing noise they make as they go by."
--- Douglas Adams, The Salmon of Doubt, 2002

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
http://adamkovic.org

Message #20 received at 70797 <at> debbugs.gnu.org (full text, mbox):

From: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70797 <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors
Date: Thu, 13 Jun 2024 16:44:04 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>   . applying this fails compile-tests in the test suite, so I guess
>     some adjustment there is also needed;

Oops!  In the new patch, attached below, I

- adjust the existing legacy Gradle/Kotlin tests and
- add new tests for the non-legacy Gradle/Kotlin warnings/errors.

I also improved the commit message a bit.

>   . you removed the comment with the pointer to kotlin sources, which
>     might be still useful for the legacy format (unless the URL is no
>     longer valid), so please restore that if the pointer can still be
>     useful

Smart!  All right, I did a bit of research, and documented

- the first and last Kotlin version that emits the current format,
- the last Kotlin version that used the legacy format,
- the official Git commit that removed the legacy format,
- the public release date of the current format, and
- the Kotlin class where the current format is defined.

All of it is packed into two short comments.

Rudy

[0001-Make-the-Compilation-mode-recognize-non-legacy-Kotli.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
"Mathematics takes us still further from what is human into the region
of absolute necessity, to which not only the actual world, but every
possible world, must conform."  --- Bertrand Russell, 1902

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
http://adamkovic.org

Message #25 received at 70797-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
Cc: 70797-done <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors
Date: Sat, 22 Jun 2024 11:34:02 +0300

> From: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
> Cc: 70797 <at> debbugs.gnu.org
> Date: Thu, 13 Jun 2024 16:44:04 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >   . applying this fails compile-tests in the test suite, so I guess
> >     some adjustment there is also needed;
> 
> Oops!  In the new patch, attached below, I
> 
> - adjust the existing legacy Gradle/Kotlin tests and
> - add new tests for the non-legacy Gradle/Kotlin warnings/errors.
> 
> I also improved the commit message a bit.
> 
> >   . you removed the comment with the pointer to kotlin sources, which
> >     might be still useful for the legacy format (unless the URL is no
> >     longer valid), so please restore that if the pointer can still be
> >     useful
> 
> Smart!  All right, I did a bit of research, and documented
> 
> - the first and last Kotlin version that emits the current format,
> - the last Kotlin version that used the legacy format,
> - the official Git commit that removed the legacy format,
> - the public release date of the current format, and
> - the Kotlin class where the current format is defined.
> 
> All of it is packed into two short comments.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future mention the bug number in the commit log
messages, when you know the number.  In the initial submission of a
patch, the number is usually not known, but if you resubmit, it
usually is known already.  (I added the bug number when installing the
changes.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.