GNU bug report logs - #70797
[PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70797: closed ([PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors)
Date: Sat, 22 Jun 2024 08:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 22 Jun 2024 11:34:02 +0300
with message-id <86v821idfp.fsf <at> gnu.org>
and subject line Re: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors
has caused the debbugs.gnu.org bug report #70797,
regarding [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70797: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70797
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Rudolf Adamkovič <rudolf <at> adamkovic.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
 errors
Date: Mon, 06 May 2024 00:14:04 +0200

[Message part 3 (text/plain, inline)]

Tags: patch

[0001-Make-the-Compilation-mode-recognize-non-legacy-Kotli.patch (text/patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
"All you have to do is write one true sentence.  Write the truest
sentence that you know."  --- Ernest Miller Hemingway (1899-1961)

Rudolf Adamkovič <rudolf <at> adamkovic.org> [he/him]
Studenohorská 25, 84103 Bratislava, Slovakia, European Union

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
Cc: 70797-done <at> debbugs.gnu.org
Subject: Re: bug#70797: [PATCH] Make the Compilation mode recognize
 non-legacy Kotlin/Gradle errors
Date: Sat, 22 Jun 2024 11:34:02 +0300

> From: Rudolf (Rudy) Adamkovic <rudolf <at> adamkovic.org>
> Cc: 70797 <at> debbugs.gnu.org
> Date: Thu, 13 Jun 2024 16:44:04 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >   . applying this fails compile-tests in the test suite, so I guess
> >     some adjustment there is also needed;
> 
> Oops!  In the new patch, attached below, I
> 
> - adjust the existing legacy Gradle/Kotlin tests and
> - add new tests for the non-legacy Gradle/Kotlin warnings/errors.
> 
> I also improved the commit message a bit.
> 
> >   . you removed the comment with the pointer to kotlin sources, which
> >     might be still useful for the legacy format (unless the URL is no
> >     longer valid), so please restore that if the pointer can still be
> >     useful
> 
> Smart!  All right, I did a bit of research, and documented
> 
> - the first and last Kotlin version that emits the current format,
> - the last Kotlin version that used the legacy format,
> - the official Git commit that removed the legacy format,
> - the public release date of the current format, and
> - the Kotlin class where the current format is defined.
> 
> All of it is packed into two short comments.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future mention the bug number in the commit log
messages, when you know the number.  In the initial submission of a
patch, the number is usually not known, but if you resubmit, it
usually is known already.  (I added the bug number when installing the
changes.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.