GNU bug report logs - #70795
30.0.50; inconsistent warning-display-at-bottom display-buffer-alist behavior

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70795 in the body.
You can then email your comments to 70795 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
To: Bug gnu emacs <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; inconsistent warning-display-at-bottom
 display-buffer-alist behavior
Date: Mon, 06 May 2024 06:06:03 +0000

Hi,

if I set warning-display-at-bottom to nil and do

(add-to-list 'display-buffer-alist
               `(,(rx (or "*Warnings*" "*compilation*"))
                 display-buffer-no-window
                 (allow-no-window . t)))

then warnings are added to the hidden *Warnings* buffer.

But if I set warning-display-at-bottom to t, then I get an
window-live-p related error with the display-buffer-alist
setting above.

This bug is related to #70773 where Prot reports a similar
problem in a somewhat different context.
Juri Linkov proposed a patch which he retracted, but maybe
his patch solves the inconsistency reported here.

Regards -- Gerard

Message #8 received at 70795 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
Cc: 70795 <at> debbugs.gnu.org
Subject: Re: bug#70795: 30.0.50; inconsistent warning-display-at-bottom
 display-buffer-alist behavior
Date: Mon, 06 May 2024 09:46:57 +0300

> (add-to-list 'display-buffer-alist
>                `(,(rx (or "*Warnings*" "*compilation*"))
>                  display-buffer-no-window
>                  (allow-no-window . t)))
>
> then warnings are added to the hidden *Warnings* buffer.

This is because this case doesn't set 'warning-series',
so when window is nil, it doesn't fail at anoter place
while calling 'set-window-start':

  (when (and (markerp warning-series)
             (eq (marker-buffer warning-series) buffer))
    (set-window-start window warning-series))

Ok, I will add only checks for nil window.
But won't add (allow-no-window . t) to the caller of
'display-buffer' in 'display-warning' to not encourage
hiding the warning buffer.

Message #11 received at 70795 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Gerard Vermeulen <gerard.vermeulen <at> posteo.net>
Cc: 70795 <at> debbugs.gnu.org
Subject: Re: bug#70795: 30.0.50; inconsistent warning-display-at-bottom
 display-buffer-alist behavior
Date: Mon, 06 May 2024 20:00:34 +0300

forcemerge 70773 70795
close 70795 30.0.50
thanks

>> (add-to-list 'display-buffer-alist
>>                `(,(rx (or "*Warnings*" "*compilation*"))
>>                  display-buffer-no-window
>>                  (allow-no-window . t)))
>>
>> then warnings are added to the hidden *Warnings* buffer.
>
> This is because this case doesn't set 'warning-series',
> so when window is nil, it doesn't fail at anoter place
> while calling 'set-window-start':
>
>   (when (and (markerp warning-series)
>              (eq (marker-buffer warning-series) buffer))
>     (set-window-start window warning-series))
>
> Ok, I will add only checks for nil window.
> But won't add (allow-no-window . t) to the caller of
> 'display-buffer' in 'display-warning' to not encourage
> hiding the warning buffer.

So now pushed the extra guards for windows.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.