GNU bug report logs - #70715
[PATCH 0/4] Change imported crate style.

Previous Next

Package: guix-patches;

Reported by: Herman Rimm <herman <at> rimm.ee>

Date: Thu, 2 May 2024 12:58:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 70715 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Herman Rimm <herman <at> rimm.ee>
Cc: 70715 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#70715] [PATCH v2 2/3] guix: Include a main verb in crate
 importer descriptions.
Date: Mon, 03 Jun 2024 22:38:45 +0200
Herman Rimm <herman <at> rimm.ee> skribis:

> +++ b/guix/import/crate.scm
> @@ -187,6 +187,7 @@ (define* (make-crate-sexp #:key name version cargo-inputs cargo-development-inpu
>           (guix-name (crate-name->package-name name))
>           (cargo-inputs (format-inputs cargo-inputs))
>           (cargo-development-inputs (format-inputs cargo-development-inputs))
> +         (description (beautify-description description))
>           (pkg `(package
>                     (name ,guix-name)
>                     (version ,version)
> @@ -212,7 +213,10 @@ (define* (make-crate-sexp #:key name version cargo-inputs cargo-development-inpu
>                                                  cargo-development-inputs)))
>                     (home-page ,home-page)
>                     (synopsis ,(beautify-synopsis synopsis))
> -                   (description ,(beautify-description description))
> +                   (description ,(if (string-prefix? "This" description)
> +                                   description
> +                                   (string-append "This package provides "
> +                                                  description)))

I took the liberty to indent the ‘if’ above in the usual way.




This bug report was last modified 353 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.