GNU bug report logs - #70715
[PATCH 0/4] Change imported crate style.

Previous Next

Package: guix-patches;

Reported by: Herman Rimm <herman <at> rimm.ee>

Date: Thu, 2 May 2024 12:58:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #14 received at 70715 <at> debbugs.gnu.org (full text, mbox):

From: Herman Rimm <herman <at> rimm.ee>
To: 70715 <at> debbugs.gnu.org
Subject: [PATCH 3/4] guix: Include a main verb in crate importer descriptions.
Date: Thu,  2 May 2024 14:58:59 +0200
* guix/import/crate.scm (make-crate-sexp): Start description with
'This package provides '.

Change-Id: Id627759fb23da14fa7cb84e5dffb3bfc41950eab
---
 guix/import/crate.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/guix/import/crate.scm b/guix/import/crate.scm
index 2f74333fa9..e739faa503 100644
--- a/guix/import/crate.scm
+++ b/guix/import/crate.scm
@@ -187,6 +187,7 @@ (define (format-inputs inputs)
          (guix-name (crate-name->package-name name))
          (cargo-inputs (format-inputs cargo-inputs))
          (cargo-development-inputs (format-inputs cargo-development-inputs))
+         (description (beautify-description description))
          (pkg `(package
                    (name ,guix-name)
                    (version ,version)
@@ -212,7 +213,10 @@ (define (format-inputs inputs)
                                               (maybe-cargo-inputs cargo-inputs)))
                    (home-page ,home-page)
                    (synopsis ,(beautify-synopsis synopsis))
-                   (description ,(beautify-description description))
+                   (description ,(if (string-prefix? "This" description)
+                                   description
+                                   (string-append "This package provides "
+                                                  description)))
                    (license ,(match license
                                (() #f)
                                (#f #f)
-- 
2.41.0





This bug report was last modified 353 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.