GNU bug report logs - #70691
30.0.50; [PATCH] Eshell's TERM env varible use eshell-term-name as default

Previous Next

Full log

Message #8 received at 70691 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7.mail <at> gmail.com>, Jim Porter <jporterbugs <at> gmail.com>
Cc: 70691 <at> debbugs.gnu.org
Subject: Re: bug#70691: 30.0.50;
 [PATCH] Eshell's TERM env varible use eshell-term-name as default
Date: Wed, 01 May 2024 15:15:03 +0300

> From: Lin Sun <sunlin7.mail <at> gmail.com>
> Date: Wed, 1 May 2024 06:40:25 +0000
> 
> Since emacs-29 the Eshell has been enhanced for the ansi-color a lot.
> And the function `eshell-exec-visual` can support the executables with
> colors, eg VIM, tmux...
> I have tested the "/bin/ls --color=tty", "/bin/grep --color=tty" ...
> and other executables in Eshell with "export TERM=eshell-color", they
> all work great.
> 
> So we can safely export eshell's "TERM" with `eshell-term-name` to
> support executables with colors.
> I attached the patch, please help review it. Thanks.

Thanks.

The fact that we can safely do that does not yet mean we _should_ do
it.  In my book, setting TERM is a user preference, more or less.
IOW, this is a change in the default behavior.

Jim, WDYT?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.