GNU bug report logs - #70690
[PATCH] gnu: rust: install rust-analyzer-proc-macro-srv

Previous Next

To reply to this bug, email your comments to 70690 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brennan Vincent <brennan <at> umanwizard.com>
To: guix-patches <at> gnu.org
Cc: Brennan Vincent <brennan <at> umanwizard.com>, efraim <at> flashner.co.il
Subject: [PATCH] gnu: rust: install rust-analyzer-proc-macro-srv
Date: Tue, 30 Apr 2024 23:47:32 -0400

* gnu/packages/rust.scm (rust): Install rust-analyzer-proc-macro-srv
rust-analyzer relies on this binary existing, and recent versions
of rust no longer install it by default.

Change-Id: I7ce59c065a35cf2592e7eb2fa57317aa9a8df675
---
 gnu/packages/rust.scm | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm
index 8cbbac53ac..24783d8aa2 100644
--- a/gnu/packages/rust.scm
+++ b/gnu/packages/rust.scm
@@ -1214,7 +1214,9 @@ (define-public rust
                            "src/tools/cargo"
                            "src/tools/clippy"
                            "src/tools/rust-analyzer"
-                           "src/tools/rustfmt"))))
+                           "src/tools/rust-analyzer/crates/proc-macro-srv-cli"
+                           "src/tools/rustfmt"))
+                 ))
              (replace 'check
                ;; Phase overridden to also test more tools.
                (lambda* (#:key tests? parallel-build? #:allow-other-keys)
@@ -1244,7 +1246,16 @@ (define-public rust
                     (format #f "prefix = ~s" (assoc-ref outputs "tools"))))
                  (invoke "./x.py" "install" "clippy")
                  (invoke "./x.py" "install" "rust-analyzer")
-                 (invoke "./x.py" "install" "rustfmt")))
+                 (invoke "./x.py" "install" "rustfmt")
+                 ;; ./x.py doesn't have an install target
+                 ;; for the proc macro server, so we install it manually
+                 (let* ((out (assoc-ref outputs "out"))
+                        (platform ,(platform-rust-target
+                                    (lookup-platform-by-target-or-system
+                                     (or (%current-target-system)
+                                         (%current-system))))))
+                   (install-file (string-append "build/" platform "/stage2-tools/" platform "/release/rust-analyzer-proc-macro-srv")
+                                 (string-append out "/libexec")))))
              (add-after 'install 'install-rust-src
                (lambda* (#:key outputs #:allow-other-keys)
                  (let ((out (assoc-ref outputs "rust-src"))
-- 
2.41.0

Message #8 received at 70690 <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: Brennan Vincent <brennan <at> umanwizard.com>
Cc: 70690 <at> debbugs.gnu.org, efraim <at> flashner.co.il
Subject: Re: [bug#70690] [PATCH] gnu: rust: install
 rust-analyzer-proc-macro-srv
Date: Wed, 28 Aug 2024 12:09:36 -0400

I tested this patch and it resolved an project error while using
rust-analyzer with Eglot. Seems good to me.

Without this patch rust-analyzer prints things like:

--8<---------------cut here---------------start------------->8---
rust-analyzer [unresolved-proc-macro]: proc macro `Parser` not expanded:
cannot find proc-macro server in sysroot /gnu/store/blah-rust-1.77.1.
--8<---------------cut here---------------end--------------->8---

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.

Message #11 received at 70690 <at> debbugs.gnu.org (full text, mbox):

From: antlers <at> illucid.net
To: 70690 <at> debbugs.gnu.org
Subject: [PATCH] gnu: rust: install rust-analyzer-proc-macro-srv
Date: Fri, 14 Feb 2025 17:20:36 -0800

i found this helpful too

Message #14 received at 70690 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Brennan Vincent <brennan <at> umanwizard.com>
Cc: 70690 <at> debbugs.gnu.org, efraim <at> flashner.co.il,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#70690] [PATCH] gnu: rust: install
 rust-analyzer-proc-macro-srv
Date: Thu, 20 Feb 2025 17:27:29 +0100

Hi Rust team,

On Tue, 30 Apr 2024 at 23:47, Brennan Vincent <brennan <at> umanwizard.com> wrote:
> * gnu/packages/rust.scm (rust): Install rust-analyzer-proc-macro-srv
> rust-analyzer relies on this binary existing, and recent versions
> of rust no longer install it by default.
>
> Change-Id: I7ce59c065a35cf2592e7eb2fa57317aa9a8df675
> ---
>  gnu/packages/rust.scm | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)

This patch is marked as reviewed-looks-good and had fallen into the
cracks.  Merge or close?  WDYT?

Cheers,
simon

Message #17 received at 70690 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: Brennan Vincent <brennan <at> umanwizard.com>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>, 70690 <at> debbugs.gnu.org
Subject: Re: [bug#70690] [PATCH] gnu: rust: install
 rust-analyzer-proc-macro-srv
Date: Thu, 20 Feb 2025 19:32:45 +0200

[Message part 1 (text/plain, inline)]

On Thu, Feb 20, 2025 at 05:27:29PM +0100, Simon Tournier wrote:
> Hi Rust team,
> 
> On Tue, 30 Apr 2024 at 23:47, Brennan Vincent <brennan <at> umanwizard.com> wrote:
> > * gnu/packages/rust.scm (rust): Install rust-analyzer-proc-macro-srv
> > rust-analyzer relies on this binary existing, and recent versions
> > of rust no longer install it by default.
> >
> > Change-Id: I7ce59c065a35cf2592e7eb2fa57317aa9a8df675
> > ---
> >  gnu/packages/rust.scm | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> This patch is marked as reviewed-looks-good and had fallen into the
> cracks.  Merge or close?  WDYT?

The patch looks so good I basically re-implemented it myself! :/

Currently the version of this patch sitting on the rust-team branch
installs rust-analyzer-proc-macro-srv from stage1-tools-bin, is it
supposed to be from stage2-tools instead?  If so I'll create a patch to
fix that and attribute it to you (Brennan) since I should've checked the
patch tracker.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 70690 <at> debbugs.gnu.org (full text, mbox):

From: "Brennan Vincent" <brennan <at> umanwizard.com>
To: Efraim Flashner <efraim <at> flashner.co.il>, Simon Tournier
 <zimon.toutoune <at> gmail.com>
Cc: 70690 <at> debbugs.gnu.org, Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#70690] [PATCH] gnu: rust: install
 rust-analyzer-proc-macro-srv
Date: Thu, 20 Feb 2025 14:51:11 -0700

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Thu, Feb 20, 2025 at 05:27:29PM +0100, Simon Tournier wrote:
>> Hi Rust team,
>> 
>> On Tue, 30 Apr 2024 at 23:47, Brennan Vincent <brennan <at> umanwizard.com> wrote:
>> > * gnu/packages/rust.scm (rust): Install rust-analyzer-proc-macro-srv
>> > rust-analyzer relies on this binary existing, and recent versions
>> > of rust no longer install it by default.
>> >
>> > Change-Id: I7ce59c065a35cf2592e7eb2fa57317aa9a8df675
>> > ---
>> >  gnu/packages/rust.scm | 15 +++++++++++++--
>> >  1 file changed, 13 insertions(+), 2 deletions(-)
>> 
>> This patch is marked as reviewed-looks-good and had fallen into the
>> cracks.  Merge or close?  WDYT?
>
> The patch looks so good I basically re-implemented it myself! :/
>
> Currently the version of this patch sitting on the rust-team branch
> installs rust-analyzer-proc-macro-srv from stage1-tools-bin, is it
> supposed to be from stage2-tools instead?  If so I'll create a patch to
> fix that and attribute it to you (Brennan) since I should've checked the
> patch tracker.

I didn't think about it too hard, but I'm not sure why we'd ever prefer
to install things from an _earlier_ bootstrapping stage...

> -- 
> Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.