GNU bug report logs - #70609
30.0.50; [PATCH] New function 'python-shell-send-block' for python-mode

Previous Next

Full log

Message #14 received at 70609 <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: kobarity <kobarity <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 70609 <at> debbugs.gnu.org
Subject: Re: bug#70609: 30.0.50; [PATCH] New function 'python-shell-send-block'
 for python-mode
Date: Tue, 30 Apr 2024 15:51:18 +0000

[Message part 1 (text/plain, inline)]

Hi Kobarity,

On Tue, Apr 30, 2024 at 7:28 AM kobarity <kobarity <at> gmail.com> wrote:
>
> Eli Zaretskii wrote:
> >
> > > From: Lin Sun <sunlin7.mail <at> gmail.com>
> > > Date: Sat, 27 Apr 2024 14:14:06 +0000
> > >
> > > Here is a function 'python-shell-send-block' to send a block to the
> > > python interpreter in python mode, it's similar to
> > > `python-shell-send-defun` but works on block.
> > >
> > > The implementation and testing are included in that patch.
> > >
> > > Please help review the changes.
> > >
> > > [PATCH] New function 'python-shell-send-block' for python-mode
> > >
> > > * lisp/progmodes/python.el: Add implemention of the function.
> > > * test/lisp/progmodes/python-tests.el: Test case for the function.
> > > * etc/NEWS: Document for the function.
> >
> > kobarity, any comments?
>
> I think `python-shell-send-block' itself is good, but there may be
> room for improvement in the test case.
>
> It is better not to use f-strings as much as possible because it
> depends on the Python version.
>
> `python-tests-look-at' is basically for moving point.  Since it looks
> for the next occurrence of the specified string, it may move the point
> to an unexpected location.  For testing, it would be better to use
> `looking-at', etc. or compare the point after moving with
> `python-tests-look-at' to the expected value.
Thanks for the comments and you're right, so I attach the changes to
avoid the python f-string, also using the `looking-at` to do  exactly
matching.
Please help review the enhanced testing code. Thanks.

[0001-New-function-python-shell-send-block-for-python-mode.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.