GNU bug report logs - #70608
[PATCH] Make preview-region work outside LaTeX-mode buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70608 in the body.
You can then email your comments to 70608 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Make preview-region work outside LaTeX-mode buffers
Date: Sat, 27 Apr 2024 15:52:14 +0200

[Message part 1 (text/plain, inline)]

This patch has no effect on existing behavior (in LaTeX-mode), but
makes it so that preview-region works in any non-LaTeX-mode buffer for
which TeX-master has been set to a valid tex file.  This is intended
for internal use by other packages.  For example, I've been using
something equivalent to this to preview org-mode LaTeX source blocks,
tex code in Lean4 comments, (...).

(One could avoid this patch by manually initializing TeX-header-end
and TeX-trailer-start before calling preview-region, but it seems
better to me to provide working defaults as in the patch.  Any
feedback would be welcome, of course.)

Thanks, best,

Paul

[0001-Make-preview-region-work-outside-LaTeX-mode-buffers.patch (application/octet-stream, attachment)]

Message #8 received at 70608 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70608 <at> debbugs.gnu.org
Subject: Re: bug#70608: [PATCH] Make preview-region work outside LaTeX-mode
 buffers
Date: Sat, 04 May 2024 15:59:15 +0200

Hi Paul,

Paul Nelson <ultrono <at> gmail.com> writes:

> This patch has no effect on existing behavior (in LaTeX-mode), but
> makes it so that preview-region works in any non-LaTeX-mode buffer for
> which TeX-master has been set to a valid tex file.  This is intended
> for internal use by other packages.  For example, I've been using
> something equivalent to this to preview org-mode LaTeX source blocks,
> tex code in Lean4 comments, (...).
>
> (One could avoid this patch by manually initializing TeX-header-end
> and TeX-trailer-start before calling preview-region, but it seems
> better to me to provide working defaults as in the patch.  Any
> feedback would be welcome, of course.)

I'm a little reluctant about this change; tex.el provides generic
functions/variables which are set by the modes; `TeX-header-end' and
`TeX-trailer-start' are some of them.  My preference is what you
describe above: If `preview-region' is used outside `LaTeX-mode', the 2
variables should be initialized there somehow and not inside tex.el.

Best, Arash

Message #11 received at 70608 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: 70608 <at> debbugs.gnu.org
Subject: Re: bug#70608: [PATCH] Make preview-region work outside LaTeX-mode
 buffers
Date: Sat, 4 May 2024 16:37:41 +0200

[Message part 1 (text/plain, inline)]

Hi Arash, OK, thanks for your response, please feel free to close. Thanks,
best,  Paul

On Sat, 4 May 2024 at 15:59, Arash Esbati <arash <at> gnu.org> wrote:

> Hi Paul,
>
> Paul Nelson <ultrono <at> gmail.com> writes:
>
> > This patch has no effect on existing behavior (in LaTeX-mode), but
> > makes it so that preview-region works in any non-LaTeX-mode buffer for
> > which TeX-master has been set to a valid tex file.  This is intended
> > for internal use by other packages.  For example, I've been using
> > something equivalent to this to preview org-mode LaTeX source blocks,
> > tex code in Lean4 comments, (...).
> >
> > (One could avoid this patch by manually initializing TeX-header-end
> > and TeX-trailer-start before calling preview-region, but it seems
> > better to me to provide working defaults as in the patch.  Any
> > feedback would be welcome, of course.)
>
> I'm a little reluctant about this change; tex.el provides generic
> functions/variables which are set by the modes; `TeX-header-end' and
> `TeX-trailer-start' are some of them.  My preference is what you
> describe above: If `preview-region' is used outside `LaTeX-mode', the 2
> variables should be initialized there somehow and not inside tex.el.
>
> Best, Arash
>

[Message part 2 (text/html, inline)]

Message #14 received at 70608 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70608 <at> debbugs.gnu.org
Subject: Re: bug#70608: [PATCH] Make preview-region work outside LaTeX-mode
 buffers
Date: Sat, 04 May 2024 21:47:15 +0200

tags 70608 wontfix
close 70608
thanks

Paul Nelson <ultrono <at> gmail.com> writes:

> Hi Arash, OK, thanks for your response, please feel free to
> close. Thanks, best, Paul

Thanks, then closing.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.