GNU bug report logs - #70578
[PATCH] ; Fix python test case for testing completion with ipython

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70578: closed ([PATCH] ; Fix python test case for testing
 completion with ipython)
Date: Thu, 02 May 2024 09:08:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 May 2024 12:06:57 +0300
with message-id <86bk5omvke.fsf <at> gnu.org>
and subject line Re: bug#70578: [PATCH] ; Fix python test case for testing completion with ipython
has caused the debbugs.gnu.org bug report #70578,
regarding [PATCH] ; Fix python test case for testing completion with ipython
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70578: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70578
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Fix python test case for testing completion with ipython
Date: Fri, 26 Apr 2024 03:27:34 +0000

[Message part 3 (text/plain, inline)]

Hi,
There is an error when running python-tests.el, I pasted on the tail
of this mail.

The error is caused by the test case trying testing the functions with
ipython but its subroutine didn't use the ipython as interpreter.

Changing the test interpreter will fix the issue, I attached the patch.

Please help apply the change. Thanks.


Test case error message:

Test python-shell-completion-at-point-ipython backtrace:
  call-process("python" nil t nil "-m" "jedi" "repl")
  (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
  (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
...
Test python-shell-completion-at-point-ipython condition:
    (file-missing "Searching for program" "No such file or directory"
                  "python")
   FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
sec) at python-tests.el:4897

[0001-Fix-python-test-case-for-testing-completion-with-ipy.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7.mail <at> gmail.com>
Cc: liuhui1610 <at> gmail.com, kobarity <at> gmail.com, 70578-done <at> debbugs.gnu.org
Subject: Re: bug#70578: [PATCH] ; Fix python test case for testing completion
 with ipython
Date: Thu, 02 May 2024 12:06:57 +0300

> From: Lin Sun <sunlin7.mail <at> gmail.com>
> Date: Mon, 29 Apr 2024 15:36:16 +0000
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Liu Hui <liuhui1610 <at> gmail.com>, 70578 <at> debbugs.gnu.org
> 
> On Sat, Apr 27, 2024 at 12:10 PM kobarity <kobarity <at> gmail.com> wrote:
> >
> >
> > I confirmed that Lin Sun's patch fixes this issue.  I Cc'd the author
> > of this ERT as well, just in case.
> 
> Thanks for confirmation, look forward to the merging happening.

Now installed on master, and closing the bug.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.