GNU bug report logs - #70578
[PATCH] ; Fix python test case for testing completion with ipython

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70578 in the body.
You can then email your comments to 70578 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; Fix python test case for testing completion with ipython
Date: Fri, 26 Apr 2024 03:27:34 +0000

[Message part 1 (text/plain, inline)]

Hi,
There is an error when running python-tests.el, I pasted on the tail
of this mail.

The error is caused by the test case trying testing the functions with
ipython but its subroutine didn't use the ipython as interpreter.

Changing the test interpreter will fix the issue, I attached the patch.

Please help apply the change. Thanks.


Test case error message:

Test python-shell-completion-at-point-ipython backtrace:
  call-process("python" nil t nil "-m" "jedi" "repl")
  (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
  (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
...
Test python-shell-completion-at-point-ipython condition:
    (file-missing "Searching for program" "No such file or directory"
                  "python")
   FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
sec) at python-tests.el:4897

[0001-Fix-python-test-case-for-testing-completion-with-ipy.patch (text/x-patch, attachment)]

Message #8 received at 70578 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7.mail <at> gmail.com>, kobarity <kobarity <at> gmail.com>
Cc: 70578 <at> debbugs.gnu.org
Subject: Re: bug#70578: [PATCH] ;
 Fix python test case for testing completion with ipython
Date: Sat, 27 Apr 2024 12:53:28 +0300

> From: Lin Sun <sunlin7.mail <at> gmail.com>
> Date: Fri, 26 Apr 2024 03:27:34 +0000
> 
> There is an error when running python-tests.el, I pasted on the tail
> of this mail.
> 
> The error is caused by the test case trying testing the functions with
> ipython but its subroutine didn't use the ipython as interpreter.
> 
> Changing the test interpreter will fix the issue, I attached the patch.
> 
> Please help apply the change. Thanks.
> 
> 
> Test case error message:
> 
> Test python-shell-completion-at-point-ipython backtrace:
>   call-process("python" nil t nil "-m" "jedi" "repl")
>   (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
>   (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> ...
> Test python-shell-completion-at-point-ipython condition:
>     (file-missing "Searching for program" "No such file or directory"
>                   "python")
>    FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
> sec) at python-tests.el:4897

Thanks.

kobarity, any comments about this or the patch?

Message #11 received at 70578 <at> debbugs.gnu.org (full text, mbox):

From: kobarity <kobarity <at> gmail.com>
To: Lin Sun <sunlin7.mail <at> gmail.com>,
	Eli Zaretskii <eliz <at> gnu.org>
Cc: Liu Hui <liuhui1610 <at> gmail.com>, 70578 <at> debbugs.gnu.org
Subject: Re: bug#70578: [PATCH] ;
 Fix python test case for testing completion with ipython
Date: Sat, 27 Apr 2024 21:09:36 +0900

Eli Zaretskii wrote:
> 
> > From: Lin Sun <sunlin7.mail <at> gmail.com>
> > Date: Fri, 26 Apr 2024 03:27:34 +0000
> > 
> > There is an error when running python-tests.el, I pasted on the tail
> > of this mail.
> > 
> > The error is caused by the test case trying testing the functions with
> > ipython but its subroutine didn't use the ipython as interpreter.
> > 
> > Changing the test interpreter will fix the issue, I attached the patch.
> > 
> > Please help apply the change. Thanks.
> > 
> > 
> > Test case error message:
> > 
> > Test python-shell-completion-at-point-ipython backtrace:
> >   call-process("python" nil t nil "-m" "jedi" "repl")
> >   (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
> >   (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> > ...
> > Test python-shell-completion-at-point-ipython condition:
> >     (file-missing "Searching for program" "No such file or directory"
> >                   "python")
> >    FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
> > sec) at python-tests.el:4897
> 
> Thanks.
> 
> kobarity, any comments about this or the patch?

I confirmed that Lin Sun's patch fixes this issue.  I Cc'd the author
of this ERT as well, just in case.

Message #14 received at 70578 <at> debbugs.gnu.org (full text, mbox):

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: kobarity <kobarity <at> gmail.com>
Cc: Liu Hui <liuhui1610 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 70578 <at> debbugs.gnu.org
Subject: Re: bug#70578: [PATCH] ; Fix python test case for testing completion
 with ipython
Date: Mon, 29 Apr 2024 15:36:16 +0000

On Sat, Apr 27, 2024 at 12:10 PM kobarity <kobarity <at> gmail.com> wrote:
>
>
> Eli Zaretskii wrote:
> >
> > > From: Lin Sun <sunlin7.mail <at> gmail.com>
> > > Date: Fri, 26 Apr 2024 03:27:34 +0000
> > >
> > > There is an error when running python-tests.el, I pasted on the tail
> > > of this mail.
> > >
> > > The error is caused by the test case trying testing the functions with
> > > ipython but its subroutine didn't use the ipython as interpreter.
> > >
> > > Changing the test interpreter will fix the issue, I attached the patch.
> > >
> > > Please help apply the change. Thanks.
> > >
> > >
> > > Test case error message:
> > >
> > > Test python-shell-completion-at-point-ipython backtrace:
> > >   call-process("python" nil t nil "-m" "jedi" "repl")
> > >   (eql 0 (call-process python-tests-shell-interpreter nil t nil "-m" "
> > >   (if (eql 0 (call-process python-tests-shell-interpreter nil t nil "-
> > > ...
> > > Test python-shell-completion-at-point-ipython condition:
> > >     (file-missing "Searching for program" "No such file or directory"
> > >                   "python")
> > >    FAILED  1/1  python-shell-completion-at-point-ipython (0.829918
> > > sec) at python-tests.el:4897
> >
> > Thanks.
> >
> > kobarity, any comments about this or the patch?
>
> I confirmed that Lin Sun's patch fixes this issue.  I Cc'd the author
> of this ERT as well, just in case.

Thanks for confirmation, look forward to the merging happening.

Message #19 received at 70578-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7.mail <at> gmail.com>
Cc: liuhui1610 <at> gmail.com, kobarity <at> gmail.com, 70578-done <at> debbugs.gnu.org
Subject: Re: bug#70578: [PATCH] ; Fix python test case for testing completion
 with ipython
Date: Thu, 02 May 2024 12:06:57 +0300

> From: Lin Sun <sunlin7.mail <at> gmail.com>
> Date: Mon, 29 Apr 2024 15:36:16 +0000
> Cc: Eli Zaretskii <eliz <at> gnu.org>, Liu Hui <liuhui1610 <at> gmail.com>, 70578 <at> debbugs.gnu.org
> 
> On Sat, Apr 27, 2024 at 12:10 PM kobarity <kobarity <at> gmail.com> wrote:
> >
> >
> > I confirmed that Lin Sun's patch fixes this issue.  I Cc'd the author
> > of this ERT as well, just in case.
> 
> Thanks for confirmation, look forward to the merging happening.

Now installed on master, and closing the bug.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.