GNU bug report logs - #70016
Emacs 29.3 treesit-parser-list function parameters differ from the master branch

Previous Next

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Meow King <mr.meowking <at> anche.no>, 70016 <at> debbugs.gnu.org
Subject: bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
Date: Wed, 27 Mar 2024 21:47:12 -0700

> On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: casouri <at> gmail.com
>> Date: Tue, 26 Mar 2024 11:23:00 +0800
>> From:  Meow King via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> I think it may be a bug (accidentally change code?) so I report it here.
>> 
>> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
>> but the treesit-parser-list on the latest Master Branch doesn't change,
>> accepting three optional parameters. 
> 
> According to "git log", it was a deliberate change.
> 
> Yuan, why did we change the signature, and why isn't tyhis called out
> in NEWS?

I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.

We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.

I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.