GNU bug report logs - #70016
Emacs 29.3 treesit-parser-list function parameters differ from the master branch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 70016 in the body.
You can then email your comments to 70016 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Meow King <mr.meowking <at> anche.no>
To: bug-gnu-emacs <at> gnu.org
Cc: casouri <at> gmail.com
Subject: Emacs 29.3 treesit-parser-list function parameters differ from the
 master branch
Date: Tue, 26 Mar 2024 11:23:00 +0800

[Message part 1 (text/plain, inline)]

I think it may be a bug (accidentally change code?) so I report it here.

Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
but the treesit-parser-list on the latest Master Branch doesn't change,
accepting three optional parameters. 

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Meow King <mr.meowking <at> anche.no>, casouri <at> gmail.com
Cc: 70016 <at> debbugs.gnu.org
Subject: Re: bug#70016: Emacs 29.3 treesit-parser-list function parameters
 differ from the master branch
Date: Tue, 26 Mar 2024 21:25:04 +0200

> Cc: casouri <at> gmail.com
> Date: Tue, 26 Mar 2024 11:23:00 +0800
> From:  Meow King via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> I think it may be a bug (accidentally change code?) so I report it here.
> 
> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
> but the treesit-parser-list on the latest Master Branch doesn't change,
> accepting three optional parameters. 

According to "git log", it was a deliberate change.

Yuan, why did we change the signature, and why isn't tyhis called out
in NEWS?

Message #13 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Meow King <mr.meowking <at> anche.no>, 70016 <at> debbugs.gnu.org
Subject: Re: bug#70016: Emacs 29.3 treesit-parser-list function parameters
 differ from the master branch
Date: Wed, 27 Mar 2024 21:47:12 -0700

> On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> Cc: casouri <at> gmail.com
>> Date: Tue, 26 Mar 2024 11:23:00 +0800
>> From:  Meow King via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> I think it may be a bug (accidentally change code?) so I report it here.
>> 
>> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
>> but the treesit-parser-list on the latest Master Branch doesn't change,
>> accepting three optional parameters. 
> 
> According to "git log", it was a deliberate change.
> 
> Yuan, why did we change the signature, and why isn't tyhis called out
> in NEWS?

I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.

We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.

I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).

Yuan

Message #16 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Meow King <mr.meowking <at> anche.no>
Cc: casouri <at> gmail.com, 70016 <at> debbugs.gnu.org
Subject: Re: bug#70016: Emacs 29.3 treesit-parser-list function parameters
 differ from the master branch
Date: Thu, 28 Mar 2024 09:06:25 +0200

> From: Meow King <mr.meowking <at> anche.no>
> Cc: 
> Date: Thu, 28 Mar 2024 10:11:37 +0800
> 
> I rechecked the Emacs 29.2 source code, and found it also accepts one
> parameter, so it may be my mistake since `treesit-parser-list` function
> in Emacs master branch has long ago differs from the Emacs 29's, and there
> is no problem with Emacs 29.3. It's because that I always work on Emacs
> master branch and recently a user of my package reported an issue
> related to Emacs 29.3 -- I think it's a issue for Emacs 29.3 without
> enough confirm. Sorry for the misinformation again.

Forwarding to the bug tracker.

Thanks for telling us.

The question why we changed the signature in Emacs 30 still stands.

Message #19 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: mr.meowking <at> anche.no, 70016 <at> debbugs.gnu.org
Subject: Re: bug#70016: Emacs 29.3 treesit-parser-list function parameters
 differ from the master branch
Date: Sat, 06 Apr 2024 12:17:21 +0300

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Wed, 27 Mar 2024 21:47:12 -0700
> Cc: Meow King <mr.meowking <at> anche.no>,
>  70016 <at> debbugs.gnu.org
> 
> > On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >> Cc: casouri <at> gmail.com
> >> Date: Tue, 26 Mar 2024 11:23:00 +0800
> >> From:  Meow King via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> I think it may be a bug (accidentally change code?) so I report it here.
> >> 
> >> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
> >> but the treesit-parser-list on the latest Master Branch doesn't change,
> >> accepting three optional parameters. 
> > 
> > According to "git log", it was a deliberate change.
> > 
> > Yuan, why did we change the signature, and why isn't tyhis called out
> > in NEWS?
> 
> I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
> 
> We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
> 
> I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).

Ping! Could you please do these documentation changes now?

Thanks.

Message #22 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: mr.meowking <at> anche.no, 70016 <at> debbugs.gnu.org
Subject: Re: bug#70016: Emacs 29.3 treesit-parser-list function parameters
 differ from the master branch
Date: Sun, 7 Apr 2024 23:29:34 -0700

> On Apr 6, 2024, at 2:17 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Wed, 27 Mar 2024 21:47:12 -0700
>> Cc: Meow King <mr.meowking <at> anche.no>,
>> 70016 <at> debbugs.gnu.org
>> 
>>> On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> 
>>>> Cc: casouri <at> gmail.com
>>>> Date: Tue, 26 Mar 2024 11:23:00 +0800
>>>> From:  Meow King via "Bug reports for GNU Emacs,
>>>> the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>>>> 
>>>> I think it may be a bug (accidentally change code?) so I report it here.
>>>> 
>>>> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
>>>> but the treesit-parser-list on the latest Master Branch doesn't change,
>>>> accepting three optional parameters. 
>>> 
>>> According to "git log", it was a deliberate change.
>>> 
>>> Yuan, why did we change the signature, and why isn't tyhis called out
>>> in NEWS?
>> 
>> I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
>> 
>> We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
>> 
>> I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).
> 
> Ping! Could you please do these documentation changes now?
> 
> Thanks.

My pleasure. It just happens today I finally got a day where I can sit down and write some code. I updated manual and news entries. There’s one thing though, I couldn’t find a good way to avoid using variables (which starts with lowercase) at the beginning of sentences. I don’t know how do you feel about having lower case letter at the beginning of sentences. If you have good tips on avoiding them I’m happy to apply it to all the occurrences in the new manual entries I wrote.

Yuan

Message #25 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: mr.meowking <at> anche.no, Eli Zaretskii <eliz <at> gnu.org>, 70017 <at> debbugs.gnu.org,
 70016 <at> debbugs.gnu.org
Subject: Re: bug#70017: Emacs 29.3 treesit-parser-list function parameters
 changed, while the master branch didn't
Date: Sat, 29 Jun 2024 22:56:49 -0700

Yuan Fu <casouri <at> gmail.com> writes:

> My pleasure. It just happens today I finally got a day where I can sit down and
> write some code. I updated manual and news entries. There’s one thing though, I
> couldn’t find a good way to avoid using variables (which starts with lowercase)
> at the beginning of sentences. I don’t know how do you feel about having lower
> case letter at the beginning of sentences. If you have good tips on avoiding
> them I’m happy to apply it to all the occurrences in the new manual entries I
> wrote.

My best idea for that is to reformulate the sentence.  It's not the end
of the world, IMHO.

Could this bug be closed?

Message #28 received at 70016 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Meow King <mr.meowking <at> anche.no>, Eli Zaretskii <eliz <at> gnu.org>,
 70017-done <at> debbugs.gnu.org, 70016 <at> debbugs.gnu.org
Subject: Re: bug#70017: Emacs 29.3 treesit-parser-list function parameters
 changed, while the master branch didn't
Date: Sun, 30 Jun 2024 21:54:45 -0700

> On Jun 29, 2024, at 10:56 PM, Stefan Kangas <stefankangas <at> gmail.com> wrote:
> 
> Yuan Fu <casouri <at> gmail.com> writes:
> 
>> My pleasure. It just happens today I finally got a day where I can sit down and
>> write some code. I updated manual and news entries. There’s one thing though, I
>> couldn’t find a good way to avoid using variables (which starts with lowercase)
>> at the beginning of sentences. I don’t know how do you feel about having lower
>> case letter at the beginning of sentences. If you have good tips on avoiding
>> them I’m happy to apply it to all the occurrences in the new manual entries I
>> wrote.
> 
> My best idea for that is to reformulate the sentence.  It's not the end
> of the world, IMHO.
> 
> Could this bug be closed?

Yes. I closed it. I personally am fine with having lowercase at the beginning, so I’ll live with it :-)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.