GNU bug report logs - #69953
[PATCH] Remove duplicated asserts and checks

Previous Next

Full log

Message #36 received at 69953 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sergey Vinokurov <serg.foo <at> gmail.com>
Cc: p.stephani2 <at> gmail.com, dancol <at> dancol.org, 69953 <at> debbugs.gnu.org
Subject: Re: bug#69953: [PATCH] Remove duplicated asserts and checks
Date: Sat, 11 May 2024 15:18:32 +0300

> Date: Sat, 11 May 2024 13:12:33 +0100
> Cc: p.stephani2 <at> gmail.com, dancol <at> dancol.org, 69953 <at> debbugs.gnu.org
> From: Sergey Vinokurov <serg.foo <at> gmail.com>
> 
> On 11/05/2024 11:02, Eli Zaretskii wrote:
> >> Date: Thu, 9 May 2024 15:16:05 +0100
> >> Cc: 69953 <at> debbugs.gnu.org
> >> From: Sergey Vinokurov <serg.foo <at> gmail.com>
> >>
> >>>>>> I added Daniel and Philipp to the discussion, in case they have
> >>>>>> comments to this proposal.
> >>>
> >>> Given the lack of comments, I conclude that there's no interest in
> >>> installing this, and I'm therefore closing this bug.
> >>
> >> I'm interested to get this installed - can I do anything to facilitate?
> > 
> > Given the lack of responses, I doubt that.
> 
> Is there no way to reevaluate the patch from the start? It's fairly 
> small, perhaps I did poor job explaining why it's good idea?

AFAIU, the code isn't wrong, and doesn't cause any problems.  You just
think it's redundant.  That's a judgment call, and without Daniel and
Philipp, who worked on most of this case, assessing the proposal, I
don't want to change code that worked well for us for several Emacs
releases, just because it might be redundant.

Why are you so eager to install these changes?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.