GNU bug report logs - #69954
13.3; allow TeX-fold auto-reveal customization

Previous Next

Package: auctex;

Reported by: Paul Nelson <ultrono <at> gmail.com>

Date: Sat, 23 Mar 2024 04:02:01 UTC

Severity: normal

Found in version 13.3

Done: Ikumi Keita <ikumi <at> ikumi.que.jp>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69954 in the body.
You can then email your comments to 69954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Sat, 23 Mar 2024 04:02:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Paul Nelson <ultrono <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-auctex <at> gnu.org. (Sat, 23 Mar 2024 04:02:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: 13.3; allow TeX-fold auto-reveal customization
Date: Sat, 23 Mar 2024 05:00:43 +0100

[Message part 1 (text/plain, inline)]
Hi all,

It would be useful to be able to customize when TeX-fold-mode
auto-reveals.  I attach a patch with my best attempt at this,
imitating what is done in preview.el.

Thanks, best,

Paul

[0001-Add-defcustom-TeX-fold-auto-reveal-controlling-when-.patch (application/octet-stream, attachment)]
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Sun, 24 Mar 2024 14:26:01 GMT) Full text and rfc822 format available.

Message #8 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Sun, 24 Mar 2024 23:24:16 +0900

[Message part 1 (text/plain, inline)]
Hi Paul,

>>>>> Paul Nelson <ultrono <at> gmail.com> writes:
> It would be useful to be able to customize when TeX-fold-mode
> auto-reveals.  I attach a patch with my best attempt at this,
> imitating what is done in preview.el.

Thanks for your proposal. I'm considering to apply slightly modified
patch as attached. I intend to have all `defcustom's in the early
block of the file and to improve similarity with preview.el.

What do you think about this idea?

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW


[patch (text/x-diff, attachment)]
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Sun, 24 Mar 2024 14:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Sun, 24 Mar 2024 15:35:08 +0100

Hi Ikumi,

Looks good to me!

Thanks, best,

Paul
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 06:52:01 GMT) Full text and rfc822 format available.

Message #14 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 15:50:15 +0900

>>>>> Paul Nelson <ultrono <at> gmail.com> writes:
> Hi Ikumi,
> Looks good to me!

Thank you, pushed to the git repo. I'll close this bug.

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
bug closed, send any further explanations to 69954 <at> debbugs.gnu.org and Paul Nelson <ultrono <at> gmail.com> Request was from Ikumi Keita <ikumi <at> ikumi.que.jp> to control <at> debbugs.gnu.org. (Mon, 25 Mar 2024 06:52:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 16:00:02 GMT) Full text and rfc822 format available.

Message #19 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 11:36:10 +0100

Hi Keita,

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

> Yes, I comitted without "Signed-off-by:" line, with me being the
> author.

Arrgh, my bad; I was looking at the other commit c290376d5d provided by
Paul and installed by you -- sorry for the noise :-(

Best, Arash
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 16:00:02 GMT) Full text and rfc822 format available.

Message #22 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 11:08:24 +0100

Hi Paul,

Paul Nelson <ultrono <at> gmail.com> writes:

> Yes, I have a copyright assignment for emacs and auctex as of Sept 18
> 2023.

Great, thanks for your swift response and your contribution.

Best, Arash
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 16:00:03 GMT) Full text and rfc822 format available.

Message #25 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Ikumi Keita <ikumi <at> ikumi.que.jp>
Cc: 69954 <at> debbugs.gnu.org, Paul Nelson <ultrono <at> gmail.com>
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 10:55:19 +0100

Ikumi Keita <ikumi <at> ikumi.que.jp> writes:

>>>>>> Paul Nelson <ultrono <at> gmail.com> writes:
>> Hi Ikumi,
>> Looks good to me!
>
> Thank you, pushed to the git repo. I'll close this bug.

Gents,

many thanks for providing and installing this change.

@Paul: Do you have a copyright assignment to FSF in place?  I can't
check that right now, but if not, you're getting close to the threshold
where we'll need one if you want to contribute more code to AUCTeX.

@Keita: We loosely try to follow the guidelines of Emacs which says[1]:

  - Commit messages should not contain the "Signed-off-by:" lines that
    are used in some other projects.

But no hassle, we try loosely :-)

Best, Arash

Footnotes:
[1]  https://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n243
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 16:18:01 GMT) Full text and rfc822 format available.

Message #28 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Arash Esbati <arash <at> gnu.org>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 19:19:12 +0900

Hi Arash,

>>>>> Arash Esbati <arash <at> gnu.org> writes:
> @Keita: We loosely try to follow the guidelines of Emacs which says[1]:

>   - Commit messages should not contain the "Signed-off-by:" lines that
>     are used in some other projects.

Yes, I comitted without "Signed-off-by:" line, with me being the author.
Did you actually mean to mention another paragraph in CONTRIBUTE?
(By the way, I should have included the bug number in the commit
message. 😞)

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 16:28:01 GMT) Full text and rfc822 format available.

Message #31 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Ikumi Keita <ikumi <at> ikumi.que.jp>
To: Arash Esbati <arash <at> gnu.org>
Cc: 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 21:13:07 +0900

Hi, Arash

>>>>> Arash Esbati <arash <at> gnu.org> writes:
> Arrgh, my bad; I was looking at the other commit c290376d5d provided by
> Paul and installed by you -- sorry for the noise :-(

Don't worry, I don't mind. :-)

Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded to bug-auctex <at> gnu.org:
bug#69954; Package auctex. (Mon, 25 Mar 2024 17:25:01 GMT) Full text and rfc822 format available.

Message #34 received at 69954 <at> debbugs.gnu.org (full text, mbox):

From: Paul Nelson <ultrono <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Ikumi Keita <ikumi <at> ikumi.que.jp>, 69954 <at> debbugs.gnu.org
Subject: Re: bug#69954: 13.3; allow TeX-fold auto-reveal customization
Date: Mon, 25 Mar 2024 11:01:16 +0100

Hi Arash,

Yes, I have a copyright assignment for emacs and auctex as of Sept 18 2023.

Thanks, best,

Paul
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 23 Apr 2024 11:25:03 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 115 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.