GNU bug report logs - #69921
[PATCH] eval-string: Fix setting port column

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69921: closed ([PATCH] eval-string: Fix setting port column)
Date: Mon, 06 May 2024 09:40:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 06 May 2024 11:38:35 +0200
with message-id <87zft3l1pg.fsf <at> gnu.org>
and subject line Re: bug#69921: [PATCH] eval-string: Fix setting port column
has caused the debbugs.gnu.org bug report #69921,
regarding [PATCH] eval-string: Fix setting port column
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69921: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69921
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: Nikita Domnitskii <nikita <at> domnitskii.me>, guile-devel <at> gnu.org
Cc: bug-guile <at> gnu.org
Subject: Re: [PATCH] eval-string: Fix setting port column
Date: Wed, 20 Mar 2024 21:12:52 +0100

[Message part 3 (text/plain, inline)]

On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
Cc: 69921-done <at> debbugs.gnu.org, Nikita Domnitskii <nikita <at> domnitskii.me>,
 guile-devel <at> gnu.org
Subject: Re: bug#69921: [PATCH] eval-string: Fix setting port column
Date: Mon, 06 May 2024 11:38:35 +0200

Jonas Hahnfeld <hahnjo <at> hahnjo.de> skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>            (if line
>>                (set-port-line! port line))
>>            (if column
>> -              (set-port-column! port line))
>> +              (set-port-column! port column))
>>  
>>            (if (or compile? (not (language-evaluator lang)))
>>                ((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.