GNU bug report logs - #69921
[PATCH] eval-string: Fix setting port column

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69921 in the body.
You can then email your comments to 69921 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: Nikita Domnitskii <nikita <at> domnitskii.me>, guile-devel <at> gnu.org
Cc: bug-guile <at> gnu.org
Subject: Re: [PATCH] eval-string: Fix setting port column
Date: Wed, 20 Mar 2024 21:12:52 +0100

[Message part 1 (text/plain, inline)]

On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 69921-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
Cc: 69921-done <at> debbugs.gnu.org, Nikita Domnitskii <nikita <at> domnitskii.me>,
 guile-devel <at> gnu.org
Subject: Re: bug#69921: [PATCH] eval-string: Fix setting port column
Date: Mon, 06 May 2024 11:38:35 +0200

Jonas Hahnfeld <hahnjo <at> hahnjo.de> skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>            (if line
>>                (set-port-line! port line))
>>            (if column
>> -              (set-port-column! port line))
>> +              (set-port-column! port column))
>>  
>>            (if (or compile? (not (language-evaluator lang)))
>>                ((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.