GNU bug report logs - #69920
29.2; gnus: article-mode: Toggling MIME inline attachment previews adds superfluous newlines

Previous Next

Package: emacs;

Reported by: Alcor <alcor <at> tilde.club>

Date: Wed, 20 Mar 2024 18:11:02 UTC

Severity: normal

Found in version 29.2

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

Full log


Message #40 received at 69920-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Alcor <alcor <at> tilde.club>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 69920-done <at> debbugs.gnu.org
Subject: Re: bug#69920: 29.2; gnus: article-mode: Toggling MIME inline
 attachment previews adds superfluous newlines
Date: Mon, 22 Apr 2024 07:58:02 -0700
Alcor <alcor <at> tilde.club> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> I also prefer #2, mostly because the other `mm-inline-*' functions here
>> all ensure that inlined content ends with a newline, and even if there's
>> no immediate consequence to not having it, I'd prefer the consistency.
>> Alcor, would you be willing to update your patch?
>
> Hello Eric, Eli –
>
> Attached is an updated patch adjusting the `delete-region' call in the
> undisplayer to account for the additional newline, as discussed earlier.
>
> I have tested this change on Emacs 29.3 (Linux/GTK) with multiple
> image/png attachments and can confirm it works.

In it goes -- thanks a lot.

Eric




This bug report was last modified 1 year and 26 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.