GNU bug report logs - #69920
29.2; gnus: article-mode: Toggling MIME inline attachment previews adds superfluous newlines

Previous Next

Package: emacs;

Reported by: Alcor <alcor <at> tilde.club>

Date: Wed, 20 Mar 2024 18:11:02 UTC

Severity: normal

Found in version 29.2

Done: Eric Abrahamsen <eric <at> ericabrahamsen.net>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Alcor <alcor <at> tilde.club>
To: 69920 <at> debbugs.gnu.org
Subject: bug#69920: Proposed fix - Toggling MIME inline attachment previews adds superfluous newlines
Date: Fri, 22 Mar 2024 23:25:20 +0100

Tags: patch

Add patch available mark to bug (forgot to do that in the previous
message).

git blame'ing the line in question on yields a decade-old
commit. Apparently, this used to be (insert "\n\n") … (delete-region b
(+ b 2)) about ~10 years ago, and the last relevant change turned that
into (insert "\n") … (delete-region b (1+ b)), but it seems lots of
other things on that codepath changed in the meantime.

FWIW, (insert-image … "x") (insert "\n") inserts two characters,
i.e. the image itself "x" and "\n", so it should either be (insert "\n")
… (delete-region b (+ 2 b)) or, alternatively just (delete-region b (1+
b)) (without any `insert' call).
This bug report was last modified 1 year and 25 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.