GNU bug report logs - #69801
[PATCH] reconfigure: Skip starting new shepherd services with auto-start? #f

Previous Next

Package: guix-patches;

Reported by: Richard Sent <richard <at> freakingpenguin.com>

Date: Thu, 14 Mar 2024 19:43:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Richard Sent <richard <at> freakingpenguin.com>
Subject: bug#69801: closed (Re: [bug#69801] [PATCH] reconfigure: Skip
 starting new shepherd services with auto-start? #f)
Date: Thu, 21 Mar 2024 13:58:03 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#69801: [PATCH] reconfigure: Skip starting new shepherd services with auto-start? #f

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 69801 <at> debbugs.gnu.org.

-- 
69801: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69801
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: 69801-done <at> debbugs.gnu.org, Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#69801] [PATCH] reconfigure: Skip starting new shepherd
 services with auto-start? #f
Date: Thu, 21 Mar 2024 14:56:23 +0100
Richard Sent <richard <at> freakingpenguin.com> skribis:

> Fixes <https://bugs.gnu.org/68093>.
>
> * guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Only add
> new shepherd services with auto-start? #t to to-start list.
>
> Change-Id: I268b921336fb1195ed76746eb6178889dbc258b4

Applied, thanks!

Ludo'.

[Message part 3 (message/rfc822, inline)]
From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] reconfigure: Skip starting new shepherd services with
 auto-start? #f
Date: Thu, 14 Mar 2024 15:40:11 -0400
Fixes <https://bugs.gnu.org/68093>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Only add
new shepherd services with auto-start? #t to to-start list.

Change-Id: I268b921336fb1195ed76746eb6178889dbc258b4
---
 guix/scripts/system/reconfigure.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index ff6242ffb4..9418060158 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -194,7 +194,8 @@ (define* (upgrade-shepherd-services eval os)
                             (filter live-service-running live-services)))
            (to-start   (lset-difference eqv?
                                         (map shepherd-service-canonical-name
-                                             target-services)
+                                             (filter shepherd-service-auto-start?
+                                                     target-services))
                                         running))
            (service-files (map shepherd-service-file target-services)))
       (eval #~(parameterize ((current-warning-port (%make-void-port "w")))

base-commit: 7319b4d5286d31a9c6a889e81af72308efdaab41
-- 
2.41.0




This bug report was last modified 1 year and 57 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.