GNU bug report logs - #69801
[PATCH] reconfigure: Skip starting new shepherd services with auto-start? #f

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69801 in the body.
You can then email your comments to 69801 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] reconfigure: Skip starting new shepherd services with
 auto-start? #f
Date: Thu, 14 Mar 2024 15:40:11 -0400

Fixes <https://bugs.gnu.org/68093>.

* guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Only add
new shepherd services with auto-start? #t to to-start list.

Change-Id: I268b921336fb1195ed76746eb6178889dbc258b4
---
 guix/scripts/system/reconfigure.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/scripts/system/reconfigure.scm b/guix/scripts/system/reconfigure.scm
index ff6242ffb4..9418060158 100644
--- a/guix/scripts/system/reconfigure.scm
+++ b/guix/scripts/system/reconfigure.scm
@@ -194,7 +194,8 @@ (define* (upgrade-shepherd-services eval os)
                             (filter live-service-running live-services)))
            (to-start   (lset-difference eqv?
                                         (map shepherd-service-canonical-name
-                                             target-services)
+                                             (filter shepherd-service-auto-start?
+                                                     target-services))
                                         running))
            (service-files (map shepherd-service-file target-services)))
       (eval #~(parameterize ((current-warning-port (%make-void-port "w")))

base-commit: 7319b4d5286d31a9c6a889e81af72308efdaab41
-- 
2.41.0

Message #10 received at 69801-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: 69801-done <at> debbugs.gnu.org, Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Ricardo Wurmus <rekado <at> elephly.net>,
 Christopher Baines <guix <at> cbaines.net>
Subject: Re: [bug#69801] [PATCH] reconfigure: Skip starting new shepherd
 services with auto-start? #f
Date: Thu, 21 Mar 2024 14:56:23 +0100

Richard Sent <richard <at> freakingpenguin.com> skribis:

> Fixes <https://bugs.gnu.org/68093>.
>
> * guix/scripts/system/reconfigure.scm (upgrade-shepherd-services): Only add
> new shepherd services with auto-start? #t to to-start list.
>
> Change-Id: I268b921336fb1195ed76746eb6178889dbc258b4

Applied, thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.