GNU bug report logs - #69669
[PATCH gnome-team 0/1] Update girara to 0.4.3

Previous Next

Full log

Message #41 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Vivien Kraus
 <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 19:40:16 +0100

Am Samstag, dem 09.03.2024 um 12:58 -0500 schrieb Maxim Cournoyer:
> Hello,
> 
> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
> 
> > Dear guix,
> > 
> > I split the cosmetic changes, and also split the non-cosmetic
> > change in 2.
> > json-glib is an optional dependency, so girara can exist with and
> > without it.
> > 
> > You were right, pango is already propagated from gtk+.
> > 
> > I also reordered the fields, but it does not look very intuitive,
> > because it looks like I moved the arguments field up and the
> > native-inputs field down instead of moving native-inputs and
> > propagated-inputs down (thanks git).
> > Should I also split the style update?
> > 
> > Best regards,
> > 
> > Vivien
> > 
> > Vivien Kraus (3):
> >   gnu: girara: Update style.
> >   gnu: girara: Update to 0.4.3.
> >   gnu: girara: Build with json-glib.
> > 
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
Hi, I've went ahead and pushed 1 and 2.  For 3, I'd like you to clarify
whether we ought to use propagated-inputs now or how else to handle
this.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.