GNU bug report logs - #69669
[PATCH gnome-team 0/1] Update girara to 0.4.3

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69669 in the body.
You can then email your comments to 69669 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team 0/1] Update girara to 0.4.3
Date: Sat, 9 Mar 2024 08:38:06 +0100

Dear Guix,

girara fails to build, but we can still update it.  It has an optional
dependency on json-glib, so maybe we could have it too.

What do you think?

Best regards,

Vivien

Vivien Kraus (1):
  gnu: girara: Update to 0.4.3.

 gnu/packages/gtk.scm | 53 +++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 25 deletions(-)


base-commit: 25c14c893f05019d746321285acf55d1aa65b943
-- 
2.41.0

Message #8 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team 1/1] gnu: girara: Update to 0.4.3.
Date: Sat, 9 Mar 2024 08:33:09 +0100

* gnu/packages/gtk.scm (girara): Update to 0.4.3.
[native-inputs]: Drop labels.
[propagated-inputs]: Add pango and json-glib.
[arguments]: Convert to list of G-Expressions.

Change-Id: I3c977cd33fa6d20fce3bb575ae2ad887b3061966
---
 gnu/packages/gtk.scm | 53 +++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index a00ce71b81..0c1b7fb5a0 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2132,7 +2132,7 @@ (define-public perl-pango
 (define-public girara
   (package
     (name "girara")
-    (version "0.3.7")
+    (version "0.4.3")
     (source
      (origin
        (method git-fetch)
@@ -2141,31 +2141,34 @@ (define-public girara
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0k93pi0lkf941vanvh1habm6n5wl1n63726j5kqxh34wdlv4mv4s"))))
-    (native-inputs `(("pkg-config" ,pkg-config)
-                     ("check" ,check)
-                     ("gettext" ,gettext-minimal)
-                     ("glib:bin" ,glib "bin")
-                     ("xorg-server" ,xorg-server-for-tests)))
-    ;; Listed in 'Requires.private' of 'girara.pc'.
-    (propagated-inputs (list gtk+))
+        (base32 "0cbcs3810frgdmal5ia9pf3rk3k5h4xyzw1d2ia3rcg4nms5gcpx"))))
+    (native-inputs
+     (list pkg-config
+           check
+           gettext-minimal
+           `(,glib "bin")
+           xorg-server-for-tests))
+    ;; Listed in 'Requires.private' or 'Requires' of 'girara.pc'.
+    (propagated-inputs (list gtk+ pango json-glib))
     (arguments
-     `(#:phases (modify-phases %standard-phases
-                  (add-before 'check 'start-xserver
-                    ;; Tests require a running X server.
-                    (lambda* (#:key inputs #:allow-other-keys)
-                      (let ((xorg-server (assoc-ref inputs "xorg-server"))
-                            (display ":1"))
-                        (setenv "DISPLAY" display)
-
-                        ;; On busy machines, tests may take longer than
-                        ;; the default of four seconds.
-                        (setenv "CK_DEFAULT_TIMEOUT" "20")
-
-                        ;; Don't fail due to missing '/etc/machine-id'.
-                        (setenv "DBUS_FATAL_WARNINGS" "0")
-                        (zero? (system (string-append xorg-server "/bin/Xvfb "
-                                                      display " &")))))))))
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'start-xserver
+            ;; Tests require a running X server.
+            (lambda* (#:key inputs #:allow-other-keys)
+              (let ((xorg-server (assoc-ref inputs "xorg-server"))
+                    (display ":1"))
+                (setenv "DISPLAY" display)
+
+                ;; On busy machines, tests may take longer than
+                ;; the default of four seconds.
+                (setenv "CK_DEFAULT_TIMEOUT" "20")
+
+                ;; Don't fail due to missing '/etc/machine-id'.
+                (setenv "DBUS_FATAL_WARNINGS" "0")
+                (zero? (system (string-append xorg-server "/bin/Xvfb "
+                                              display " &")))))))))
     (build-system meson-build-system)
     (home-page "https://pwmt.org/projects/girara/")
     (synopsis "Library for minimalistic gtk+3 user interfaces")
-- 
2.41.0

Message #11 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team 1/1] gnu: girara: Update to 0.4.3.
Date: Sat, 09 Mar 2024 09:24:20 +0100

Am Samstag, dem 09.03.2024 um 08:33 +0100 schrieb Vivien Kraus:
> * gnu/packages/gtk.scm (girara): Update to 0.4.3.
> [native-inputs]: Drop labels.
> [propagated-inputs]: Add pango and json-glib.
> [arguments]: Convert to list of G-Expressions.
> 
> Change-Id: I3c977cd33fa6d20fce3bb575ae2ad887b3061966
> ---
Since you are already mixing cosmetic and non-cosmetic changes, you can
also sort the fields.  Inputs typically go after arguments.
>  gnu/packages/gtk.scm | 53 +++++++++++++++++++++++-------------------
> --
>  1 file changed, 28 insertions(+), 25 deletions(-)
> 
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index a00ce71b81..0c1b7fb5a0 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -2132,7 +2132,7 @@ (define-public perl-pango
>  (define-public girara
>    (package
>      (name "girara")
> -    (version "0.3.7")
> +    (version "0.4.3")
>      (source
>       (origin
>         (method git-fetch)
> @@ -2141,31 +2141,34 @@ (define-public girara
>               (commit version)))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32
> "0k93pi0lkf941vanvh1habm6n5wl1n63726j5kqxh34wdlv4mv4s"))))
> -    (native-inputs `(("pkg-config" ,pkg-config)
> -                     ("check" ,check)
> -                     ("gettext" ,gettext-minimal)
> -                     ("glib:bin" ,glib "bin")
> -                     ("xorg-server" ,xorg-server-for-tests)))
> -    ;; Listed in 'Requires.private' of 'girara.pc'.
> -    (propagated-inputs (list gtk+))
> +        (base32
> "0cbcs3810frgdmal5ia9pf3rk3k5h4xyzw1d2ia3rcg4nms5gcpx"))))
> +    (native-inputs
> +     (list pkg-config
> +           check
> +           gettext-minimal
> +           `(,glib "bin")
> +           xorg-server-for-tests))
> +    ;; Listed in 'Requires.private' or 'Requires' of 'girara.pc'.
> +    (propagated-inputs (list gtk+ pango json-glib))
I'd hazard a guess that some of these are already propagated through
gtk+.
>      (arguments
> -     `(#:phases (modify-phases %standard-phases
> -                  (add-before 'check 'start-xserver
> -                    ;; Tests require a running X server.
> -                    (lambda* (#:key inputs #:allow-other-keys)
> -                      (let ((xorg-server (assoc-ref inputs "xorg-
> server"))
> -                            (display ":1"))
> -                        (setenv "DISPLAY" display)
> -
> -                        ;; On busy machines, tests may take longer
> than
> -                        ;; the default of four seconds.
> -                        (setenv "CK_DEFAULT_TIMEOUT" "20")
> -
> -                        ;; Don't fail due to missing '/etc/machine-
> id'.
> -                        (setenv "DBUS_FATAL_WARNINGS" "0")
> -                        (zero? (system (string-append xorg-server
> "/bin/Xvfb "
> -                                                      display "
> &")))))))))
> +     (list
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'check 'start-xserver
> +            ;; Tests require a running X server.
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (let ((xorg-server (assoc-ref inputs "xorg-server"))
> +                    (display ":1"))
> +                (setenv "DISPLAY" display)
> +
> +                ;; On busy machines, tests may take longer than
> +                ;; the default of four seconds.
> +                (setenv "CK_DEFAULT_TIMEOUT" "20")
> +
> +                ;; Don't fail due to missing '/etc/machine-id'.
> +                (setenv "DBUS_FATAL_WARNINGS" "0")
> +                (zero? (system (string-append xorg-server "/bin/Xvfb
> "
> +                                              display " &")))))))))
>      (build-system meson-build-system)
>      (home-page "https://pwmt.org/projects/girara/")
>      (synopsis "Library for minimalistic gtk+3 user interfaces")
Cheers

Message #14 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team v2 2/3] gnu: girara: Update to 0.4.3.
Date: Sat, 9 Mar 2024 08:33:09 +0100

* gnu/packages/gtk.scm (girara): Update to 0.4.3.

Change-Id: I3c977cd33fa6d20fce3bb575ae2ad887b3061966
---
 gnu/packages/gtk.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 033c5aee0f..950476815f 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2132,7 +2132,7 @@ (define-public perl-pango
 (define-public girara
   (package
     (name "girara")
-    (version "0.3.7")
+    (version "0.4.3")
     (source
      (origin
        (method git-fetch)
@@ -2141,7 +2141,7 @@ (define-public girara
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "0k93pi0lkf941vanvh1habm6n5wl1n63726j5kqxh34wdlv4mv4s"))))
+        (base32 "0cbcs3810frgdmal5ia9pf3rk3k5h4xyzw1d2ia3rcg4nms5gcpx"))))
     (arguments
      (list
       #:phases
-- 
2.41.0

Message #17 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 9 Mar 2024 10:00:04 +0100

Dear guix,

I split the cosmetic changes, and also split the non-cosmetic change in 2.
json-glib is an optional dependency, so girara can exist with and without it.

You were right, pango is already propagated from gtk+.

I also reordered the fields, but it does not look very intuitive, because it
looks like I moved the arguments field up and the native-inputs field down
instead of moving native-inputs and propagated-inputs down (thanks git).
Should I also split the style update?

Best regards,

Vivien

Vivien Kraus (3):
  gnu: girara: Update style.
  gnu: girara: Update to 0.4.3.
  gnu: girara: Build with json-glib.

 gnu/packages/gtk.scm | 53 +++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 25 deletions(-)


base-commit: 25c14c893f05019d746321285acf55d1aa65b943
-- 
2.41.0

Message #20 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team v2 1/3] gnu: girara: Update style.
Date: Sat, 9 Mar 2024 09:54:40 +0100

* gnu/packages/gtk.scm (girara)[arguments]: Convert to list of G-Expressions.
[native-inputs]: Move after arguments.
[propagated-inputs]: Move after arguments.

Change-Id: I79a6f59f6ea671433f1a66a10cb79203f0b9bbae
---
 gnu/packages/gtk.scm | 47 +++++++++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 22 deletions(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index a00ce71b81..033c5aee0f 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2142,30 +2142,33 @@ (define-public girara
        (file-name (git-file-name name version))
        (sha256
         (base32 "0k93pi0lkf941vanvh1habm6n5wl1n63726j5kqxh34wdlv4mv4s"))))
-    (native-inputs `(("pkg-config" ,pkg-config)
-                     ("check" ,check)
-                     ("gettext" ,gettext-minimal)
-                     ("glib:bin" ,glib "bin")
-                     ("xorg-server" ,xorg-server-for-tests)))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'start-xserver
+            ;; Tests require a running X server.
+            (lambda* (#:key inputs #:allow-other-keys)
+              (let ((xorg-server (assoc-ref inputs "xorg-server"))
+                    (display ":1"))
+                (setenv "DISPLAY" display)
+
+                ;; On busy machines, tests may take longer than
+                ;; the default of four seconds.
+                (setenv "CK_DEFAULT_TIMEOUT" "20")
+
+                ;; Don't fail due to missing '/etc/machine-id'.
+                (setenv "DBUS_FATAL_WARNINGS" "0")
+                (zero? (system (string-append xorg-server "/bin/Xvfb "
+                                              display " &")))))))))
+    (native-inputs
+     (list pkg-config
+           check
+           gettext-minimal
+           `(,glib "bin")
+           xorg-server-for-tests))
     ;; Listed in 'Requires.private' of 'girara.pc'.
     (propagated-inputs (list gtk+))
-    (arguments
-     `(#:phases (modify-phases %standard-phases
-                  (add-before 'check 'start-xserver
-                    ;; Tests require a running X server.
-                    (lambda* (#:key inputs #:allow-other-keys)
-                      (let ((xorg-server (assoc-ref inputs "xorg-server"))
-                            (display ":1"))
-                        (setenv "DISPLAY" display)
-
-                        ;; On busy machines, tests may take longer than
-                        ;; the default of four seconds.
-                        (setenv "CK_DEFAULT_TIMEOUT" "20")
-
-                        ;; Don't fail due to missing '/etc/machine-id'.
-                        (setenv "DBUS_FATAL_WARNINGS" "0")
-                        (zero? (system (string-append xorg-server "/bin/Xvfb "
-                                                      display " &")))))))))
     (build-system meson-build-system)
     (home-page "https://pwmt.org/projects/girara/")
     (synopsis "Library for minimalistic gtk+3 user interfaces")
-- 
2.41.0

Message #23 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib.
Date: Sat, 9 Mar 2024 09:58:58 +0100

* gnu/packages/gtk.scm (girara) [propagated-inputs]: Add json-glib.

Change-Id: I5bfe5a516885153014fce1c6643ac5799f0100e1
---
 gnu/packages/gtk.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 950476815f..3b834d748c 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2168,7 +2168,7 @@ (define-public girara
            `(,glib "bin")
            xorg-server-for-tests))
     ;; Listed in 'Requires.private' of 'girara.pc'.
-    (propagated-inputs (list gtk+))
+    (propagated-inputs (list gtk+ json-glib))
     (build-system meson-build-system)
     (home-page "https://pwmt.org/projects/girara/")
     (synopsis "Library for minimalistic gtk+3 user interfaces")
-- 
2.41.0

Message #26 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 10:24:16 +0100

Am Samstag, dem 09.03.2024 um 10:00 +0100 schrieb Vivien Kraus:
> Dear guix,
> 
> I split the cosmetic changes, and also split the non-cosmetic change
> in 2.  json-glib is an optional dependency, so girara can exist with
> and without it.
Would you care to elaborate?  Depending on the exact changes between
the version, I might want to squash this into one commit.

> You were right, pango is already propagated from gtk+.
> 
> I also reordered the fields, but it does not look very intuitive,
> because it looks like I moved the arguments field up and the native-
> inputs field down instead of moving native-inputs and propagated-
> inputs down (thanks git).
> Should I also split the style update?
Nah, that's fine.

Cheers

Message #29 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 13:33:01 +0100

Le samedi 09 mars 2024 à 10:24 +0100, Liliana Marie Prikler a écrit :
> > I split the cosmetic changes, and also split the non-cosmetic
> > change
> > in 2.  json-glib is an optional dependency, so girara can exist
> > with
> > and without it.
> Would you care to elaborate?  Depending on the exact changes between
> the version, I might want to squash this into one commit.

In meson_options.txt, here is the description for the 'json' option: 

```
description: 'dump configuration using JSON'
```

The README has:

```
The following dependencies are optional:

* `json-glib-1.0`: configuration dumping support
```

The blame tells us it was added in september 2022, so later than the
0.3.7 release (february 2022).

I don’t really understand what it’s used for, I have never developed
with girara.

Does this help?

Vivien

Message #32 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib.
Date: Sat, 09 Mar 2024 12:55:06 -0500

Hi Vivien,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gtk.scm (girara) [propagated-inputs]: Add json-glib.
>
> Change-Id: I5bfe5a516885153014fce1c6643ac5799f0100e1
> ---
>  gnu/packages/gtk.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
> index 950476815f..3b834d748c 100644
> --- a/gnu/packages/gtk.scm
> +++ b/gnu/packages/gtk.scm
> @@ -2168,7 +2168,7 @@ (define-public girara
>             `(,glib "bin")
>             xorg-server-for-tests))
>      ;; Listed in 'Requires.private' of 'girara.pc'.
> -    (propagated-inputs (list gtk+))
> +    (propagated-inputs (list gtk+ json-glib))

We'll want to revisit these propagated inputs after the core-updates
branch is merged, as Requires.private should only be needed when
producing static archives, not dynamic libraries (which pkgconf
interprets correctly).

-- 
Thanks,
Maxim

Message #35 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 12:58:07 -0500

Hello,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> Dear guix,
>
> I split the cosmetic changes, and also split the non-cosmetic change in 2.
> json-glib is an optional dependency, so girara can exist with and without it.
>
> You were right, pango is already propagated from gtk+.
>
> I also reordered the fields, but it does not look very intuitive, because it
> looks like I moved the arguments field up and the native-inputs field down
> instead of moving native-inputs and propagated-inputs down (thanks git).
> Should I also split the style update?
>
> Best regards,
>
> Vivien
>
> Vivien Kraus (3):
>   gnu: girara: Update style.
>   gnu: girara: Update to 0.4.3.
>   gnu: girara: Build with json-glib.
>

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #38 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib.
Date: Sat, 09 Mar 2024 19:22:40 +0100

Le samedi 09 mars 2024 à 12:55 -0500, Maxim Cournoyer a écrit :
> > -    (propagated-inputs (list gtk+))
> > +    (propagated-inputs (list gtk+ json-glib))
> 
> We'll want to revisit these propagated inputs after the core-updates
> branch is merged, as Requires.private should only be needed when
> producing static archives, not dynamic libraries (which pkgconf
> interprets correctly).

Should I do something in the mean time?

Message #41 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, Vivien Kraus
 <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 0/3] Update girara (better)
Date: Sat, 09 Mar 2024 19:40:16 +0100

Am Samstag, dem 09.03.2024 um 12:58 -0500 schrieb Maxim Cournoyer:
> Hello,
> 
> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
> 
> > Dear guix,
> > 
> > I split the cosmetic changes, and also split the non-cosmetic
> > change in 2.
> > json-glib is an optional dependency, so girara can exist with and
> > without it.
> > 
> > You were right, pango is already propagated from gtk+.
> > 
> > I also reordered the fields, but it does not look very intuitive,
> > because it looks like I moved the arguments field up and the
> > native-inputs field down instead of moving native-inputs and
> > propagated-inputs down (thanks git).
> > Should I also split the style update?
> > 
> > Best regards,
> > 
> > Vivien
> > 
> > Vivien Kraus (3):
> >   gnu: girara: Update style.
> >   gnu: girara: Update to 0.4.3.
> >   gnu: girara: Build with json-glib.
> > 
> 
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>
Hi, I've went ahead and pushed 1 and 2.  For 3, I'd like you to clarify
whether we ought to use propagated-inputs now or how else to handle
this.

Cheers

Message #44 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v2 3/3] gnu: girara: Build with json-glib.
Date: Mon, 11 Mar 2024 23:47:11 -0400

Hi,

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> Le samedi 09 mars 2024 à 12:55 -0500, Maxim Cournoyer a écrit :
>> > -    (propagated-inputs (list gtk+))
>> > +    (propagated-inputs (list gtk+ json-glib))
>> 
>> We'll want to revisit these propagated inputs after the core-updates
>> branch is merged, as Requires.private should only be needed when
>> producing static archives, not dynamic libraries (which pkgconf
>> interprets correctly).
>
> Should I do something in the mean time?

No, or if you want, you could leave a 'TODO: Remove propagated inputs
after core-updates is merged' or similar.

-- 
Thanks,
Maxim

Message #47 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69669 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team v3] gnu: girara: Build with json-glib.
Date: Sat, 9 Mar 2024 09:58:58 +0100

* gnu/packages/gtk.scm (girara) [propagated-inputs]: Add json-glib.

Change-Id: I5bfe5a516885153014fce1c6643ac5799f0100e1
---
The added comment has a date, so that the maintainer of the future knows
whether they can safely apply the change.

Best regards,

Vivien

 gnu/packages/gtk.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 950476815f..abbfc6fa16 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -2130,6 +2130,8 @@ (define-public perl-pango
     (license license:lgpl2.1+)))
 
 (define-public girara
+  ;; TODO: Move propagated inputs to inputs after core-updates is merged (as
+  ;; of 2024-03)
   (package
     (name "girara")
     (version "0.4.3")
@@ -2168,7 +2170,7 @@ (define-public girara
            `(,glib "bin")
            xorg-server-for-tests))
     ;; Listed in 'Requires.private' of 'girara.pc'.
-    (propagated-inputs (list gtk+))
+    (propagated-inputs (list gtk+ json-glib))
     (build-system meson-build-system)
     (home-page "https://pwmt.org/projects/girara/")
     (synopsis "Library for minimalistic gtk+3 user interfaces")

base-commit: fe2b2f860e1fd7dfdc333f65893e65f131e290c7
-- 
2.41.0

Message #50 received at 69669 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, liliana.prikler <at> gmail.com, 69669 <at> debbugs.gnu.org
Subject: Re: [PATCH gnome-team v3] gnu: girara: Build with json-glib.
Date: Tue, 12 Mar 2024 09:28:04 -0400

Vivien Kraus <vivien <at> planete-kraus.eu> writes:

> * gnu/packages/gtk.scm (girara) [propagated-inputs]: Add json-glib.
>
> Change-Id: I5bfe5a516885153014fce1c6643ac5799f0100e1

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

-- 
Thanks,
Maxim

Message #53 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: rg <at> raghavgururajan.name, Vivien Kraus <vivien <at> planete-kraus.eu>,
 liliana.prikler <at> gmail.com, guix-patches <at> gnu.org, 69669-done <at> debbugs.gnu.org
Subject: Re: [bug#69669] [PATCH gnome-team v3] gnu: girara: Build with
 json-glib.
Date: Sat, 16 Mar 2024 11:05:51 +0000

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Vivien Kraus <vivien <at> planete-kraus.eu> writes:
>
>> * gnu/packages/gtk.scm (girara) [propagated-inputs]: Add json-glib.
>>
>> Change-Id: I5bfe5a516885153014fce1c6643ac5799f0100e1
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail>

Thanks all, I've pushed this to gnome-team as
1caa0eeee5042f33bc0bb66dc38bed7513cad0fb.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.