GNU bug report logs - #6954
all viewed images left sitting in buffer-list

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6954 in the body.
You can then email your comments to 6954 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: all viewed images left sitting in buffer-list
Date: Tue, 31 Aug 2010 20:41:56 +0800

v runs the command dired-view-file
When run on a normal file, a subsequent q is
q runs the command View-quit

But when run upon a .jpg file,
a subsequent q is
q runs the command quit-window

Which leaves the buffer sitting around in the buffer-list!
C-x C-b runs the command list-buffers

emacs-version "24.0.50.1"

I don't know how you will wish to solve this problem. But please don't
ask the user to do C-u q when finished viewing an image vs. q for when
finished viewing a text file.

Message #14 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 8615 <at> debbugs.gnu.org,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Thu, 14 Jul 2011 15:53:41 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> C-u q does.  And in any case, I was just describing the usual binding
> used in special-modes, regardless of whether it behaves like view-mode.
> FWIW, I find view-mode's behavior generally odd and hard to predict (as
> a user), so I don't think it's crucial to always follow its lead.

No, but it would be nice if `v' in dired always did the same thing with
`q'.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #17 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: larsi <at> gnus.org
Cc: 8615 <at> debbugs.gnu.org, cyd <at> stupidchicken.com, monnier <at> iro.umontreal.ca,
	6954 <at> debbugs.gnu.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Sat, 16 Jul 2011 05:27:06 +0800

Now broken even more in
emacs-snapshot:
  Installed: 1:20110705-1

$ emacs -Q a_directory_with_images
type v on an image
type q
Now guess what we are looking at?
Back to the directory?
No.
You folks buried it!
And the image is also buried, not killed, too!

Message #20 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: jidanni <at> jidanni.org
Cc: 8615 <at> debbugs.gnu.org, cyd <at> stupidchicken.com, monnier <at> iro.umontreal.ca,
	6954 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Fri, 15 Jul 2011 23:30:16 +0200

jidanni <at> jidanni.org writes:

> Now broken even more in
> emacs-snapshot:
>   Installed: 1:20110705-1
>
> $ emacs -Q a_directory_with_images
> type v on an image
> type q
> Now guess what we are looking at?
> Back to the directory?
> No.
> You folks buried it!
> And the image is also buried, not killed, too!

I don't think anything has actually changed with the bug you reported,
but yeah, wow.  `q' popped to a totally different buffer than I
expected.

Is this a part of the switch-to-buffer/window thingie rework?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #23 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 8615 <at> debbugs.gnu.org, emacs-devel <at> gnu.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#6954: bug#8615: Please make sure v q removes the buffer for
	JPGs just like it does for other files
Date: Fri, 15 Jul 2011 16:57:34 -0600

On 7/15/2011 3:30 PM, Lars Magne Ingebrigtsen wrote:

>> $ emacs -Q a_directory_with_images
>> type v on an image
>> type q
>> Now guess what we are looking at?
>> Back to the directory?
>> No.
>> You folks buried it!
>> And the image is also buried, not killed, too!
>
> I don't think anything has actually changed with the bug you reported,
> but yeah, wow.  `q' popped to a totally different buffer than I
> expected.
>
> Is this a part of the switch-to-buffer/window thingie rework?

I can reproduce the described behavior with build from a couple of 
minutes ago.

According to describe-key, the `q' key is bound to quit-window. The `q' 
key should bury the buffer (image). `z' will kill it.

All of this is consistent with image-mode using special-mode map, which 
maps `q' to quit-window and `z' to kill buffer.

Not sure though, why `q' does not switch back to the dired buffer. It 
seems to put the dired buffer second in the buffer list and switch to 
the buffer which is first in the list.

Christoph

Message #26 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: cschol2112 <at> googlemail.com
Cc: cyd <at> stupidchicken.com, larsi <at> gnus.org, 8615 <at> debbugs.gnu.org,
	6954 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: bug#6954: bug#8615: Please make sure v q removes the buffer for
	JPGs just like it does for other files
Date: Sat, 16 Jul 2011 07:22:17 +0800

All I am asking is for the same actions for the same keys.
I'm willing to learn the new keys, as long as they are consistent.
Currently q and z act differently, depending on if one is viewing a
image vs. non image.

Even though both I got to via a "v" in dired.

CS> Not sure though, why `q' does not switch back to the dired buffer. It
CS> seems to put the dired buffer second in the buffer list and switch to
CS> the buffer which is first in the list.

That needs to be fixed too. That started last week.

Message #29 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: jidanni <at> jidanni.org
Cc: larsi <at> gnus.org, 8615 <at> debbugs.gnu.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: Re: bug#8615: bug#6954: bug#8615: Please make sure v q removes the
	buffer for JPGs just like it does for other files
Date: Fri, 15 Jul 2011 17:35:50 -0600

On 7/15/2011 5:22 PM, jidanni <at> jidanni.org wrote:
> All I am asking is for the same actions for the same keys.
> I'm willing to learn the new keys, as long as they are consistent.
> Currently q and z act differently, depending on if one is viewing a
> image vs. non image.
>
> Even though both I got to via a "v" in dired.

Most other files (all?) are opened in view-mode, which binds `q' and `z' 
differently. I think view-mode and special-mode need to agree on how to 
map certain keys, e.g. `q', i.e. common operations like quit or 
kill-buffer. Either by deriving view-mode from special-mode or matching 
the maps.

Message #32 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Christoph Scholtes <cschol2112 <at> googlemail.com>
Cc: 8615 <at> debbugs.gnu.org, emacs-devel <at> gnu.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8615: bug#6954: bug#8615: Please make sure v q removes the
	buffer for JPGs just like it does for other files
Date: Sat, 16 Jul 2011 01:38:56 +0200

Christoph Scholtes <cschol2112 <at> googlemail.com> writes:

> Most other files (all?) are opened in view-mode, which binds `q' and
> z' differently. I think view-mode and special-mode need to agree on
> how to map certain keys, e.g. `q', i.e. common operations like quit or
> kill-buffer. Either by deriving view-mode from special-mode or
> matching the maps.

It's not a view-mode issue.

Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
up in a buffer that wasn't the one you started in.

So `quit-window' and friends have apparently gotten a bit confused in
the last couple of days.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #35 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 8615 <at> debbugs.gnu.org, emacs-devel <at> gnu.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#6954: bug#8615: bug#6954: bug#8615: Please make sure v q
	removes the buffer for JPGs just like it does for other files
Date: Fri, 15 Jul 2011 18:40:24 -0600

On 7/15/2011 5:38 PM, Lars Magne Ingebrigtsen wrote:
> Christoph Scholtes<cschol2112 <at> googlemail.com>  writes:
>
>> Most other files (all?) are opened in view-mode, which binds `q' and
>> z' differently. I think view-mode and special-mode need to agree on
>> how to map certain keys, e.g. `q', i.e. common operations like quit or
>> kill-buffer. Either by deriving view-mode from special-mode or
>> matching the maps.
>
> It's not a view-mode issue.

IMO, it is very much a view-mode issue. The original issue description 
states that v q should remove the image buffer, i.e. kill it. It will 
never do this, since image-mode uses special mode map, and special-mode 
buries on `q', whereas other modes use view-mode. view-mode does kill 
the buffer on q, but I believe exit-action has to be set correctly.

> Open up a directory in dired.  Select a sub-directory.  Type `q'.  End
> up in a buffer that wasn't the one you started in.
>
> So `quit-window' and friends have apparently gotten a bit confused in
> the last couple of days.

This is a separate issue and needs to be fixed.

Message #38 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: larsi <at> gnus.org
Cc: 8615 <at> debbugs.gnu.org, cyd <at> stupidchicken.com, monnier <at> iro.umontreal.ca,
	6954 <at> debbugs.gnu.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Sat, 16 Jul 2011 20:24:30 +0800

After years of using v q SPC v q SPC v q SPC to view photos in dired,
you fellows latest tinkering has really thrown a monkey wrench into my life.
Though I even in my previous letter promised to learn the new ways,
I am afraid that is no longer possible.
Therefore perhaps someone can provide me with a doctors prescription I
can put into .emacs, that would make v and q act like the good old days.

Message #41 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 8615 <at> debbugs.gnu.org, emacs-devel <at> gnu.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like	it does for other files
Date: Sat, 16 Jul 2011 15:11:38 +0200

>> $ emacs -Q a_directory_with_images
>> type v on an image
>> type q
>> Now guess what we are looking at?
>> Back to the directory?
>> No.
>> You folks buried it!
>> And the image is also buried, not killed, too!
>
> I don't think anything has actually changed with the bug you reported,
> but yeah, wow.  `q' popped to a totally different buffer than I
> expected.
>
> Is this a part of the switch-to-buffer/window thingie rework?

It is ;-)  As a matter of fact it's the combination of

(1) a bug in Emacs 23's `pop-to-buffer' causing it to _not_ reselect the
    selected window when it's used for displaying the buffer, and

(2) a recent change which had `find-file' use `pop-to-buffer' instead of
    `set-window-buffer'.

Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
complained about it yet - after all `pop-to-buffer' was supposed to use
any but the selected window).

Thanks for complaining, martin

Message #44 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Christoph Scholtes <cschol2112 <at> googlemail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: cyd <at> stupidchicken.com, 6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org,
	Lars Magne Ingebrigtsen <larsi <at> gnus.org>, emacs-devel <at> gnu.org,
	8615 <at> debbugs.gnu.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like	it does for other files
Date: Sat, 16 Jul 2011 09:19:30 -0600

On 7/16/2011 7:11 AM, martin rudalics wrote:

> Hopefully fixed now (the bug in Emacs 23 remains unfixed since noone has
> complained about it yet - after all `pop-to-buffer' was supposed to use
> any but the selected window).

Now it behaves correctly on `q' and switches back to the dired buffer. 
Thanks for the fix.

However, the original issue reported is still not resolved. `q' buries 
the buffer and does not kill it, like it used to before special-mode was 
introduced.

Maybe Stefan or Chong can comment on whether this is to be regarded an 
issue or not.

I still think view-mode and special-mode need to be aligned in terms of 
these common actions.

Message #47 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 8615 <at> debbugs.gnu.org,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Sat, 16 Jul 2011 22:10:38 -0400

>> C-u q does.  And in any case, I was just describing the usual binding
>> used in special-modes, regardless of whether it behaves like view-mode.
>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>> a user), so I don't think it's crucial to always follow its lead.
> No, but it would be nice if `v' in dired always did the same thing
> with `q'.

Why?


        Stefan

Message #50 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 8615 <at> debbugs.gnu.org,
	6954 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Sun, 17 Jul 2011 04:23:46 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> C-u q does.  And in any case, I was just describing the usual binding
>>> used in special-modes, regardless of whether it behaves like view-mode.
>>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>>> a user), so I don't think it's crucial to always follow its lead.
>> No, but it would be nice if `v' in dired always did the same thing
>> with `q'.
>
> Why?

If the user uses `v', they probably expects to see the article in view
mode.  If they didn't, they would have hit RET instead.

One of the things that `v' gives you is `q'.

QED.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #53 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: monnier <at> iro.umontreal.ca
Cc: 8615 <at> debbugs.gnu.org, larsi <at> gnus.org, cyd <at> stupidchicken.com,
	6954 <at> debbugs.gnu.org
Subject: Re: bug#8615: Please make sure v q removes the buffer for JPGs just
	like it does for other files
Date: Sun, 17 Jul 2011 10:27:48 +0800

>>>>> "SM" == Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>>> C-u q does.  And in any case, I was just describing the usual binding
>>> used in special-modes, regardless of whether it behaves like view-mode.
>>> FWIW, I find view-mode's behavior generally odd and hard to predict (as
>>> a user), so I don't think it's crucial to always follow its lead.
>> No, but it would be nice if `v' in dired always did the same thing
>> with `q'.

SM> Why?

Because when we hit q on a text file, it neatly disappears (from the
buffer list), whereas hitting q on an image file oddly leaves it sitting
on the buffer list, one look at which would shock one off ones chair --
my god how did I stuff emacs memory with all those images?

Message #60 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Christoph Scholtes <cschol2112 <at> googlemail.com>
Cc: 6954 <at> debbugs.gnu.org, emacs-devel <at> gnu.org,
	martin rudalics <rudalics <at> gmx.at>,
	Lars Magne Ingebrigtsen <larsi <at> gnus.org>, jidanni <at> jidanni.org,
	8615 <at> debbugs.gnu.org
Subject: Re: bug#6954: bug#8615: Please make sure v q removes the buffer for
	JPGs just like	it does for other files
Date: Wed, 20 Jul 2011 11:09:27 -0400

Christoph Scholtes <cschol2112 <at> googlemail.com> writes:

> `q' buries the buffer and does not kill it, like it used to before
> special-mode was introduced.
>
> I still think view-mode and special-mode need to be aligned in terms
> of these common actions.

I don't see why it's important for `q' to do exactly the same thing in
view-mode and special-mode.  It seems reasonable for `q' to bury the
buffer in special-mode, which knows nothing about what the inheriting
mode's buffers are for (so burying is safer than killing).  In
view-mode, killing the buffer is reasonable if we regard view-mode as a
"less"-like quick way to view and then discard a file, in which case it
would be a nuisance to keep the buffer around afterward.

Message #63 received at 6954 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: cyd <at> stupidchicken.com
Cc: cschol2112 <at> googlemail.com, 6954 <at> debbugs.gnu.org, emacs-devel <at> gnu.org,
	rudalics <at> gmx.at, larsi <at> gnus.org, 8615 <at> debbugs.gnu.org
Subject: Re: bug#6954: bug#8615: Please make sure v q removes the buffer for
	JPGs just like	it does for other files
Date: Wed, 20 Jul 2011 23:40:13 +0800

>>>>> "CY" == Chong Yidong <cyd <at> stupidchicken.com> writes:
CY> I don't see why it's important for `q' to do exactly the same thing in

Well as long as there is a way for me the user to put something in his
.emacs file to "make sure v q removes the buffer for JPGs just like it
does for other files". Also like xli(1)'s q too.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.