GNU bug report logs - #69315
[PATCH] Build system fixes

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69315: closed ([PATCH] Build system fixes)
Date: Mon, 06 May 2024 09:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 06 May 2024 11:37:13 +0200
with message-id <874jbbmgc6.fsf <at> gnu.org>
and subject line Re: bug#69315: [PATCH] Build system fixes
has caused the debbugs.gnu.org bug report #69315,
regarding [PATCH] Build system fixes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69315: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69315
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: guile-devel <at> gnu.org, bug-guile <at> gnu.org
Subject: [PATCH] Build system fixes
Date: Thu, 22 Feb 2024 22:14:04 +0100

[Message part 3 (text/plain, inline)]

Dear Guile maintainers,

please find attached two patches for changes that we have been carrying
downstream in LilyPond so far: one fix to make a sed invocation fully
portable, and a fix for cross-compilation in out-of-tree-builds.

Regards
Jonas

[0001-build-Make-sed-invocation-fully-portable.patch (text/x-patch, attachment)]

[0002-build-Fix-cross-compilation-in-out-of-tree-builds.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
Cc: 69315-done <at> debbugs.gnu.org, guile-devel <at> gnu.org
Subject: Re: bug#69315: [PATCH] Build system fixes
Date: Mon, 06 May 2024 11:37:13 +0200

Hi Jonas,

Jonas Hahnfeld <hahnjo <at> hahnjo.de> skribis:

> From 428d1b17c5f664d3cb8da4cd5687bd47bdd87877 Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
> Date: Thu, 22 Feb 2024 21:57:41 +0100
> Subject: [PATCH 1/2] build: Make sed invocation fully portable
>
> Commit 08041d216f attempted to make the "invocation compatible with
> BSD sed", but moving '-i' first does not solve the problem because
> it still requires to pass an argument. Instead just redirect the
> instantiated output into a temporary file and install that.
>
> * libguile/Makefile.am: Remove '-i' from INSTANTIATE.

[...]

> From ad01912391b449fcf547ac52ed468f9b572cb0ad Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
> Date: Thu, 22 Feb 2024 22:10:06 +0100
> Subject: [PATCH 2/2] build: Fix cross-compilation in out-of-tree-builds
>
> gen-scmconfig.h is generated in libguile, not $(top_builddir).
>
> * libguile/Makefile.am: Add '-I.' when compiling gen-scmconfig.o.

Finally applied both, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.